Re: [fileupload] please help on reviewing FILEUPLOAD-199

2013-03-15 Thread Matt Benson
There seems to be nothing unusual contained in [1], so I don't know that anything further is necessary in [fileupload]'s NOTICE file. $0.02, Matt [1] http://svn.apache.org/viewvc/geronimo/specs/trunk/geronimo-javamail_1.4_spec/NOTICE?view=markup On Fri, Mar 15, 2013 at 3:41 PM, Simone Tripodi w

Re: [fileupload] please help on reviewing FILEUPLOAD-199

2013-03-15 Thread Simone Tripodi
Hi Matt!!! do you have any template sentence to put in the NOTICE, to suggest me? TIA! -Simo http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ On Thu, Mar 14, 2013 at 7:04 PM, Matt Benson wrote: > You might c

Re: [fileupload] please help on reviewing FILEUPLOAD-199

2013-03-15 Thread Felix Meschberger
Hi, Am 15.03.2013 um 11:25 schrieb Simone Tripodi: > Hi Felix! > >> Sorry, for still some nitpicking: the .util.mime package is now exported and >> thus (in OSGi view) part of the FileUpload API. Considering that the >> regulary library has no way of declaring some packages to *not* be API, th

Re: [fileupload] please help on reviewing FILEUPLOAD-199

2013-03-15 Thread Simone Tripodi
Hi Felix! > Sorry, for still some nitpicking: the .util.mime package is now exported and > thus (in OSGi view) part of the FileUpload API. Considering that the regulary > library has no way of declaring some packages to *not* be API, that is > acceptable. Correct ? thanks for pointing! I just

Re: [fileupload] please help on reviewing FILEUPLOAD-199

2013-03-15 Thread Felix Meschberger
Hi Simo Thanks, looks clean from an OSGi POV. Sorry, for still some nitpicking: the .util.mime package is now exported and thus (in OSGi view) part of the FileUpload API. Considering that the regulary library has no way of declaring some packages to *not* be API, that is acceptable. Correct ?

Re: [fileupload] please help on reviewing FILEUPLOAD-199

2013-03-14 Thread Matt Benson
You might check the NOTICE file in the project whence they came. Matt On Thu, Mar 14, 2013 at 11:42 AM, Simone Tripodi wrote: > Salut Luc/all, > > I replaced javax.mail classes with the ones provided by our friends of > Apache Geronimo, see r1456515. > I retailed the original classes in order t

Re: [fileupload] please help on reviewing FILEUPLOAD-199

2013-03-14 Thread Simone Tripodi
Salut Luc/all, I replaced javax.mail classes with the ones provided by our friends of Apache Geronimo, see r1456515. I retailed the original classes in order to drop unneeded stuff and have a pure MIME decoder. Do you have any feedback? What is the legal procedure to mention that those classes ha

Re: [fileupload] please help on reviewing FILEUPLOAD-199

2013-03-13 Thread Luc Maisonobe
Le 13/03/2013 16:46, Simone Tripodi a écrit : > Hi again Luc/all, > > I just realised that our fellows of Apache Geronimo ship an ALv2.0 > version of javax.mail[1] - there should be any kind of issue on > importing and adapting their source code, right? Sure. It's much better this way. Luc > >

Re: [fileupload] please help on reviewing FILEUPLOAD-199

2013-03-13 Thread Simone Tripodi
Hi again Luc/all, I just realised that our fellows of Apache Geronimo ship an ALv2.0 version of javax.mail[1] - there should be any kind of issue on importing and adapting their source code, right? TIA! -Simo [1] http://svn.apache.org/repos/asf/geronimo/specs/tags/geronimo-javamail_1.4_spec-1.4

Re: [fileupload] please help on reviewing FILEUPLOAD-199

2013-03-13 Thread Mark Thomas
On 13/03/2013 08:30, Jörg Schaible wrote: > Hi Simo, > > Simone Tripodi wrote: > >> Hi Felix! >> >>> While it looks like the new packages are not exported (which is good), I >>> now get an import on javax.mail.internet. I don't think this makes sense. >>> >> >> the javax.mail.internet import is a

Re: [fileupload] please help on reviewing FILEUPLOAD-199

2013-03-13 Thread Simone Tripodi
Guten Morgen Jörg! > Why do we have to shade here anything at all? fileupload is meant to run in > a JEE environment and javax.mail is then provided. I see your point, thanks! The reason why I thought shading those 2 classes was a good ideas is because today users are able to use FileUpload even

Re: [fileupload] please help on reviewing FILEUPLOAD-199

2013-03-13 Thread Jörg Schaible
Hi Simo, Simone Tripodi wrote: > Hi Felix! > >> While it looks like the new packages are not exported (which is good), I >> now get an import on javax.mail.internet. I don't think this makes sense. >> > > the javax.mail.internet import is at source level only, once the > shade-plugin has done i

Re: [fileupload] please help on reviewing FILEUPLOAD-199

2013-03-13 Thread Simone Tripodi
Salut Luc! thanks a lot for supervising, much more than appreciated! :) > > This should not be done in the LICENSE file but in the NOTICE file. > I think we already discussed it in the past and, while it is true that notes in NOTICE are missing, it is also true that redistributing 3rd parties re

Re: [fileupload] please help on reviewing FILEUPLOAD-199

2013-03-13 Thread Simone Tripodi
Hi Felix! > While it looks like the new packages are not exported (which is good), I now > get an import on javax.mail.internet. I don't think this makes sense. > the javax.mail.internet import is at source level only, once the shade-plugin has done its job, the import becomes o.a.c.fileupload.u

Re: [fileupload] please help on reviewing FILEUPLOAD-199

2013-03-12 Thread luc
Le 2013-03-12 11:15, Simone Tripodi a écrit : Hi all guys, Hi Simone, due to FILEUPLOAD-199, I shaded 2 classes from javax.mail package to support RFC2047 header values, I kindly ask you a couple of feedbacks about: * verify the shaded jar works in an integration test, if some of you has a

Re: [fileupload] please help on reviewing FILEUPLOAD-199

2013-03-12 Thread Felix Meschberger
Hi, Am 12.03.2013 um 11:15 schrieb Simone Tripodi: > Hi all guys, > > due to FILEUPLOAD-199, I shaded 2 classes from javax.mail package to > support RFC2047 header values, I kindly ask you a couple of feedbacks > about: > > * verify the shaded jar works in an integration test, if some of you >

[fileupload] please help on reviewing FILEUPLOAD-199

2013-03-12 Thread Simone Tripodi
Hi all guys, due to FILEUPLOAD-199, I shaded 2 classes from javax.mail package to support RFC2047 header values, I kindly ask you a couple of feedbacks about: * verify the shaded jar works in an integration test, if some of you has an application where experimenting the current SNAPSHOT; * rev