Re: [dbutils] bugfixing/java5 branches ready for merge

2009-02-25 Thread Dan Fabulich
Liam Coughlin wrote: DBUTILS-49QueryRunner - fillStatement method does not work for PostgreSQL database drivers I'm pretty sure this is addressed with the fill change to use the parametermetadata. Yes, this bug is yet another dupe of DB

Re: [dbutils] bugfixing/java5 branches ready for merge

2009-02-25 Thread Liam Coughlin
DBUTILS-49QueryRunner - fillStatement method does not work for PostgreSQL database drivers I'm pretty sure this is addressed with the fill change to use the parametermetadata. DBUTILS-48 Maintaining a parallel Java 1.5 version of DButil

Re: [dbutils] bugfixing/java5 branches ready for merge

2009-02-25 Thread Henri Yandell
On Tue, Feb 24, 2009 at 9:55 AM, Dan Fabulich wrote: > Henri Yandell wrote: > >> 742870 - ?? - Lacking Unit Tests, not liking the catch Exception. >> RuntimeException throwing needs String arg. Generally not trusting the >> Java API here to work beautifully and wanting to have covered a bunch >> o

Re: [dbutils] bugfixing/java5 branches ready for merge

2009-02-24 Thread Liam Coughlin
I vote for karma. On Tue, Feb 24, 2009 at 12:55 PM, Dan Fabulich wrote: > Henri Yandell wrote: > > 742870 - ?? - Lacking Unit Tests, not liking the catch Exception. >> RuntimeException throwing needs String arg. Generally not trusting the >> Java API here to work beautifully and wanting to have

Re: [dbutils] bugfixing/java5 branches ready for merge

2009-02-24 Thread Dan Fabulich
Henri Yandell wrote: 742870 - ?? - Lacking Unit Tests, not liking the catch Exception. RuntimeException throwing needs String arg. Generally not trusting the Java API here to work beautifully and wanting to have covered a bunch of use cases. Thanks for reviewing! I tweaked exception handling

Re: [dbutils] bugfixing/java5 branches ready for merge

2009-02-22 Thread Henri Yandell
Looking at the revisions on the bugfixes branch: 742870 - ?? - Lacking Unit Tests, not liking the catch Exception. RuntimeException throwing needs String arg. Generally not trusting the Java API here to work beautifully and wanting to have covered a bunch of use cases. 743293 - +1 - rename Generi

[dbutils] bugfixing/java5 branches ready for merge

2009-02-11 Thread Dan Fabulich
I've fixed a bunch of bugs in the bugfixing branch. I think I've fixed all except bug DBUTILS-30/-28 (they're dupes). https://svn.apache.org/repos/asf/commons/sandbox/dbutils/bugfixing http://svn.apache.org/viewvc/commons/sandbox/dbutils/bugfixing/ http://svn.apache.org/viewvc/commons/sandbox