Re: [dbcp] 1.3 release problems

2009-11-25 Thread Phil Steitz
sebb wrote: > On 24/11/2009, Phil Steitz wrote: >> sebb wrote: >> > On 24/11/2009, sebb wrote: >> >> On 24/11/2009, Phil Steitz wrote: >> >> > Phil Steitz wrote: >> >> > > sebb wrote: >> >> > >> On 22/11/2009, Phil Steitz wrote: >> >> > >>> I am running into some problems preparing

Re: [dbcp] 1.3 release problems

2009-11-24 Thread sebb
On 24/11/2009, Phil Steitz wrote: > sebb wrote: > > On 24/11/2009, sebb wrote: > >> On 24/11/2009, Phil Steitz wrote: > >> > Phil Steitz wrote: > >> > > sebb wrote: > >> > >> On 22/11/2009, Phil Steitz wrote: > >> > >>> I am running into some problems preparing for dbcp-1.3. I wou

Re: [dbcp] 1.3 release problems

2009-11-24 Thread Phil Steitz
sebb wrote: > On 24/11/2009, sebb wrote: >> On 24/11/2009, Phil Steitz wrote: >> > Phil Steitz wrote: >> > > sebb wrote: >> > >> On 22/11/2009, Phil Steitz wrote: >> > >>> I am running into some problems preparing for dbcp-1.3. I would >> > >>> appreciate comments / patches on any of

Re: [dbcp] 1.3 release problems

2009-11-24 Thread sebb
On 24/11/2009, sebb wrote: > On 24/11/2009, sebb wrote: > > On 24/11/2009, Phil Steitz wrote: > > > Phil Steitz wrote: > > > > sebb wrote: > > > >> On 22/11/2009, Phil Steitz wrote: > > > >>> I am running into some problems preparing for dbcp-1.3. I would > > > >>> appreciate c

Re: [dbcp] 1.3 release problems

2009-11-24 Thread sebb
On 24/11/2009, sebb wrote: > On 24/11/2009, Phil Steitz wrote: > > Phil Steitz wrote: > > > sebb wrote: > > >> On 22/11/2009, Phil Steitz wrote: > > >>> I am running into some problems preparing for dbcp-1.3. I would > > >>> appreciate comments / patches on any of the issues below. >

Re: [dbcp] 1.3 release problems

2009-11-24 Thread sebb
On 24/11/2009, Phil Steitz wrote: > Phil Steitz wrote: > > sebb wrote: > >> On 22/11/2009, Phil Steitz wrote: > >>> I am running into some problems preparing for dbcp-1.3. I would > >>> appreciate comments / patches on any of the issues below. > >>> > >>> 1. Findbugs is showing some real

Re: [dbcp] 1.3 release problems

2009-11-24 Thread Phil Steitz
Phil Steitz wrote: > sebb wrote: >> On 22/11/2009, Phil Steitz wrote: >>> I am running into some problems preparing for dbcp-1.3. I would >>> appreciate comments / patches on any of the issues below. >>> >>> 1. Findbugs is showing some real (inconsistent synch) and not so >>> real (e.g. serial

Re: [dbcp] 1.3 release problems

2009-11-24 Thread Phil Steitz
Jörg Schaible wrote: > Phil Steitz wrote at Sonntag, 22. November 2009 17:43: > >> I am running into some problems preparing for dbcp-1.3. I would >> appreciate comments / patches on any of the issues below. >> >> 1. Findbugs is showing some real (inconsistent synch) and not so >> real (e.g. seri

Re: [dbcp] 1.3 release problems

2009-11-23 Thread Phil Steitz
Phil Steitz wrote: > sebb wrote: >> PoolingConnection$PStmtKey.PoolingConnection$PStmtKey._resultSetType >> could be null and is guaranteed to be dereferenced in >> org.apache.commons.dbcp.PoolingConnection.makeObject(Object) >> This looks like a bug; just check for null in the second condition? >

Re: [dbcp] 1.3 release problems

2009-11-23 Thread Phil Steitz
sebb wrote: > On 23/11/2009, Phil Steitz wrote: >> sebb wrote: >> > On 22/11/2009, Phil Steitz wrote: >> >> sebb wrote: >> >> > On 22/11/2009, Phil Steitz wrote: >> >> >> I am running into some problems preparing for dbcp-1.3. I would >> >> >> appreciate comments / patches on any of th

Re: [dbcp] 1.3 release problems

2009-11-23 Thread Phil Steitz
or us, moving to 6 is quite >> fine. >> > >> > We strongly encourage our users to move away from 1.4.2 ASAP. >> > >> > Gary >> > >> >> -Original Message- >> >> From: Phil Steitz [mailto:phil.ste...@gmail.com] &g

Re: [dbcp] 1.3 release problems

2009-11-23 Thread sebb
On 23/11/2009, Phil Steitz wrote: > sebb wrote: > > On 22/11/2009, Phil Steitz wrote: > >> sebb wrote: > >> > On 22/11/2009, Phil Steitz wrote: > >> >> I am running into some problems preparing for dbcp-1.3. I would > >> >> appreciate comments / patches on any of the issues below. > >

Re: [dbcp] 1.3 release problems

2009-11-23 Thread sebb
Steitz [mailto:phil.ste...@gmail.com] > >> Sent: Sunday, November 22, 2009 14:03 > >> To: Commons Developers List > >> Subject: Re: [dbcp] 1.3 release problems > >> > >> Gary Gregory wrote: > >> > Does dropping support for Java 1.4 sim

RE: [dbcp] 1.3 release problems

2009-11-23 Thread Gary Gregory
> -Original Message- > From: Henri Yandell [mailto:flame...@gmail.com] > Sent: Sunday, November 22, 2009 21:17 > To: Commons Developers List > Subject: Re: [dbcp] 1.3 release problems > > Given that the Sun JDK's SSL implementation has the same problem as > o

Re: [dbcp] 1.3 release problems

2009-11-22 Thread Jörg Schaible
Phil Steitz wrote at Sonntag, 22. November 2009 17:43: > I am running into some problems preparing for dbcp-1.3. I would > appreciate comments / patches on any of the issues below. > > 1. Findbugs is showing some real (inconsistent synch) and not so > real (e.g. serialization issues on classes t

Re: [dbcp] 1.3 release problems

2009-11-22 Thread Henri Yandell
riginal Message- >> From: Phil Steitz [mailto:phil.ste...@gmail.com] >> Sent: Sunday, November 22, 2009 14:03 >> To: Commons Developers List >> Subject: Re: [dbcp] 1.3 release problems >> >> Gary Gregory wrote: >> > Does dropping support for Java 1.4 si

Re: [dbcp] 1.3 release problems

2009-11-22 Thread Phil Steitz
sebb wrote: > On 22/11/2009, Phil Steitz wrote: >> sebb wrote: >> > On 22/11/2009, Phil Steitz wrote: >> >> I am running into some problems preparing for dbcp-1.3. I would >> >> appreciate comments / patches on any of the issues below. >> >> >> >> 1. Findbugs is showing some real (inconsi

Re: [dbcp] 1.3 release problems

2009-11-22 Thread Phil Steitz
Grzegorz S?owikowski wrote: > Hi > > Phil Steitz wrote: >> I am running into some problems preparing for dbcp-1.3. I would >> appreciate comments / patches on any of the issues below. >> >> 1. Findbugs is showing some real (inconsistent synch) and not so >> real (e.g. serialization issues on clas

RE: [dbcp] 1.3 release problems

2009-11-22 Thread Gary Gregory
elopers List > Subject: Re: [dbcp] 1.3 release problems > > Gary Gregory wrote: > > Does dropping support for Java 1.4 simply the issue? > > No. Would have to drop 1.5 too. > > Phil > > > > Gary > > > >> -Original Message- >

Re: [dbcp] 1.3 release problems

2009-11-22 Thread Grzegorz S?owikowski
Hi Phil Steitz wrote: I am running into some problems preparing for dbcp-1.3. I would appreciate comments / patches on any of the issues below. 1. Findbugs is showing some real (inconsistent synch) and not so real (e.g. serialization issues on classes that IMO should not be serializable, but w

Re: [dbcp] 1.3 release problems

2009-11-22 Thread Phil Steitz
ns Developers List >> Subject: [dbcp] 1.3 release problems >> >> I am running into some problems preparing for dbcp-1.3. I would >> appreciate comments / patches on any of the issues below. >> >> 1. Findbugs is showing some real (inconsistent synch) and not

Re: [dbcp] 1.3 release problems

2009-11-22 Thread sebb
On 22/11/2009, Phil Steitz wrote: > sebb wrote: > > On 22/11/2009, Phil Steitz wrote: > >> I am running into some problems preparing for dbcp-1.3. I would > >> appreciate comments / patches on any of the issues below. > >> > >> 1. Findbugs is showing some real (inconsistent synch) and not

RE: [dbcp] 1.3 release problems

2009-11-22 Thread Gary Gregory
Does dropping support for Java 1.4 simply the issue? Gary > -Original Message- > From: Phil Steitz [mailto:phil.ste...@gmail.com] > Sent: Sunday, November 22, 2009 08:43 > To: Commons Developers List > Subject: [dbcp] 1.3 release problems > > I am running into so

Re: [dbcp] 1.3 release problems

2009-11-22 Thread Phil Steitz
Dennis Lundberg wrote: > Phil Steitz wrote: >> I am running into some problems preparing for dbcp-1.3. I would >> appreciate comments / patches on any of the issues below. >> >> 1. Findbugs is showing some real (inconsistent synch) and not so >> real (e.g. serialization issues on classes that IMO

Re: [dbcp] 1.3 release problems

2009-11-22 Thread Phil Steitz
sebb wrote: > On 22/11/2009, Phil Steitz wrote: >> I am running into some problems preparing for dbcp-1.3. I would >> appreciate comments / patches on any of the issues below. >> >> 1. Findbugs is showing some real (inconsistent synch) and not so >> real (e.g. serialization issues on classes t

Re: [dbcp] 1.3 release problems

2009-11-22 Thread sebb
On 22/11/2009, Phil Steitz wrote: > I am running into some problems preparing for dbcp-1.3. I would > appreciate comments / patches on any of the issues below. > > 1. Findbugs is showing some real (inconsistent synch) and not so > real (e.g. serialization issues on classes that IMO should not

Re: [dbcp] 1.3 release problems

2009-11-22 Thread Dennis Lundberg
Phil Steitz wrote: > I am running into some problems preparing for dbcp-1.3. I would > appreciate comments / patches on any of the issues below. > > 1. Findbugs is showing some real (inconsistent synch) and not so > real (e.g. serialization issues on classes that IMO should not be > serializable,

[dbcp] 1.3 release problems

2009-11-22 Thread Phil Steitz
I am running into some problems preparing for dbcp-1.3. I would appreciate comments / patches on any of the issues below. 1. Findbugs is showing some real (inconsistent synch) and not so real (e.g. serialization issues on classes that IMO should not be serializable, but we can't fix until 2.0).