On 22 March 2012 10:40, sebb wrote:
> On 22 March 2012 07:33, Benedikt Ritter wrote:
>> Am 22. März 2012 00:19 schrieb sebb :
>>> On 21 March 2012 19:16, Benedikt Ritter wrote:
Hey,
I've tried to remove the Token input parameter in CSVLexer.nextToken().
First by creating ne n
On 22 March 2012 07:33, Benedikt Ritter wrote:
> Am 22. März 2012 00:19 schrieb sebb :
>> On 21 March 2012 19:16, Benedikt Ritter wrote:
>>> Hey,
>>>
>>> I've tried to remove the Token input parameter in CSVLexer.nextToken().
>>> First by creating ne new Token on every invocation of nextToken().
Am 22. März 2012 00:19 schrieb sebb :
> On 21 March 2012 19:16, Benedikt Ritter wrote:
>> Hey,
>>
>> I've tried to remove the Token input parameter in CSVLexer.nextToken().
>> First by creating ne new Token on every invocation of nextToken().
>> That slowed execution of that method by about 100ms.
On 21 March 2012 19:16, Benedikt Ritter wrote:
> Hey,
>
> I've tried to remove the Token input parameter in CSVLexer.nextToken().
> First by creating ne new Token on every invocation of nextToken().
> That slowed execution of that method by about 100ms.
100ms per iteration? Or for the entire file
Hey,
I've tried to remove the Token input parameter in CSVLexer.nextToken().
First by creating ne new Token on every invocation of nextToken().
That slowed execution of that method by about 100ms. So I added a
private Token field to CSVLexer, that only get's initiated once. But
that solution was a
Le 16/03/2012 17:01, Emmanuel Bourg a écrit :
2. add additional convenience methods
Right now we have some methods for char handling like isEndOfFile(c).
There are some methods missing like isDelimiter(c) or
isEncapsulator(c). There is not much to say about this. I just think
that isDelimiter(c)
Le 16/03/2012 13:33, Benedikt Ritter a écrit :
1. eliminate Token input parameter on nextToken()
To me it looks like the token input parameter on nextToken() has the
purpose of sparing object creation. How about a private field
'currentToken' that can be reused. No method parameters are better
t
On 16 March 2012 12:33, Benedikt Ritter wrote:
> Hey,
>
> I'm thinking of ways to improve the readability of CSVLexer. I think
> that it might be easier to improve performance if the code is easier
> to understand. Here is, what I think can be improved:
>
> 1. eliminate Token input parameter on ne
Hey,
I'm thinking of ways to improve the readability of CSVLexer. I think
that it might be easier to improve performance if the code is easier
to understand. Here is, what I think can be improved:
1. eliminate Token input parameter on nextToken()
To me it looks like the token input parameter on n
