Re: [crypto] examples in the production code

2016-06-30 Thread Benedikt Ritter
Gary Gregory schrieb am Do., 30. Juni 2016 um 22:22 Uhr: > Why not just put them in the test tree. That feels more appropriate, at > least to me. > +1 > > Gary > On Jun 30, 2016 12:00 PM, "sebb" wrote: > > > This was done to ensure that the code actually worked; the original > > snippets in t

Re: [crypto] examples in the production code

2016-06-30 Thread Gary Gregory
Why not just put them in the test tree. That feels more appropriate, at least to me. Gary On Jun 30, 2016 12:00 PM, "sebb" wrote: > This was done to ensure that the code actually worked; the original > snippets in the user guide did not work. > > The source xref is now referenced from the user g

Re: [crypto] examples in the production code

2016-06-30 Thread sebb
This was done to ensure that the code actually worked; the original snippets in the user guide did not work. The source xref is now referenced from the user guide which ensures that the code is valid. This seemed like the best way to do this. The examples package can always be excluded from the s

[crypto] examples in the production code

2016-06-30 Thread Gary Gregory
Hi, It seems to me that org.apache.commons.crypto.examples does not belong in the main tree. Gary -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition JUnit in Action, Second Edition