Re: [compress] XZ support

On 2011-10-25, Jörg Schaible wrote: > Stefan Bodewig wrote: >> From the POV of the Compress Antlib for example I now need to tell >> people to fetch Common Compress and in the future Id have to tell them >> to fetch XZ as well. Then again this is a problem I should solve over >> there. > Couldn

Re: [compress] XZ support

On 2011-10-25, sebb wrote: > On 25 October 2011 16:41, Stefan Bodewig wrote: >> That would be easiest but at the same time force an additional >> dependency for people who don't use XZ at all.  One they could >> explicitly exclude in their POM or ivy.xml or whatever, of course. > Can the depend

Re: [compress] XZ support

Stefan Bodewig wrote: [snip] > From the POV of the Compress Antlib for example I now need to tell > people to fetch Common Compress and in the future Id have to tell them > to fetch XZ as well. Then again this is a problem I should solve over > there. Couldn't you simply shade Commons Compress

Re: [compress] XZ support

>> Maybe not in this case, but if the dependency is then updated AIUI >> using shading would prevent the user from updating the dependency >> independently. > > This is my understanding as well.  I've also been told packagers - those > people that create RPMs or debs or ... - don't like shaded depe

Re: [compress] XZ support

On 25 October 2011 16:41, Stefan Bodewig wrote: > On 2011-10-25, sebb wrote: > >> On 25 October 2011 09:50, Torsten Curdt wrote: > So I would only release the shaded jar. > IIRC sebb objected to shading. > >>> Why was that, sebb? > >> I don't recall saying that I objected; I did wonder w

Re: [compress] XZ support

On 2011-10-25, sebb wrote: > On 25 October 2011 09:50, Torsten Curdt wrote: So I would only release the shaded jar. >>> IIRC sebb objected to shading. >> Why was that, sebb? > I don't recall saying that I objected; I did wonder what advantage it > would give. Probably I read more into th

Re: [compress] XZ support

On 25 October 2011 09:50, Torsten Curdt wrote: >>> So I would only release the shaded jar. >> >> IIRC sebb objected to shading. > > Why was that, sebb? I don't recall saying that I objected; I did wonder what advantage it would give. > I cannot think of a good reason why this should be a problem

Re: [compress] XZ support

>> So I would only release the shaded jar. > > IIRC sebb objected to shading. Why was that, sebb? I cannot think of a good reason why this should be a problem. >  We have the choice of releasing only a > shaded jar, only a plain jar with a POM that states a hard-dependency > or releasing two art

Re: [compress] XZ support

On 2011-10-24, Torsten Curdt wrote: >> Do we want to add XZ support now or wait until after 1.3 has been >> released? >> In either case I'd intend to call for a vote on a first RC for Compress >> 1.3 no later than next week. > I would skip it for this release. This seems to be consensus, expect

Re: [compress] XZ support

> XZ for Java has landed in Maven Central[1] (thanks, Lasse!) and together Yay!! :) > with COMPRESS-156 it would be pretty easy to add support for XZ > compression. > > The patch in COMPRESS-156 comes without tests or docs but either are > very easy to create as clones of the GZip counterparts. >

Re: [compress] XZ support

On Oct 24, 2011, at 9:26, Stefan Bodewig wrote: > Hi all, > > XZ for Java has landed in Maven Central[1] (thanks, Lasse!) and together > with COMPRESS-156 it would be pretty easy to add support for XZ > compression. > > The patch in COMPRESS-156 comes without tests or docs but either are > very e

[compress] XZ support

Hi all, XZ for Java has landed in Maven Central[1] (thanks, Lasse!) and together with COMPRESS-156 it would be pretty easy to add support for XZ compression. The patch in COMPRESS-156 comes without tests or docs but either are very easy to create as clones of the GZip counterparts. Do we want to

Re: [compress] XZ support and inconsistencies in the existing compressors

Is this ? On 2011-08-04, Lasse Collin wrote: > On 2011-08-04 Stefan Bodewig wrote: >> On 2011-08-04, Lasse Collin wrote: >>> Yes. I didn't check the suggested fix though. >> Would be nice if you'd find the time to do so. > It uses in.av

Re: [compress] XZ support and inconsistencies in the existing compressors

On 2011-08-04 Stefan Bodewig wrote: > On 2011-08-04, Lasse Collin wrote: > > Using bits from the end of stream magic doesn't make sense, because > > then one would be forced to finish the stream. Using the bits from > > the block header magic means that one must add at least one more > > block. Thi

Re: [compress] XZ support and inconsistencies in the existing compressors

On 2011-08-04, Lasse Collin wrote: > On 2011-08-04 Stefan Bodewig wrote: >> This is in a big part due to the history of Commons Compress which >> combined several different codebases with separate APIs and provided a >> first attempt to layer a unifying API on top of it. We are aware of >> quite

Re: [compress] XZ support and inconsistencies in the existing compressors

On 2011-08-04 Stefan Bodewig wrote: > On 2011-08-03, Lasse Collin wrote: > > I looked at the APIs and code in Commons Compress to see how XZ > > support could be added. I was especially looking for details where > > one would need to be careful to make different compressors behave > > consistently

Re: [compress] XZ support and inconsistencies in the existing compressors

Hi Lasse and welcome On 2011-08-03, Lasse Collin wrote: > I have been working on XZ data compression implementation in Java > . I was told that it could be nice > to get XZ support into Commons Compress. Sounds interesting. > I looked at the APIs and code in Com

Re: [compress] XZ support and inconsistencies in the existing compressors

Hi Lasse! I'd personally like if you could fill an Issue on Jira and submit your XZ implementation as a patch that naturally fits in the org.apache.commons.compress package and you continue contributing on maintaining it - maybe depending on an external package would be more difficult since commons

[compress] XZ support and inconsistencies in the existing compressors

Hi! I have been working on XZ data compression implementation in Java . I was told that it could be nice to get XZ support into Commons Compress. I looked at the APIs and code in Commons Compress to see how XZ support could be added. I was especially looking for d