Re: [compress] TarArchiveEntry and Windows drive letter

2018-01-28 Thread Stefan Bodewig
On 2018-01-28, Torsten Curdt wrote: >>> This is what I suggested. Change the meaning of "preserveLeadingSlashes" >>> to "preserveAbsolutePath" and use it to keep the drive letter on >>> Windows. >>> The current code will always strip the drive letter spec. >> In that case, I agree with you. >>

Re: [compress] TarArchiveEntry and Windows drive letter

2018-01-28 Thread Torsten Curdt
> > This is what I suggested. Change the meaning of "preserveLeadingSlashes" > > to "preserveAbsolutePath" and use it to keep the drive letter on > > Windows. > > > > The current code will always strip the drive letter spec. > > In that case, I agree with you. > > Also as a name, 'preserveLeadingS

Re: [compress] TarArchiveEntry and Windows drive letter

2018-01-22 Thread sebb
On 22 January 2018 at 09:53, Stefan Bodewig wrote: > On 2018-01-21, sebb wrote: > >> On 21 January 2018 at 16:07, Stefan Bodewig wrote: > >>> The contract of tar archives is they contain relative path names. GNU >>> tar strips leading slashes both when creating archives and when >>> extracting ar

Re: [compress] TarArchiveEntry and Windows drive letter

2018-01-22 Thread Stefan Bodewig
On 2018-01-21, sebb wrote: > On 21 January 2018 at 16:07, Stefan Bodewig wrote: >> The contract of tar archives is they contain relative path names. GNU >> tar strips leading slashes both when creating archives and when >> extracting archives who's entry names contain leading slashes. Sticking >

Re: [compress] TarArchiveEntry and Windows drive letter

2018-01-21 Thread sebb
On 21 January 2018 at 16:07, Stefan Bodewig wrote: > On 2018-01-05, Torsten Curdt wrote: > TarArchiveEntry("C:\foo\bar") -> "/foo/bar" TarArchiveEntry("D:\foo\bar") -> "/foo/bar" > >>> "strip the drive letter" predates preserveLeadingSlashes > >> Might be but I guess the only quest

Re: [compress] TarArchiveEntry and Windows drive letter

2018-01-21 Thread Stefan Bodewig
On 2018-01-05, Torsten Curdt wrote: >>>TarArchiveEntry("C:\foo\bar") -> "/foo/bar" >>>TarArchiveEntry("D:\foo\bar") -> "/foo/bar" >> "strip the drive letter" predates preserveLeadingSlashes > Might be but I guess the only question is how to fix it without breaking > too many things. > I

Re: [compress] TarArchiveEntry and Windows drive letter

2018-01-05 Thread Torsten Curdt
> >TarArchiveEntry("C:\foo\bar") -> "/foo/bar" > >TarArchiveEntry("D:\foo\bar") -> "/foo/bar" > > "strip the drive letter" predates preserveLeadingSlashes > Might be but I guess the only question is how to fix it without breaking too many things. I am not such a big fan of "preserveLeading

Re: [compress] TarArchiveEntry and Windows drive letter

2018-01-04 Thread Stefan Bodewig
On 2018-01-03, Torsten Curdt wrote: > I just found a new issue with compress. > It's the "normalizeFileName" in TarArchiveEntry again. > On Windows it just strips the drive letter > https://github.com/apache/commons-compress/blob/master/src/ > main/java/org/apache/commons/compress/archivers/tar/

Re: [compress] TarArchiveEntry and Windows drive letter

2018-01-03 Thread Gary Gregory
I do not see how skipping the drive letter on Windows is not normalizing, it is _moving_ sounds like a bug to me. Gary On Wed, Jan 3, 2018 at 8:46 AM, Torsten Curdt wrote: > I just found a new issue with compress. > > It's the "normalizeFileName" in TarArchiveEntry again. > On Windows it ju

[compress] TarArchiveEntry and Windows drive letter

2018-01-03 Thread Torsten Curdt
I just found a new issue with compress. It's the "normalizeFileName" in TarArchiveEntry again. On Windows it just strips the drive letter https://github.com/apache/commons-compress/blob/master/src/ main/java/org/apache/commons/compress/archivers/tar/ TarArchiveEntry.java#L1337 which I think is a