On Fri, Feb 6, 2009 at 3:18 AM, Stefan Bodewig wrote:
> On 2009-02-05, Christian Grobmeier wrote:
>
>>> * ZipOutputStream contains some proteted static final byte[]
>>> "constants"
>
>>> This means any subclass could modify them. Findbugs suggests to
>>> make the package private. Ant couldn'
> The svn merges were more or less painless, the only conflict I got was
> in UnknownExtraField because the commons-compress version uses m_foo
> fields where Ant uses foo (likely because of Avalon/Peter Donald
> coding style).
If you could do that - yes, thats cool then.
> I suggest we add the n
On 2009-02-05, Christian Grobmeier wrote:
>> * ZipOutputStream contains some proteted static final byte[]
>> "constants"
>> This means any subclass could modify them. Findbugs suggests to
>> make the package private. Ant couldn't do that because of backwards
>> incompatibility, but a sandb
On 05/02/2009, Christian Grobmeier wrote:
> Hi,
> thanks Stefan for running findbugs! I'll try to give answers as far as
> I know till now.
>
>
> > * JarArchiveEntry certificates and manifestAttributes is never written
> > to, so they are useless.
> >
> > I'm unsure of the class' purpose a
Hi,
thanks Stefan for running findbugs! I'll try to give answers as far as
I know till now.
> * JarArchiveEntry certificates and manifestAttributes is never written
> to, so they are useless.
>
> I'm unsure of the class' purpose and simply left things as they are,
> assuming setters will be pro
Since Sebb's original report the code base has changed quite a bit so
I reran findbugs.
I've fixed most of them, still open are:
* JarArchiveEntry certificates and manifestAttributes is never written
to, so they are useless.
I'm unsure of the class' purpose and simply left things as they are
