I added a patch for CPIO to SANDBOX-294
Cheers
On Wed, Mar 18, 2009 at 11:22 AM, sebb wrote:
> On 18/03/2009, Stefan Bodewig wrote:
>> On 2009-03-18, Stefan Bodewig wrote:
>>
>> > I'd like to remove some fields, make them private or final and maybe
>> > move some methods around before our fir
On 18/03/2009, Stefan Bodewig wrote:
> On 2009-03-18, Stefan Bodewig wrote:
>
> > I'd like to remove some fields, make them private or final and maybe
> > move some methods around before our first release. In particular:
>
>
> I just saw sebb's patch attached to SANDBOX-294 and he seems to agr
Hi,
I think restrict visibility whereever possible would be a good idea
too. You can loosen later if one wants to.
I just checked out CPIO, AR and JAR. The latter two contain so less
code, everything looks good. But CPIO needs some work...
However, I guess you want to:
CpioArchiveInputStream
-
On 2009-03-18, Stefan Bodewig wrote:
> I'd like to remove some fields, make them private or final and maybe
> move some methods around before our first release. In particular:
I just saw sebb's patch attached to SANDBOX-294 and he seems to agree
with most of my points. In addition the patch ma
Hi,
some of the classes inherited from Ant contain protected fields that
are only there for backwards compatibility reasons.
For example ZipOutputStream in Ant used to extend
java.util.zip.DeflaterOutputStream in Ant 1.4 which exposes the
Deflater as a non-final protected field - when we changes
