Re: [compress] Preparing for 1.12

2016-06-10 Thread Stefan Bodewig
On 2016-06-10, Stefan Bodewig wrote: > We have it in two cases, ZipFile and BZip2CompressorOutputStream - > ZipFile uses a volatile flag rather than synchronization and > null-assignment, maybe that's the better option anyway. I've changed the code and findbugs is happy again, updated site build

Re: [compress] Preparing for 1.12

2016-06-10 Thread Stefan Bodewig
On 2016-06-10, Torsten Curdt wrote: >> You'll see that findbugs is unhappy about inconsistent synchronization >> introduced when I made the finish method of BZip2CompressorOutputStream >> synchronized due to COMPRESS-357 > My feedback: I'd rather recommend to get rid of the finalize over adding >

Re: [compress] Preparing for 1.12

2016-06-10 Thread Torsten Curdt
> > > You'll see that findbugs is unhappy about inconsistent synchronization > introduced when I made the finish method of BZip2CompressorOutputStream > synchronized due to COMPRESS-357 > > Yes, blockSorter is accessed unsynchronized in different places, but we > don't need to care as the class isn

[compress] Preparing for 1.12

2016-06-09 Thread Stefan Bodewig
Hi all we've got a nice set of fixes and new features added since 1.11 and I plan to cut the next release soonish. The only thing I want to do prior to the release is adding a few words of documentation about the IWA support in Snappy. Based on prior experience I'd like to give folks a chance to