Re: [compress] Patch for Compress-28

2009-03-26 Thread Christian Grobmeier
> The tests didn't pass for me on Windows because of line-end > differences (I guess), I've modified them to work for me and hopefully > work on a system with a single character EOL, but I don't have such a > system to confirm it right now. > > Could you please run the tests and close the issue aft

Re: [compress] Patch for Compress-28

2009-03-26 Thread Stefan Bodewig
On 2009-03-26, Christian Grobmeier wrote: > This should make sure that CPIO classes work like all the other classes. Thanks. I've moved the finish() call in close() inside the !closed branch since otherwise finish's ensureOpen would cause trouble for repeated calls to close (that the old code h

[compress] Patch for Compress-28

2009-03-25 Thread Christian Grobmeier
Hi, i just added a patch to: https://issues.apache.org/jira/browse/COMPRESS-28 This should make sure that CPIO classes work like all the other classes. Testcases are more better and now I feel more comfortable with this new stuff. Cheers, Christian --