Re: [compress] Checkstyle configuration

2009-03-25 Thread Christian Grobmeier
Hi > Christian, you could have a go at doing this yourself. I added you > specifically to the COMPRESS project in JIRA, so you should have the > privileges to do that. Let me know if it doesn't work for you, and I'll > have another look at it. it seems to work, thank you very much! Christian --

Re: [compress] Checkstyle configuration

2009-03-25 Thread Dennis Lundberg
Christian Grobmeier wrote: > Hi there, > >> if you want to delete I can do it - no need to jira every detail while >> we are all on AC09 > > well, not all :-) > Thanks, i didn't want to noise around. > If you could delete it I would be glad. > Can you please close this issue too? > https://issue

Re: [compress] Checkstyle configuration

2009-03-25 Thread Christian Grobmeier
Hi there, > if you want to delete I can do it - no need to jira every detail while > we are  all on AC09 well, not all :-) Thanks, i didn't want to noise around. If you could delete it I would be glad. Can you please close this issue too? https://issues.apache.org/jira/browse/COMPRESS-25 Cheers!

Re: [compress] Checkstyle configuration

2009-03-25 Thread Siegfried Goeschl
Hi Christian, if you want to delete I can do it - no need to jira every detail while we are all on AC09 Sitting next to Stefan Bodewig, Siegfried Goeschl Christian Grobmeier wrote: >> On 2009-03-24, Torsten Curdt wrote: >> >> >>> Personally I am not a big fan of checkstyle enforcement at

Re: [compress] Checkstyle configuration

2009-03-25 Thread Christian Grobmeier
> On 2009-03-24, Torsten Curdt wrote: > >> Personally I am not a big fan of checkstyle enforcement at all. > > I can perfectly well live without it as well. OK, I will add a patch to the cs issue whcih deletes the checkstyle.xml from the pom file (its currently commented out). Cheers + Thanks Ch

Re: [compress] Checkstyle configuration

2009-03-25 Thread Stefan Bodewig
On 2009-03-24, Torsten Curdt wrote: > Personally I am not a big fan of checkstyle enforcement at all. I can perfectly well live without it as well. Stefan - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additi

Re: [compress] Checkstyle configuration

2009-03-25 Thread Torsten Curdt
> I was remembering when I was jumping into compress first. I openend > the BZ2 classes and I felt so hopeless... the code was quite cryptic > to me and so different to that style I was used too. If we would have > clean and consistent codestyle, this may help some younger  devs to > jump into the

Re: [compress] Checkstyle configuration

2009-03-25 Thread Christian Grobmeier
>> Is that because of the checkstyle tool, or because of the rules that >> have been chosen? > > Not because of these rules. It's the approach. > > I've seen people wasting too much time on this. Builds breaking > because of wrong coding styles. Terrible! I thought checkstyle.xml is a commons conv

Re: [compress] Checkstyle configuration

2009-03-24 Thread Torsten Curdt
>> Personally I am not a big fan of checkstyle enforcement at all. > > Is that because of the checkstyle tool, or because of the rules that > have been chosen? Not because of these rules. It's the approach. I've seen people wasting too much time on this. Builds breaking because of wrong coding st

Re: [compress] Checkstyle configuration

2009-03-24 Thread Christian Grobmeier
>> I need to set the following properties, which seem to come out from >> commons-parent. I checked that out and searched, but couldn't find the >> setting of this properties. > > I think you're mistaken - AFAIK commons-parent doesn't have anything > configured for checkstyle. oh... thanks! OK I w

Re: [compress] Checkstyle configuration

2009-03-24 Thread Niall Pemberton
On Tue, Mar 24, 2009 at 7:00 AM, Christian Grobmeier wrote: > Hi all, > > I just try to figure out how to include a checkstyle.xml in compress. > I have stolen the configuration file > from [email] and put it in the root directory. For testing I enabled > it within eclipse and found out that > I n

Re: [compress] Checkstyle configuration

2009-03-24 Thread sebb
On 24/03/2009, Torsten Curdt wrote: > > Since codestyle is a very personal discussion (sometimes), I would > > like to give you a chance to discuss before I create the attachement. > > > Personally I am not a big fan of checkstyle enforcement at all. Is that because of the checkstyle tool, or be

Re: [compress] Checkstyle configuration

2009-03-24 Thread Torsten Curdt
> Since codestyle is a very personal discussion (sometimes), I would > like to give you a chance to discuss before I create the attachement. Personally I am not a big fan of checkstyle enforcement at all. cheers -- Torsten - To

Re: [compress] Checkstyle configuration

2009-03-24 Thread Christian Grobmeier
Hi again, sorry for the attachment, but this is my proposed Checkstyle config. Since codestyle is a very personal discussion (sometimes), I would like to give you a chance to discuss before I create the attachement. Additionally, i commented out the $properties in teh file till some maven guru ca

[compress] Checkstyle configuration

2009-03-24 Thread Christian Grobmeier
Hi all, I just try to figure out how to include a checkstyle.xml in compress. I have stolen the configuration file from [email] and put it in the root directory. For testing I enabled it within eclipse and found out that I need to set the following properties, which seem to come out from commons-p