Re: [commons-compress] traditional zip encryption patch to come

2016-02-20 Thread Stefan Bodewig
On 2016-02-16, Bear Giles wrote: > I can create test files. (I still need to create some PKWare test files as > well...). This would be good. > I also need to figure out a way to extract the encrypted content to I > can verify my implementation of the crypto logic itself. I think that > will jus

Re: [commons-compress] traditional zip encryption patch to come

2016-02-16 Thread Bear Giles
I can create test files. (I still need to create some PKWare test files as well...). I also need to figure out a way to extract the encrypted content to I can verify my implementation of the crypto logic itself. I think that will just require disabling any check for the 'encrypted' bit. ​Source at

Re: [commons-compress] traditional zip encryption patch to come

2016-02-16 Thread Stefan Bodewig
On 2016-02-15, Bear Giles wrote: > We discussed adding support for the traditional zip encryption algorithm a > while back. IIRC the concensus was loosely against it since it's so weak > and we don't want to mislead people. I'm pretty sure we should ad a big warning about the quality of encryptio

[commons-compress] traditional zip encryption patch to come

2016-02-14 Thread Bear Giles
We discussed adding support for the traditional zip encryption algorithm a while back. IIRC the concensus was loosely against it since it's so weak and we don't want to mislead people. Since then I can add two points. First, I heard from someone who said that she has to use the traditional encryp