Re: [collections] Issues with MultiMap generics and need of a MultiTrie

2014-03-02 Thread Dipanjan Laha
Hi Matt, Thanks for the info. I have a Jira issue created for this ( https://issues.apache.org/jira/browse/COLLECTIONS-508). I have attached the patch there. Thanks Dipanjan On Sun, Mar 2, 2014 at 10:21 PM, Matt Benson wrote: > Apache lists generally don't allow attachments. Please raise a JI

Re: [collections] Issues with MultiMap generics and need of a MultiTrie

2014-03-02 Thread Matt Benson
Apache lists generally don't allow attachments. Please raise a JIRA issue and attach there. Matt On Sun, Mar 2, 2014 at 10:46 AM, Dipanjan Laha wrote: > Hi Thomas, > > I have implemented the MultiValuedMap interface, the MultiValuedHashMap > and a MultiValuedHashMapTest as per the discussions.

Re: [collections] Issues with MultiMap generics and need of a MultiTrie

2014-03-02 Thread Dipanjan Laha
Hi Thomas, I have implemented the MultiValuedMap interface, the MultiValuedHashMap and a MultiValuedHashMapTest as per the discussions. I haven't completed the documentation yet. If the implementations look fine, I will add the remaining documentations. A few more points regarding the implementat

Re: [collections] Issues with MultiMap generics and need of a MultiTrie

2014-02-26 Thread Dipanjan Laha
Thanks for pointing this out. However, implementing Get & Put directly would pose the following problems. If interface MultiValuedMap extends Get> the method "values" would be forced to have a signature of Collection> values() whereas we would want Collection values(). This wont be possible a

Re: [collections] Issues with MultiMap generics and need of a MultiTrie

2014-02-26 Thread Matt Benson
Don't forget about the Get/Put/split map concepts from Collections 4. It would seem you could implement those interfaces and provide that amount of abstraction anyway. Matt On Feb 26, 2014 3:26 AM, "Dipanjan Laha" wrote: > Hi Thomas, > > This sounds great. Moving MultiKeyMap to the new package d

Re: [collections] Issues with MultiMap generics and need of a MultiTrie

2014-02-26 Thread Dipanjan Laha
Hi Thomas, This sounds great. Moving MultiKeyMap to the new package does sound like the way to go ahead. I will start with the implementation of the interface and the MultiValuedHashMap. I should be able to submit a patch with a basic implementation and some test cases by the end of this week. I c

Re: [collections] Issues with MultiMap generics and need of a MultiTrie

2014-02-26 Thread Thomas Neidhart
Hi Dipanjan, I was thinking about a name for the new interface, but I actually like your proposal of MultiValuedMap. For the package, I think we can stick with multimap, and at some point we could also move the MultiKeyMap there, which would be logical imho. The implementation names are also sou

Re: [collections] Issues with MultiMap generics and need of a MultiTrie

2014-02-26 Thread Dipanjan Laha
Hi Thomas, It would be great if we can start the discussion on the new interface for MultiMap and a new package for the implementations as suggested by you. Then I'll be able to put some code together for the same. IMO we can have 1. New Interface for MultiMap with the name MultiValuedMap or Mul

Re: [collections] Issues with MultiMap generics and need of a MultiTrie

2014-02-23 Thread Dipanjan Laha
Hi Thomas, Thanks for your feedback. I created an improvement request in Jira for the same (https://issues.apache.org/jira/browse/COLLECTIONS-508 ) as I thought it could be better tracked there. Sorry for the duplication in the mail list and Jira. I have also attached a patch in Jira where I have

Re: [collections] Issues with MultiMap generics and need of a MultiTrie

2014-02-23 Thread Thomas Neidhart
On 02/22/2014 02:00 PM, Dipanjan Laha wrote: > Hello, Hi Dipanjan, > Recently I had the need of using a MultiMap in one of my projects. I found > that commons collection already has a MultiMap interface and an > implementation. > > While using the same, I found that the MultiMap interface has m

[collections] Issues with MultiMap generics and need of a MultiTrie

2014-02-22 Thread Dipanjan Laha
Hello, Recently I had the need of using a MultiMap in one of my projects. I found that commons collection already has a MultiMap interface and an implementation. While using the same, I found that the MultiMap interface has methods that are not strongly typed even though the interface supports g