Re: [collections] BloomFilter package architecture discussion

2019-10-28 Thread Claude Warren
Based on the feedback and questions I have created a different implementation (https://github.com/Claudenw/BloomFilter/tree/Hasher) -- note this is the Hasher branch. This implementation uses an abstract BloomFilter to implement the basic functionality required and required that implementations im

Re: [collections] BloomFilter package architecture discussion

2019-10-20 Thread Gilles Sadowski
Hi Claude. Le dim. 20 oct. 2019 à 14:20, Claude Warren a écrit : > > A Bloom filter is a set of bits: It is not, according to the quote here: > "The hash area is considered as N individual addressable bits, with > addresses 0 through N - 1. It is assumed that all bits in the hash area are > fir

Re: [collections] BloomFilter package architecture discussion

2019-10-20 Thread Claude Warren
A Bloom filter is a set of bits: "The hash area is considered as N individual addressable bits, with addresses 0 through N - 1. It is assumed that all bits in the hash area are first set to 0. Next, each mes- sage in the set to be stored is hash coded into a number of distinct bit addresses, say a

Re: [collections] BloomFilter package architecture discussion

2019-10-19 Thread Claude Warren
As an experiment I attempted to implement a complete BloomFilter (see BloomFilterI2 in https://issues.apache.org/jira/browse/COLLECTIONS-728) using only IntStream and merge( BloomFilter ). It is possible, though probably not the fastest implementation. We could define something like: ByteBuffer

Re: [collections] BloomFilter package architecture discussion

2019-10-19 Thread Gilles Sadowski
Hello. 2019-10-19 16:20 UTC+02:00, Claude Warren : > On Fri, Oct 18, 2019 at 3:22 PM Gilles Sadowski > wrote: > >> Hi. >> >> >>> [...] >> > > >> > > Maybe I was not clear enough: I'm not saying that we should prefer >> > > some representation (of the state) over another; only that the how >> > >

Re: [collections] BloomFilter package architecture discussion

2019-10-19 Thread Claude Warren
On Fri, Oct 18, 2019 at 3:22 PM Gilles Sadowski wrote: > Hi. > > >>> [...] > > > > > > Maybe I was not clear enough: I'm not saying that we should prefer > > > some representation (of the state) over another; only that the how > > > the state is represented externally need not be the same as the

Re: [collections] BloomFilter package architecture discussion

2019-10-18 Thread Gilles Sadowski
Hi. >>> [...] > > > > Maybe I was not clear enough: I'm not saying that we should prefer > > some representation (of the state) over another; only that the how > > the state is represented externally need not be the same as the internal > > representation. > > > > But if the state is fully encapsu

Re: [collections] BloomFilter package architecture discussion

2019-10-17 Thread Claude Warren
On Wed, Oct 16, 2019 at 2:08 AM Gilles Sadowski wrote: > Hi. > > 2019-10-15 20:05 UTC+02:00, Claude Warren : > > On Tue, Oct 15, 2019 at 1:46 AM Gilles Sadowski > > wrote: > > > >> Hello. > >> > >> > >> > >> > Furthermore, > >> > the other potential users and supporters have not responded to any

Re: [collections] BloomFilter package architecture discussion

2019-10-17 Thread Claude Warren
I have added a list of Use Cases ( https://github.com/Claudenw/commons-collections/blob/master/src/main/java/org/apache/commons/collections4/bloomfilter/Usage.md) I expect that these will end up in documentation somewhere. On Wed, Oct 16, 2019 at 2:08 AM Gilles Sadowski wrote: > Hi. > > 2019-10-

Re: [collections] BloomFilter package architecture discussion

2019-10-15 Thread Gilles Sadowski
Hi. 2019-10-15 20:05 UTC+02:00, Claude Warren : > On Tue, Oct 15, 2019 at 1:46 AM Gilles Sadowski > wrote: > >> Hello. >> >> >> >> > Furthermore, >> > the other potential users and supporters have not responded to any >> > communication about this proposal so I am floundering on that front >> > t

Re: [collections] BloomFilter package architecture discussion

2019-10-15 Thread Claude Warren
On Tue, Oct 15, 2019 at 1:46 AM Gilles Sadowski wrote: > Hello. > > > > > Furthermore, > > the other potential users and supporters have not responded to any > > communication about this proposal so I am floundering on that front too. > > Who are they? > Developers I have worked with or know of

Re: [collections] BloomFilter package architecture discussion

2019-10-14 Thread Gilles Sadowski
Hello. Le lun. 14 oct. 2019 à 14:12, Claude Warren a écrit : > > Greetings, > > > I feel like I have been beating my head against a wall trying to get this > contribution accepted; In my experience, a "wall" would be a plain refusal (or no answer and nobody applying the patch). We are far from

Re: [collections] BloomFilter package architecture discussion

2019-10-14 Thread Gary Gregory
Just a quick note that, on my end, I might be able to get back to looking at this PR soon-ish but it might not be until the week-end. Gary On Mon, Oct 14, 2019 at 8:12 AM Claude Warren wrote: > Greetings, > > > I feel like I have been beating my head against a wall trying to get this > contribu

[collections] BloomFilter package architecture discussion

2019-10-14 Thread Claude Warren
Greetings, I feel like I have been beating my head against a wall trying to get this contribution accepted; this is not a complaint about process or personalities, just a statement of how I feel. I realize that I have made progress but I also realize that there is a long way to go. Furthermore, t