Re: [codec] org.apache.commons.codec.binary.BaseNCodec.strictDecoding

2020-05-17 Thread Gary Gregory
On Thu, May 14, 2020 at 3:51 PM Alex Herbert wrote: > > > > On 14 May 2020, at 18:03, Gary Gregory wrote: > > > > Hi All, > > > > The addition of org.apache.commons.codec.binary.BaseNCodec.strictDecoding > > is not quite right IMO, the ivar should be final with some new ctors. ALL > > other ivar

Re: [codec] org.apache.commons.codec.binary.BaseNCodec.strictDecoding

2020-05-14 Thread Alex Herbert
> On 14 May 2020, at 18:03, Gary Gregory wrote: > > Hi All, > > The addition of org.apache.commons.codec.binary.BaseNCodec.strictDecoding > is not quite right IMO, the ivar should be final with some new ctors. ALL > other ivars here are final and the class is documented as thread-safe. I'll >

[codec] org.apache.commons.codec.binary.BaseNCodec.strictDecoding

2020-05-14 Thread Gary Gregory
Hi All, The addition of org.apache.commons.codec.binary.BaseNCodec.strictDecoding is not quite right IMO, the ivar should be final with some new ctors. ALL other ivars here are final and the class is documented as thread-safe. I'll proceed unless someone makes a case for jumping through the extra