Re: [codec] Vacuous bit mask operation on integer value in UnixCrypt

2012-08-30 Thread Gary Gregory
Hi Christian, (pardon the brevity, on the phone) I do not have the privilege to grant access. There is a whole process for that. Yes, create JIRAs for patches. Don't know why git does that, sorry. Gary On Aug 29, 2012, at 20:00, Christian Hammers wrote: > Hello > > I did some more unit tests. C

Re: [codec] Vacuous bit mask operation on integer value in UnixCrypt

2012-08-29 Thread Christian Hammers
Hello I did some more unit tests. Could you grant me commit rights (Apache user "chammers") or should I fill your inbox with patches? :-) BTW, I would have made a git fork but the "$Id$" lines show up in every diff. Why are they not expanded in the git shadow repo? I thought that would happen at

Re: [codec] Vacuous bit mask operation on integer value in UnixCrypt

2012-08-29 Thread Gary Gregory
How about this: 1. Let's get the digest package to 100% code coverage (or as closed to it as possible) 2. Clean up the code (removing the "vacuous" code) Also to do is fix the remaining check styles. Patches welcome! Gary On Tue, Aug 28, 2012 at 2:47 AM, Thomas Neidhart wrote: > On 08/28/2012

Re: [codec] Vacuous bit mask operation on integer value in UnixCrypt

2012-08-27 Thread Thomas Neidhart
On 08/28/2012 03:33 AM, Christian Hammers wrote: > Am Tue, 28 Aug 2012 00:09:41 +0200 > schrieb Christian Hammers : > >> Hello >> >> Am Mon, 27 Aug 2012 16:39:23 -0400 >> schrieb Gary Gregory : >> >>> On Mon, Aug 27, 2012 at 2:53 PM, Thomas Neidhart >>> wrote: >>> On 08/27/2012 03:36 PM, Gary

Re: [codec] Vacuous bit mask operation on integer value in UnixCrypt

2012-08-27 Thread Christian Hammers
Am Tue, 28 Aug 2012 00:09:41 +0200 schrieb Christian Hammers : > Hello > > Am Mon, 27 Aug 2012 16:39:23 -0400 > schrieb Gary Gregory : > > > On Mon, Aug 27, 2012 at 2:53 PM, Thomas Neidhart > > wrote: > > > > > On 08/27/2012 03:36 PM, Gary Gregory wrote: > > > > Hi All: > > > > > > > > FindBugs

Re: [codec] Vacuous bit mask operation on integer value in UnixCrypt

2012-08-27 Thread Christian Hammers
Hello Am Mon, 27 Aug 2012 16:39:23 -0400 schrieb Gary Gregory : > On Mon, Aug 27, 2012 at 2:53 PM, Thomas Neidhart > wrote: > > > On 08/27/2012 03:36 PM, Gary Gregory wrote: > > > Hi All: > > > > > > FindBugs says the following a couple of times for UnixCrypt: > > > "Vacuous bit mask operation o

Re: [codec] Vacuous bit mask operation on integer value in UnixCrypt

2012-08-27 Thread Gary Gregory
On Mon, Aug 27, 2012 at 2:53 PM, Thomas Neidhart wrote: > On 08/27/2012 03:36 PM, Gary Gregory wrote: > > Hi All: > > > > FindBugs says the following a couple of times for UnixCrypt: > > "Vacuous bit mask operation on integer value (INT_VACUOUS_BIT_OPERATION) > > > > This is an integer bit operati

Re: [codec] Vacuous bit mask operation on integer value in UnixCrypt

2012-08-27 Thread Thomas Neidhart
On 08/27/2012 03:36 PM, Gary Gregory wrote: > Hi All: > > FindBugs says the following a couple of times for UnixCrypt: > "Vacuous bit mask operation on integer value (INT_VACUOUS_BIT_OPERATION) > > This is an integer bit operation (and, or, or exclusive or) that doesn't do > any useful work (e.g.