Re: [VOTE] Release of DbUtils 1.2 RC1

2009-03-10 Thread Dan Fabulich
sebb wrote: I think there are some problems with thread-safety. Yikes! I didn't investigate very carefully the thread-safety claims of these classes (again, not much has changed since 1.1) but I agree with your assessment, now that I open my eyes and think about it. In revision 752369 I i

Re: [VOTE] Release of DbUtils 1.2 RC1

2009-03-10 Thread sebb
I think there are some problems with thread-safety. QueryRunner Javadoc says the class is thread-safe. However it has a protected mutable variable DataSource which can also be set/got via public methods. If one thread sets the variable, another may not see the correct value, so the class is not th

Re: [VOTE] Release of DbUtils 1.2 RC1

2009-03-10 Thread Dan Fabulich
Jörg Schaible wrote: However, IBM JDK 6 fails here: --- Test set: org.apache.commons.dbutils.QueryRunnerTest --- Tests run: 8, Failures: 0, Err

Re: [VOTE] Release of DbUtils 1.2 RC1

2009-03-10 Thread Dan Fabulich
sebb wrote: -0.5 because the unit tests seem wrong. I've incorporated your feedback in revision 752322. For the record, all of those tests predate DbUtils 1.1; we haven't touched them in years. I think these test changes are pretty minor; not worth an additional RC. What do you think? -

Re: [VOTE] Release of DbUtils 1.2 RC1

2009-03-08 Thread sebb
On 08/03/2009, Dan Fabulich wrote: > > My first attempt at releasing a commons project; please be gentle. :-) > > Compatibility warning: This version is mostly a bugfix release, but to fix > DBUTILS-31 we had to upgrade the JVM dependency from JDK 1.3 to JDK 1.4. > Except for that, it is backwar

Re: [VOTE] Release of DbUtils 1.2 RC1

2009-03-08 Thread Jörg Schaible
Hi Dan, I've downloaded the src tar ball and tried to build the version with my compiler zoo. It runs fine with all Sun JDKs, IcedTea6, Blackdown 1.4.2, JRockit 1.4 and 1.5. As usual the build faisl for IBM JDK 1.4 and 1.5 because Maven fails itself on this versions. However, IBM JDK 6 fails here:

[VOTE] Release of DbUtils 1.2 RC1

2009-03-08 Thread Dan Fabulich
My first attempt at releasing a commons project; please be gentle. :-) Compatibility warning: This version is mostly a bugfix release, but to fix DBUTILS-31 we had to upgrade the JVM dependency from JDK 1.3 to JDK 1.4. Except for that, it is backwards compatible with DbUtils 1.1. PLEASE TEST