Re: [LOGGING] OSGi Meta data is the same for adapters and api jar Was: [VOTE] Release of Commons Logging 1.1.2 based on RC2

2013-03-18 Thread Benedikt Ritter
Hi Oliver, Many thanks for your feedback! I've requests feedback from the ML [1] but nobody responded (I forgot to ping that thread to get some more attention...). Please see my comments inline. 2013/3/18 Oliver Heger > Am 16.03.2013 19:43, schrieb Benedikt Ritter: > > Hi Oliver >> >> >> 2013/

Re: [VOTE] Release of Commons Logging 1.1.2 based on RC2

2013-03-18 Thread Benedikt Ritter
Build works fine with: Apache Maven 3.0.3 (r1075438; 2011-02-28 18:31:09+0100) Maven home: D:\Entwicklung\maven\3.0.3 Java version: 1.7.0_13, vendor: Oracle Corporation Java home: D:\Entwicklung\Java\jdk1.7.0_13-x64\jre Default locale: de_DE, platform encoding: Cp1252 OS name: "windows 7", version

Re: [VOTE] Release of Commons Logging 1.1.2 based on RC2

2013-03-18 Thread Oliver Heger
As I understand it, this release does not change anything regarding OSGi compatibility of [logging], and therefore OSGi meta data does not seem to be a problem. So +1. Oliver Am 16.03.2013 19:14, schrieb Oliver Heger: Build works fine on Windows 7 with Java 1.5 and 1.7, artifacts and site lo

Re: [LOGGING] OSGi Meta data is the same for adapters and api jar Was: [VOTE] Release of Commons Logging 1.1.2 based on RC2

2013-03-18 Thread Oliver Heger
Am 16.03.2013 19:43, schrieb Benedikt Ritter: Hi Oliver 2013/3/16 Oliver Heger Build works fine on Windows 7 with Java 1.5 and 1.7, artifacts and site look good. One thing I noticed, not sure whether this is actually a problem: The artifacts for adapters and api have the same manifest infor

Re: [VOTE] Release of Commons Logging 1.1.2 based on RC2

2013-03-16 Thread Jörg Schaible
+1 Thomas Neidhart wrote: > Hi, > > I'd like to call a vote for releasing Commons Logging 1.1.2 based on RC2. > > This release candidate has the following changes compared to RC1: > > * Fix deployment process to include also missing bin/src assemblies > * Disable reference release test for W

[LOGGING] OSGi Meta data is the same for adapters and api jar Was: [VOTE] Release of Commons Logging 1.1.2 based on RC2

2013-03-16 Thread Benedikt Ritter
Hi Oliver 2013/3/16 Oliver Heger > Build works fine on Windows 7 with Java 1.5 and 1.7, artifacts and site > look good. > > One thing I noticed, not sure whether this is actually a problem: The > artifacts for adapters and api have the same manifest information as the > main jar. Are they inten

Re: [VOTE] Release of Commons Logging 1.1.2 based on RC2

2013-03-16 Thread Oliver Heger
Build works fine on Windows 7 with Java 1.5 and 1.7, artifacts and site look good. One thing I noticed, not sure whether this is actually a problem: The artifacts for adapters and api have the same manifest information as the main jar. Are they intended to be used in an OSGi environment? Could

Re: [VOTE] Release of Commons Logging 1.1.2 based on RC2

2013-03-16 Thread Gary Gregory
On Mar 16, 2013, at 12:45, Thomas Neidhart wrote: > On 03/16/2013 03:21 PM, Gary Gregory wrote: >> Not a blocker but not pretty: >> >> The variable testObjCls may be null at line 199 in LoadTestCase.java >> (/commons-logging/src/test/java/org/apache/commons/logging) >> >> And... wow is that code

Re: [VOTE] Release of Commons Logging 1.1.2 based on RC2

2013-03-16 Thread Thomas Neidhart
On 03/16/2013 03:21 PM, Gary Gregory wrote: > Not a blocker but not pretty: > > The variable testObjCls may be null at line 199 in LoadTestCase.java > (/commons-logging/src/test/java/org/apache/commons/logging) > > And... wow is that code some weird format! no question about that ;-), but I don'

Re: [VOTE] Release of Commons Logging 1.1.2 based on RC2

2013-03-16 Thread Gary Gregory
Not a blocker but not pretty: The variable testObjCls may be null at line 199 in LoadTestCase.java (/commons-logging/src/test/java/org/apache/commons/logging) And... wow is that code some weird format! Gary On Sat, Mar 16, 2013 at 10:14 AM, Gary Gregory wrote: > +1 > > looks good on: > > Apa

Re: [VOTE] Release of Commons Logging 1.1.2 based on RC2

2013-03-16 Thread Gary Gregory
+1 looks good on: Apache Maven 3.0.5 (r01de14724cdef164cd33c7c8c2fe155faf9602da; 2013-02-19 08:51:28-0500) Maven home: C:\Java\apache-maven-3.0.5\bin\.. Java version: 1.6.0_39, vendor: Sun Microsystems Inc. Java home: C:\Program Files\Java\jdk1.6.0_39\jre Default locale: en_US, platform encoding:

[VOTE] Release of Commons Logging 1.1.2 based on RC2

2013-03-16 Thread Thomas Neidhart
Hi, I'd like to call a vote for releasing Commons Logging 1.1.2 based on RC2. This release candidate has the following changes compared to RC1: * Fix deployment process to include also missing bin/src assemblies * Disable reference release test for WeakHashtable as it was unreliable on vari