Re: [CANCEL][VOTE] Release of Commons Email 1.3.1 based on RC1

2013-02-23 Thread Jörg Schaible
Benedikt Ritter wrote: > Hallo Thomas, > > o.a.c.email.util.MimeMessageUtils has very low test coverage. This may not > be a blocker, but we should provide some more coverage for that class. In general, yes, but this is a bug fix release. Cheers, Jörg -

Re: [CANCEL][VOTE] Release of Commons Email 1.3.1 based on RC1

2013-02-23 Thread Benedikt Ritter
Hallo Thomas, o.a.c.email.util.MimeMessageUtils has very low test coverage. This may not be a blocker, but we should provide some more coverage for that class. Regards, Benedikt 2013/2/23 Thomas Neidhart > On 02/22/2013 01:11 PM, Thomas Neidhart wrote: > > Hi, > > > > I'd like to call a vote

[CANCEL][VOTE] Release of Commons Email 1.3.1 based on RC1

2013-02-23 Thread Thomas Neidhart
On 02/22/2013 01:11 PM, Thomas Neidhart wrote: > Hi, > > I'd like to call a vote for releasing Commons Email 1.3.1 based on RC1. > > This release candidate has the following changes compared to 1.3: > > == Fixed Bugs == > > * DataSourceClassPathResolver will now correctly set the DataSource >

Re: [VOTE] Release of Commons Email 1.3.1 based on RC1

2013-02-22 Thread Thomas Neidhart
On 02/22/2013 02:00 PM, Gary Gregory wrote: > Shouldn't the Clirr report compare to 1.3 instead of 1.2? Good question, for a point release I would think it makes sense to compare to the same version as for the release it aims to fix. But if usually the last released version is used, then we shoul

Re: [VOTE] Release of Commons Email 1.3.1 based on RC1

2013-02-22 Thread Gary Gregory
Shouldn't the Clirr report compare to 1.3 instead of 1.2? Gary On Fri, Feb 22, 2013 at 7:11 AM, Thomas Neidhart wrote: > Hi, > > I'd like to call a vote for releasing Commons Email 1.3.1 based on RC1. > > This release candidate has the following changes compared to 1.3: > > == Fixed Bugs == > >

[VOTE] Release of Commons Email 1.3.1 based on RC1

2013-02-22 Thread Thomas Neidhart
Hi, I'd like to call a vote for releasing Commons Email 1.3.1 based on RC1. This release candidate has the following changes compared to 1.3: == Fixed Bugs == * DataSourceClassPathResolver will now correctly set the DataSource name for resolved resources. Additionally, it is now possible to s