Benedikt Ritter wrote:
> Actually I wanted to vte but will nt have the time until friday. So I've
> no problem with another RC :-)
Same for me ... however, I really appreciate all the work you did for
collections-4, Thomas!
Cheers,
Jörg
Actually I wanted to vte but will nt have the time until friday. So I've no
problem with another RC :-)
2013/11/20 Gary Gregory
> On Wed, Nov 20, 2013 at 3:22 PM, Thomas Neidhart
> wrote:
>
> > On 11/17/2013 08:22 PM, Thomas Neidhart wrote:
> > > Hi,
> > >
> > > I'd like to call a vote for relea
On Wed, Nov 20, 2013 at 3:22 PM, Thomas Neidhart
wrote:
> On 11/17/2013 08:22 PM, Thomas Neidhart wrote:
> > Hi,
> >
> > I'd like to call a vote for releasing Commons Collections 4.0 based on
> > RC4 and I am quite confident with this RC after all the valuable
> > feedback from the previous RCs ha
On 11/17/2013 08:22 PM, Thomas Neidhart wrote:
> Hi,
>
> I'd like to call a vote for releasing Commons Collections 4.0 based on
> RC4 and I am quite confident with this RC after all the valuable
> feedback from the previous RCs has been integrated.
>
> Changes since RC3:
>
> * [COLLECTIONS-50
Hi Gary,
thanks for your review and all the changes.
Would you mind updating the checkstyle configuration with your local
settings if possible, so that everybody working on the project has the same
baseline for warnings/errors.
I mainly focus on these warnings (enabled checkstyle plugin) together
+1
Note that I've made a lot of polish commits over the last three days after
reviewing various reports and IDE warnings; these would be nice to have in
a major release like 4.0 but they are not blockers.
Tested with:
Apache Maven 3.1.1 (0728685237757ffbf44136acec0402957f723d9a; 2013-09-17
11:22
+1 for the release
Thanks for your patience
Stefan
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
Hi Emmanuel,
thanks for your review and the tests that you added!
For the FalsePredicate: this must have slipped through, in fact I would
even consider to remove the instance objects, but as you suggest this can
be easily fixed in the next point release.
Users should be anyway using the factory m
Also, I'm +1 for the release if this can be fixed later without breaking
the compatibility.
Emmanuel Bourg
Le 20/11/2013 10:45, Emmanuel Bourg a écrit :
> After an ultimate round of code review I have another observation
> regarding the functor API.
>
> In FalsePredicate the INSTANCE singleton
After an ultimate round of code review I have another observation
regarding the functor API.
In FalsePredicate the INSTANCE singleton is defined as
Predicate. In other predicates such as TruePredicate it's
defined as Predicate. In both cases this prevents the declaration of:
Predicate predicat
Still new to the project, so forgive me if I'm not supposed to vote here:
+1 - everything looks good to me.
Can't wait to get my hands on the genericized functors at work - will make
life so much easier!
On Tue, Nov 19, 2013 at 6:01 AM, Luc Maisonobe wrote:
> Le 17/11/2013 20:22, Thomas Neidh
Le 17/11/2013 20:22, Thomas Neidhart a écrit :
> Hi,
>
> I'd like to call a vote for releasing Commons Collections 4.0 based on
> RC4 and I am quite confident with this RC after all the valuable
> feedback from the previous RCs has been integrated.
>
> Changes since RC3:
>
> * [COLLECTIONS-50
Build works fine with Java 1.5 and 1.7 on Windows 8. Artifacts and site
look good.
+1
Great work, Thomas!
Oliver
Am 17.11.2013 20:22, schrieb Thomas Neidhart:
> Hi,
>
> I'd like to call a vote for releasing Commons Collections 4.0 based on
> RC4 and I am quite confident with this RC after all t
Hi,
I'd like to call a vote for releasing Commons Collections 4.0 based on
RC4 and I am quite confident with this RC after all the valuable
feedback from the previous RCs has been integrated.
Changes since RC3:
* [COLLECTIONS-501] Renamed methods "V MultiKeyMap#remove(Object,
Object, ...)
14 matches
Mail list logo
