[CANCEL][VOTE] Release of Commons Collections 4.0 based on RC2

2013-11-10 Thread Thomas Neidhart
On 11/08/2013 10:59 AM, Thomas Neidhart wrote: > Hi, > > I'd like to call a vote for releasing Commons Collections 4.0 based on RC2. > > Changes since RC1: > > * release notes are now also included in the binary distribution > * removed spurious hashCode() method in AbstractPatriciaTrie, th

Re: [VOTE] Release of Commons Collections 4.0 based on RC2

2013-11-08 Thread Emmanuel Bourg
Le 08/11/2013 16:45, Thomas Neidhart a écrit : > thanks for your review, although I had hoped for something like this > after the 4.0-alpha release. Nevertheless, see my comments inline: Sorry for this late review, I intended to do it for the alpha release but did get the time. > The release no

Re: [VOTE] Release of Commons Collections 4.0 based on RC2

2013-11-08 Thread Thomas Neidhart
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/08/2013 02:49 PM, Emmanuel Bourg wrote: > I reviewed the site, the Javadoc and the test coverage. Here are > my comments: Hi Emmanuel, thanks for your review, although I had hoped for something like this after the 4.0-alpha release. Nevertheles

Re: [VOTE] Release of Commons Collections 4.0 based on RC2

2013-11-08 Thread Emmanuel Bourg
I reviewed the site, the Javadoc and the test coverage. Here are my comments: * The release notes [1] states: "This release is not source or binary compatible with v3.x." I think this might be somewhat confusing, as one could believe the version 4 conflicts with the version 3.x when they can act

[VOTE] Release of Commons Collections 4.0 based on RC2

2013-11-08 Thread Thomas Neidhart
Hi, I'd like to call a vote for releasing Commons Collections 4.0 based on RC2. Changes since RC1: * release notes are now also included in the binary distribution * removed spurious hashCode() method in AbstractPatriciaTrie, the inherited one from AbstractMap will be used instead C