Thanks a lot for a thorough review ! This vote is cancelled for an
immedieate respin.
Kristian
2015-12-26 18:34 GMT+01:00 Phil Steitz :
> Sigs and hashes are good.
>
> Release contents are good.
>
> Ant and maven builds both tested on 1.7, 1.8.
>
> Coburta disease has been cured - tests run cle
Sigs and hashes are good.
Release contents are good.
Ant and maven builds both tested on 1.7, 1.8.
Coburta disease has been cured - tests run cleanly against the
release jar.
Unfortunately, the NOTICE file still has not had the copyright date
updated.
I think that is a blocker, so -1 from me.
+1
ASC, MD5, and SHA1 OK.
Reports OK.
The links in
https://people.apache.org/~krosenvold/commons-io-2.5-RC2/checkstyle.html
are broken:
-
file:///E:/temp/rc/commons-io-2.5-src/commons-io-2.5-src/target/site/xref/src/main/java/org/apache/commons/io/output/WriterOutputStream.html#L313
-
file://
Using all my klutzy 10 thumbs I re-added the checksums in r11735, which
should fix the problem and allow the vote to proceed.
Kristian
2015-12-24 4:19 GMT+01:00 Gary Gregory :
> -1
>
> MD5 and SHA1 sums do not match:
>
> $ md5sum commons-io-2.5-src.zip
> 75f886de5526b3cc517eaa7b383e57d6 *common
-1
MD5 and SHA1 sums do not match:
$ md5sum commons-io-2.5-src.zip
75f886de5526b3cc517eaa7b383e57d6 *commons-io-2.5-src.zip
$ cat commons-io-2.5-src.zip.md5
e5844f9b3eaab2f2625da21b9f2e994e
$ sha1sum commons-io-2.5-src.zip
585b0cfe1a6194d40ef70c0ec0b6925bca1856d7 *commons-io-2.5-src.zip
$ cat
We have fixed quite a few bugs and added some significant
enhancements since commons-io was released,
so I would like to release commons-io 2.5
commons-io 2.5 RC2 is available for review here:
https://dist.apache.org/repos/dist/dev/commons/io/ (svn revision 11732)
Maven artifacts are here:
