[RESULT] [VOTE] Release commons-io 2.5 based on RC4

2016-04-21 Thread Benson Margulies
This vote passes, with +1 votes from Gary Gregory Oliver Heger Emmanuel Bourg and no other votes that I observed. On Thu, Apr 21, 2016 at 5:38 PM, Emmanuel Bourg wrote: > Le 14/04/2016 17:41, Benson Margulies a écrit : > >> [X] +1 Release these artifacts > > Tested on Debian with OpenJDK 8.

Re: [VOTE] Release commons-io 2.5 based on RC4

2016-04-21 Thread Emmanuel Bourg
Le 14/04/2016 17:41, Benson Margulies a écrit : > [X] +1 Release these artifacts Tested on Debian with OpenJDK 8. The API changes look ok. Emmanuel Bourg signature.asc Description: OpenPGP digital signature

Re: [VOTE] Release commons-io 2.5 based on RC4

2016-04-21 Thread Jörg Schaible
What happened with this vote now? Benson Margulies wrote: > Commons-io 2.5 is offered for a release vote. [snip] > Please review the release candidate and vote. > This vote will close no sooner that 72 hours from now, i.e. after > 0400 GMT 31-March 2010 No chance to vote before this da

Re: [VOTE] Release commons-io 2.5 based on RC4

2016-04-16 Thread Oliver Heger
Build works fine with Java 1.6 on Windows 10. Artifacts and site look good. +1 Oliver Am 14.04.2016 um 17:41 schrieb Benson Margulies: > Commons-io 2.5 is offered for a release vote. > > Commons-io 2.5 RC4 materials are available for review here: > https://dist.apache.org/repos/dist/dev/com

Re: [VOTE] Release commons-io 2.5 based on RC4

2016-04-15 Thread Benson Margulies
I've now corrected the binaries. On Thu, Apr 14, 2016 at 9:19 PM, sebb wrote: > On 14 April 2016 at 16:41, Benson Margulies wrote: >> Commons-io 2.5 is offered for a release vote. >> >> Commons-io 2.5 RC4 materials are available for review here: >> https://dist.apache.org/repos/dist/dev/com

Re: [VOTE] Release commons-io 2.5 based on RC4

2016-04-15 Thread Benson Margulies
I missed the binaries. I will upload them. On Apr 15, 2016 3:33 PM, "Oliver Heger" wrote: > Hi Benson, > > when checking the RC I get a pretty strange effect on downloading the > binaries from https://dist.apache.org/repos/dist/dev/commons/io/binaries/: > > The browser shows me "dist - Revision 1

Re: [VOTE] Release commons-io 2.5 based on RC4

2016-04-15 Thread Oliver Heger
Hi Benson, when checking the RC I get a pretty strange effect on downloading the binaries from https://dist.apache.org/repos/dist/dev/commons/io/binaries/: The browser shows me "dist - Revision 13260: /dev/commons/io/binaries". However, the downloaded artifacts are obviously the ones from the pre

Re: [VOTE] Release commons-io 2.5 based on RC4

2016-04-14 Thread sebb
On 14 April 2016 at 16:41, Benson Margulies wrote: > Commons-io 2.5 is offered for a release vote. > > Commons-io 2.5 RC4 materials are available for review here: > https://dist.apache.org/repos/dist/dev/commons/io/ (svn revision 13247) > > Maven artifacts are here: > > https://reposito

Re: [VOTE] Release commons-io 2.5 based on RC4

2016-04-14 Thread sebb
The CONTRIBUTING.md and README.md files are present in the tag, but are missing from the source archive. Since they are intended mainly for GitHub - and they are generated - that's not a blocker. But it might make checking future releases easier if the files were included. On 14 April 2016 at 22

Re: [VOTE] Release commons-io 2.5 based on RC4

2016-04-14 Thread sebb
On 14 April 2016 at 16:41, Benson Margulies wrote: > Commons-io 2.5 is offered for a release vote. > > Commons-io 2.5 RC4 materials are available for review here: > https://dist.apache.org/repos/dist/dev/commons/io/ (svn revision 13247) > > Maven artifacts are here: > > https://reposito

Re: [VOTE] Release commons-io 2.5 based on RC4

2016-04-14 Thread Gary Gregory
+1 MD5, SHA1, ASC OK. The site does not build on Java 7 and 8 due to a known issue with Maven 3.3.9 and maven-site-plugin and SLF4J (everybody should switch to Log4j 2 IMO). Tested OK with: 'mvn clean site' on Maven 3.0.5 and: Apache Maven 3.0.5 (r01de14724cdef164cd33c7c8c2fe155faf9602da; 2013-

Re: [VOTE] Release commons-io 2.5 based on RC4

2016-04-14 Thread Gary Gregory
Yep, Clirr report looks good. Thank you for addressing this so quickly! :-) Gary On Thu, Apr 14, 2016 at 12:05 PM, Benson Margulies wrote: > I've put up repaired doc. > > > On Thu, Apr 14, 2016 at 2:17 PM, Benson Margulies > wrote: > > I think I know what happened to CLIRR. > > > > I'll push n

Re: [VOTE] Release commons-io 2.5 based on RC4

2016-04-14 Thread Benson Margulies
I've put up repaired doc. On Thu, Apr 14, 2016 at 2:17 PM, Benson Margulies wrote: > I think I know what happened to CLIRR. > > I'll push new staged doc soon. > > > On Thu, Apr 14, 2016 at 12:44 PM, Gary Gregory wrote: >> On Thu, Apr 14, 2016 at 9:23 AM, Benson Margulies >> wrote: >> >>> On Th

Re: [VOTE] Release commons-io 2.5 based on RC4

2016-04-14 Thread Benson Margulies
I think I know what happened to CLIRR. I'll push new staged doc soon. On Thu, Apr 14, 2016 at 12:44 PM, Gary Gregory wrote: > On Thu, Apr 14, 2016 at 9:23 AM, Benson Margulies > wrote: > >> On Thu, Apr 14, 2016 at 12:04 PM, Gary Gregory >> wrote: >> > Hm, we might also have Checkstyle misconf

Re: [VOTE] Release commons-io 2.5 based on RC4

2016-04-14 Thread Gary Gregory
On Thu, Apr 14, 2016 at 9:23 AM, Benson Margulies wrote: > On Thu, Apr 14, 2016 at 12:04 PM, Gary Gregory > wrote: > > Hm, we might also have Checkstyle misconfigured since it complains > > about "Missing > > a Javadoc comment." on a private method. That seems a bit much IMO. > > presumably that

Re: [VOTE] Release commons-io 2.5 based on RC4

2016-04-14 Thread Benson Margulies
On Thu, Apr 14, 2016 at 12:04 PM, Gary Gregory wrote: > Hm, we might also have Checkstyle misconfigured since it complains > about "Missing > a Javadoc comment." on a private method. That seems a bit much IMO. presumably that's not something new that need to be fixed for 2.5. > > Gary > > On Th

Re: [VOTE] Release commons-io 2.5 based on RC4

2016-04-14 Thread Benson Margulies
1. I copied the entire site, using the mirror -R command of lftp. I guess I'll try harder after we sort out CLIRR. 2. Can you tell me how to fix the clirr report? I don't see any CLIRR config in the pom that seems relevant to the problem at hand. The clirr config in the parent pom does not consume

Re: [VOTE] Release commons-io 2.5 based on RC4

2016-04-14 Thread Gary Gregory
Hm, we might also have Checkstyle misconfigured since it complains about "Missing a Javadoc comment." on a private method. That seems a bit much IMO. Gary On Thu, Apr 14, 2016 at 8:41 AM, Benson Margulies wrote: > Commons-io 2.5 is offered for a release vote. > > Commons-io 2.5 RC4 materials ar

Re: [VOTE] Release commons-io 2.5 based on RC4

2016-04-14 Thread Gary Gregory
Did you did not copy the whole site? Checkstyle links are broken. For example on page http://people.apache.org/~bimargulies/commons-io-2.5-RC4/checkstyle.html the link to line 313 is broken: http://people.apache.org/~bimargulies/commons-io-2.5-RC4/xref/src/main/java/org/apache/commons/io/output/Wr

Re: [VOTE] Release commons-io 2.5 based on RC4

2016-04-14 Thread Gary Gregory
The Clirr report is wrong, it should compare to 2.4. One cannot assess if we broke BC from this report. Gary On Thu, Apr 14, 2016 at 8:41 AM, Benson Margulies wrote: > Commons-io 2.5 is offered for a release vote. > > Commons-io 2.5 RC4 materials are available for review here: > https://dis

[VOTE] Release commons-io 2.5 based on RC4

2016-04-14 Thread Benson Margulies
Commons-io 2.5 is offered for a release vote. Commons-io 2.5 RC4 materials are available for review here: https://dist.apache.org/repos/dist/dev/commons/io/ (svn revision 13247) Maven artifacts are here: https://repository.apache.org/content/repositories/orgapachecommons-1174/org/apach

Re: [VOTE] Release commons-io 2.5 based on RC4

2016-04-12 Thread Benson Margulies
I built this wrong. Please consider this vote [CANCELLED]; I'll try again and post another vote. I misunderstood the web page the first time about how you deal with RC status and the maven-release-plugin. On Tue, Apr 12, 2016 at 9:12 AM, Benson Margulies wrote: > I'm working on moving the stuff

Re: [VOTE] Release commons-io 2.5 based on RC4

2016-04-12 Thread Benson Margulies
I'm working on moving the stuff to dist. I'm working on 'home'. On Tue, Apr 12, 2016 at 8:16 AM, sebb wrote: > On 12 April 2016 at 12:42, Benson Margulies wrote: >> We have fixed quite a few bugs and added some significant enhancements >> since Commons IO 2.4 was released, >> so I would lik

Re: [VOTE] Release commons-io 2.5 based on RC4

2016-04-12 Thread sebb
On 12 April 2016 at 12:42, Benson Margulies wrote: > We have fixed quite a few bugs and added some significant enhancements > since Commons IO 2.4 was released, > so I would like to release Commons IO 2.5. > > NOTE: because this is just an RC, and because I'm not a PMC member, > I'm pointing to

Re: [VOTE] Release commons-io 2.5 based on RC4

2016-04-12 Thread sebb
On 12 April 2016 at 12:47, Mark Thomas wrote: > On 12/04/2016 12:42, Benson Margulies wrote: >> We have fixed quite a few bugs and added some significant enhancements >> since Commons IO 2.4 was released, >> so I would like to release Commons IO 2.5. >> >> NOTE: because this is just an RC, and b

Re: [VOTE] Release commons-io 2.5 based on RC4

2016-04-12 Thread Mark Thomas
On 12/04/2016 12:42, Benson Margulies wrote: > We have fixed quite a few bugs and added some significant enhancements > since Commons IO 2.4 was released, > so I would like to release Commons IO 2.5. > > NOTE: because this is just an RC, and because I'm not a PMC member, > I'm pointing to the re

[VOTE] Release commons-io 2.5 based on RC4

2016-04-12 Thread Benson Margulies
We have fixed quite a few bugs and added some significant enhancements since Commons IO 2.4 was released, so I would like to release Commons IO 2.5. NOTE: because this is just an RC, and because I'm not a PMC member, I'm pointing to the release on Nexus rather than copying it to dist. If this is