Re: [VOTE] Release JEXL 2.1 based on RC3

2011-12-11 Thread sebb
On 8 December 2011 19:44, sebb wrote: > Further to the earlier cancelled RC1 vote, here is an updated release > candidate. > > The main change since RC1 is that all binary incompatibilities have > been resolved. > > Clirr still reports errors for interfaces that have additional > methods, but the

Re: [VOTE] Release JEXL 2.1 based on RC3

2011-12-11 Thread henrib
On checkstyle, 3 of them are empty statements that are known - been there for long - and the other are Javadoc on deprecated methods introduced to ensure binary compatibility. On PMD, I've never tried to configure it correctly; there was already a lot of clutter in 1.1... A lot of the issues come

Re: [VOTE] Release JEXL 2.1 based on RC3

2011-12-11 Thread Simone Tripodi
+1 I'm not worried about source compatibility issues, I join Gary on checkstyle/PMD observations Simo http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ On Sun, Dec 11, 2011 at 5:32 PM, Gary Gregory wrote: >

Re: [VOTE] Release JEXL 2.1 based on RC3

2011-12-11 Thread Gary Gregory
+1 Note: There is an alarming number of PMD issues reported. A lot of these look like they are in generated code, but not all. Has this been mentioned? Non-blockers: - Some Javadoc checkstyle errors. - Findbugs oddities. Tested m3 'clean site' with: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:

Re: [VOTE] Release JEXL 2.1 based on RC3

2011-12-11 Thread Christian Grobmeier
+1 looks good to me have checked sigs, opened the stuff, looked at license, notice etc. API docs do contain not all of the copyright statements as on the website (as discussed in the digester vote). Cheers, Christian On Thu, Dec 8, 2011 at 8:44 PM, sebb wrote: > Further to the earlier cancelled

Re: [VOTE] Release JEXL 2.1 based on RC3

2011-12-11 Thread sebb
On 11 December 2011 12:42, Christian Grobmeier wrote: > Just curious - jexl is releasing tests? Why that? > commons-jexl-2.1-tests.jar It was decided a while ago to add these to make it easier to check binary compatibility between versions. Simpler to create the test jars at the same time, rathe

Re: [VOTE] Release JEXL 2.1 based on RC3

2011-12-11 Thread Christian Grobmeier
Just curious - jexl is releasing tests? Why that? commons-jexl-2.1-tests.jar https://repository.apache.org/content/repositories/orgapachecommons-298/org/apache/commons/commons-jexl/2.1/ On Thu, Dec 8, 2011 at 8:44 PM, sebb wrote: > Further to the earlier cancelled RC1 vote, here is an updated

Re: [VOTE] Release JEXL 2.1 based on RC3

2011-12-11 Thread sebb
On 11 December 2011 10:04, henrib wrote: > +1 > > The tag is actually > https://svn.apache.org/repos/asf/commons/proper/jexl/tags/COMMONS_JEXL_2_1-RC3/ Oops, sorry. . > There is one minor error in the Javadoc (interpreter visit FloatLiteral / > IntegerLiteral) but since these are deprecated, it

Re: [VOTE] Release JEXL 2.1 based on RC3

2011-12-11 Thread henrib
+1 The tag is actually https://svn.apache.org/repos/asf/commons/proper/jexl/tags/COMMONS_JEXL_2_1-RC3/ . There is one minor error in the Javadoc (interpreter visit FloatLiteral / IntegerLiteral) but since these are deprecated, it has no importance. Otherwise, everything looks good to me. Thanks S

[VOTE] Release JEXL 2.1 based on RC3

2011-12-08 Thread sebb
Further to the earlier cancelled RC1 vote, here is an updated release candidate. The main change since RC1 is that all binary incompatibilities have been resolved. Clirr still reports errors for interfaces that have additional methods, but these are false positives, as the changes only affect sou