[RESULT] [VOTE] Release DBCP 2.0.1 based on RC3

2014-05-21 Thread Phil Steitz
This vote has passed with binding +1 votes from Phil Steitz, Thomas Neidhart, Luc Maisonobe, Oliver Heger and Gary Gregory, a +0 vote from Bernd Eckenfels and no other votes. Phil On 5/18/14, 2:22 PM, Phil Steitz wrote: > The problem with line endings in RC2 has been fixed. > > DBCP 2.0.1 RC3 is

Re: [VOTE] Release DBCP 2.0.1 based on RC3

2014-05-19 Thread Gary Gregory
- The JIRA report does not list the bugs fixed by this release. - The changes report has a release date of TBD, this should be the date the RC is cut. If that is the real release, then there is nothing to change. - 25 errors and 100 warnings for Javadocs under Java 8. - 'mvn site' builds OK with:

Re: [VOTE] Release DBCP 2.0.1 based on RC3

2014-05-19 Thread Oliver Heger
Maven build works fine with Java 1.7 on Windows 8.1. Artifacts and site look good. I found a minor discrepancy between the maven and the ant build: The dependency to geronimo-jta_1.1_spec in maven has version 1.1.1 while the sample properties file of the ant build references version 1.1 - therefor

Re: [VOTE] Release DBCP 2.0.1 based on RC3

2014-05-19 Thread Thomas Neidhart
On 05/18/2014 11:22 PM, Phil Steitz wrote: > The problem with line endings in RC2 has been fixed. > > DBCP 2.0.1 RC3 is available for review here: > https://dist.apache.org/repos/dist/dev/commons/dbcp (r5379) > > Maven artifacts are here: > https://repository.apache.org/content/repositories/o

Re: [VOTE] Release DBCP 2.0.1 based on RC3

2014-05-19 Thread Luc Maisonobe
Le 18/05/2014 23:22, Phil Steitz a écrit : > The problem with line endings in RC2 has been fixed. > > DBCP 2.0.1 RC3 is available for review here: > https://dist.apache.org/repos/dist/dev/commons/dbcp (r5379) > > Maven artifacts are here: > https://repository.apache.org/content/repositories/o

Re: [VOTE] Release DBCP 2.0.1 based on RC3

2014-05-18 Thread Phil Steitz
Here is my +1 Phil On 5/18/14, 2:22 PM, Phil Steitz wrote: > The problem with line endings in RC2 has been fixed. > > DBCP 2.0.1 RC3 is available for review here: > https://dist.apache.org/repos/dist/dev/commons/dbcp (r5379) > > Maven artifacts are here: > https://repository.apache.org/conten

Re: [VOTE] Release DBCP 2.0.1 based on RC3

2014-05-18 Thread Phil Steitz
On 5/18/14, 5:08 PM, Bernd Eckenfels wrote: Thanks for the review. > +0 > > 'mvn verify' works with mvn3.2.1 jdk8 on win7 > 'mvn site' works with mvn3.2.1 jdk7 on win7 > > Why I do not +1: > > It looks like the assembly-plugin workaround causes a maven warning, it > is I guess better to add the v

Re: [VOTE] Release DBCP 2.0.1 based on RC3

2014-05-18 Thread Bernd Eckenfels
+0 'mvn verify' works with mvn3.2.1 jdk8 on win7 'mvn site' works with mvn3.2.1 jdk7 on win7 Why I do not +1: It looks like the assembly-plugin workaround causes a maven warning, it is I guess better to add the version number to the existing assembly entry and not add a second one? At least the

[VOTE] Release DBCP 2.0.1 based on RC3

2014-05-18 Thread Phil Steitz
The problem with line endings in RC2 has been fixed. DBCP 2.0.1 RC3 is available for review here: https://dist.apache.org/repos/dist/dev/commons/dbcp (r5379) Maven artifacts are here: https://repository.apache.org/content/repositories/orgapachecommons-1031/ Details of changes since 2.0 are i