Re: [VOTE] Release Configuration 2.1 based on RC2

2016-08-10 Thread Dennis Kieselhorst
Hi Oliver! > so do we have a confirmation that the current state in trunk builds > correctly on the problematic platforms? Then I could start preparing > another RC in the next days. > As the checkstyle config is now adapted, please prepare another RC. Cheers Dennis --

Re: [VOTE] Release Configuration 2.1 based on RC2

2016-08-04 Thread Oliver Heger
Hi, so do we have a confirmation that the current state in trunk builds correctly on the problematic platforms? Then I could start preparing another RC in the next days. Thanks Oliver Am 02.08.2016 um 09:08 schrieb Dennis Kieselhorst: > Hi Gary! >> We have a mini-mess here: >> >> - checkstyle's

Re: [VOTE] Release Configuration 2.1 based on RC2

2016-08-02 Thread Dennis Kieselhorst
Hi Gary! > We have a mini-mess here: > > - checkstyle's check is called from the build and it fails. > - Did it ever work? > - Did it work and then the code degraded between the last release and this > code base? The 2.0 checkstyle is clean: > https://commons.apache.org/proper/commons-configuration

Re: [VOTE] Release Configuration 2.1 based on RC2

2016-08-01 Thread Gary Gregory
On Mon, Aug 1, 2016 at 2:23 PM, Gary Gregory wrote: > Another thing: The whole point of adding checkstyle check to the build is > to have the build fail when there are violations. Otherwise, just look at > the report on the generated site. > > It seems to me that the options are: > - Remove the c

Re: [VOTE] Release Configuration 2.1 based on RC2

2016-08-01 Thread Gary Gregory
Another thing: The whole point of adding checkstyle check to the build is to have the build fail when there are violations. Otherwise, just look at the report on the generated site. It seems to me that the options are: - Remove the check from the build - Fix the code. My previous questions still

Re: [VOTE] Release Configuration 2.1 based on RC2

2016-08-01 Thread Oliver Heger
Am 01.08.2016 um 21:50 schrieb Gary Gregory: > On Mon, Aug 1, 2016 at 12:38 PM, Oliver Heger > wrote: > >> >> >> Am 01.08.2016 um 11:04 schrieb Dennis Kieselhorst: >>> Hi Benedikt! >>> The build log is here [1]. It looks like some generated classes are >> checked by checkstyle which c

Re: [VOTE] Release Configuration 2.1 based on RC2

2016-08-01 Thread Gary Gregory
On Mon, Aug 1, 2016 at 12:38 PM, Oliver Heger wrote: > > > Am 01.08.2016 um 11:04 schrieb Dennis Kieselhorst: > > Hi Benedikt! > > > >> The build log is here [1]. It looks like some generated classes are > checked > >> by checkstyle which causes the build to fail. The build works with Java > 7 >

Re: [VOTE] Release Configuration 2.1 based on RC2

2016-08-01 Thread Oliver Heger
Am 01.08.2016 um 11:04 schrieb Dennis Kieselhorst: > Hi Benedikt! > >> The build log is here [1]. It looks like some generated classes are checked >> by checkstyle which causes the build to fail. The build works with Java 7 >> and Java 8. So my vote again is -1 because I think mvn clean install

Re: [VOTE] Release Configuration 2.1 based on RC2

2016-08-01 Thread Sergio Fernández
+1 (non-binding) So far I've checked: signatures and digests, source releases file layouts, matched svn commit id, NOTICE and LICENSE files, license headers, build sources in a clean environment (Maven 3.3.9, OpenJDK 1.8.0_91 64-Bit, Debian amd64). On Mon, Aug 1, 2016 at 11:04 AM, Dennis Kieselh

Re: [VOTE] Release Configuration 2.1 based on RC2

2016-08-01 Thread Dennis Kieselhorst
Hi Benedikt! > The build log is here [1]. It looks like some generated classes are checked > by checkstyle which causes the build to fail. The build works with Java 7 > and Java 8. So my vote again is -1 because I think mvn clean install should > work with the minimum required JDK out of the box.

Re: [VOTE] Release Configuration 2.1 based on RC2

2016-07-31 Thread Benedikt Ritter
Hello Oliver, mvn clean install still fails when building with: Apache Maven 3.2.5 (12a6b3acb947671f09b81f49094c53f426d8cea1; 2014-12-14T18:29:23+01:00) Maven home: /usr/local/Cellar/maven/3.2.5/libexec Java version: 1.6.0_65, vendor: Apple Inc. Java home: /Library/Java/JavaVirtualMachines/1.6.0.

Re: [VOTE] Release Configuration 2.1 based on RC2

2016-07-31 Thread Dennis Kieselhorst
+1 Am 30.07.2016 um 22:02 schrieb Oliver Heger: > Hi all, > > after the failed vote for RC1 a new RC has been created. The only > difference is that the checkstyle plugin has been downgraded which > should allow building the project on Java 1.6. > > Configuration 2.1 RC2 is available for review he

[VOTE] Release Configuration 2.1 based on RC2

2016-07-30 Thread Oliver Heger
Hi all, after the failed vote for RC1 a new RC has been created. The only difference is that the checkstyle plugin has been downgraded which should allow building the project on Java 1.6. Configuration 2.1 RC2 is available for review here: https://dist.apache.org/repos/dist/dev/commons/config