> On Feb 8, 2017, at 7:17 PM, sebb wrote:
>
>> On 8 February 2017 at 17:51, Rob Tompkins wrote:
>> Hello,
>>
>> This vote passes with (in order of appearance):
>>
>> Oliver Heger: +1
>> Benedikt Ritter: +1
>> Thomas Vandahl: +1
>> Rob Tompkins: +1
>
> Sorry to be picky, but only the PMC vot
On 8 February 2017 at 17:51, Rob Tompkins wrote:
> Hello,
>
> This vote passes with (in order of appearance):
>
> Oliver Heger: +1
> Benedikt Ritter: +1
> Thomas Vandahl: +1
> Rob Tompkins: +1
Sorry to be picky, but only the PMC votes are binding, i.e. the first 3.
This is still OK for the vote
: [VOTE] Release Commons Text 1.0-beta-1 based on RC4
Hi Bruno,
can you try export LC_ALL=en_US.UTF-8 ?
Think some tests can desire to force the locale maybe (have the same having a
french locale by default)
Romain Manni-Bucau
@rmannibucau | Blog | Old Blog | Github | LinkedIn | JavaEE Factory
Hello,
This vote passes with (in order of appearance):
Oliver Heger: +1
Benedikt Ritter: +1
Thomas Vandahl: +1
Rob Tompkins: +1
I'll proceed with the release procedure.
Thanks to all who reviewed this and the last RC.
-Rob
> On Jan 30, 2017, at 9:14 AM, Rob Tompkins wrote:
>
> Hello all,
>
t;> but
>>>>>>>> was:<1: 6[,543.]21>
>>>>>>>> ExtendedMessageFormatTest.testExtendedAndBuiltInFormats:141 null
>>>>>>>> expected: but
>>>>>>>> was:
>>>>>>>> ExtendedMessageFormatTest.testO
ull
>>>>>>>> expected: but
>>>>>>>> was:
>>>>>>>> ExtendedMessageFormatTest.testOverriddenBuiltinFormat:
>>>>>>>> 253->checkBuiltInFormat:347->checkBuiltInFormat:376 format Pattern=[1:
>>>>
{0,date}], locale=[null] expected:<1: [23/01/]2007> but was:<1: [Jan 23,
>>>>>>> ]2007>
>>>>>>>
>>>>>>> Tests run: 476, Failures: 5, Errors: 0, Skipped: 0
>>>>>>>
>>>>>>> [INFO]
at: 2017-02-06T14:07:52-02:00
>>>>>> [INFO] Final Memory: 30M/328M
>>>>>> [INFO]
>>>>>>
>>>>>> /* --- snip -- */
>>>>>>
>>>
*/
>>>>>
>>>>> Here's my env:
>>>>>
>>>>> Apache Maven 3.3.9
>>>>> Maven home: /usr/share/maven
>>>>> Java version: 1.8.0_111, vendor: Oracle Corporation
>>>>> Java home: /usr/lib/jvm/
en_US, platform encoding: UTF-8
>>>> OS name: "linux", version: "4.4.0-59-generic", arch: "amd64", family:
>>>> "unix"
>>>>
>>>>
>>>> Even though the JVM locale seems to be set to en_US, I'm in Brazil right
>>>> n
he locale (or so
>>> I think). Here's my output of running the `locale` command.
>>>
>>> /* --- snip --- */
>>> $ locale
>>> LANG=en_US.UTF-8
>>> LANGUAGE=en_US
>>> LC_CTYPE=pt_BR.UTF-8
>>> LC_NUMERIC=pt_BR.UTF-8
>>>
;> LC_COLLATE="en_US.UTF-8"
>> LC_MONETARY=pt_BR.UTF-8
>> LC_MESSAGES="en_US.UTF-8"
>> LC_PAPER=pt_BR.UTF-8
>> LC_NAME=pt_BR.UTF-8
>> LC_ADDRESS=pt_BR.UTF-8
>> LC_TELEPHONE=pt_BR.UTF-8
>> LC_MEASUREMENT=pt_BR.UTF-8
>> LC_IDENTIFICAT
R.UTF-8
> LC_NAME=pt_BR.UTF-8
> LC_ADDRESS=pt_BR.UTF-8
> LC_TELEPHONE=pt_BR.UTF-8
> LC_MEASUREMENT=pt_BR.UTF-8
> LC_IDENTIFICATION=pt_BR.UTF-8
> LC_ALL=
> /* --- snip --- */
>
> I guess these failing tests would be a blocker issue for this beta
> release? I can he
uld have to specify the locale on those tests
to be US only...
Hope that helps, cheers
Bruno
----- Original Message -
From: Rob Tompkins
To: Commons Developers List
Sent: Monday, 30 January 2017 12:14 PM
Subject: [VOTE] Release Commons Text 1.0-beta-1 based on RC4
Hello all,
This is a [VOTE
Hi Rob,
On 30.01.17 15:14, Rob Tompkins wrote:
> Hello all,
>
> This is a [VOTE] for releasing Apache Commons Text 1.0-beta-1 (from RC4).
[...]
Artifacts look good, signatures are ok, site looks good.
My guess would be if you use Eclipse you can iron out most of the
checkstyle errors at once wit
Rob,
I could help out with the checkstyle issues if you need the help and we can
figure out how to partition it so we aren't stepping on each other.
Thanks,
Ray
On Sun, Feb 5, 2017 at 11:04 AM, Rob Tompkins wrote:
>
>
> > On Feb 5, 2017, at 10:02 AM, Benedikt Ritter wrote:
> >
> > Hello Rober
> On Feb 5, 2017, at 10:02 AM, Benedikt Ritter wrote:
>
> Hello Robert,
>
> sorry it took me to long to review this RC! Here are my observations:
>
> - Builds from source using Java 7 and 8
> - The release tag is not signed - since we could never do this in svn land, I
> don’t consider this
Hello Robert,
sorry it took me to long to review this RC! Here are my observations:
- Builds from source using Java 7 and 8
- The release tag is not signed - since we could never do this in svn land, I
don’t consider this blocking.
- .travis.yml is file missing in the source archive. It is not r
Hi Rob,
all my points from the previous RC have been addressed.
+1
Great work!
One minor thing I noticed: AFAIK, the md5 hashes have to be added to the
files in the distribution area.
Oliver
Am 30.01.2017 um 15:14 schrieb Rob Tompkins:
> Hello all,
>
> This is a [VOTE] for releasing Apache C
Hello Robert,
> Am 02.02.2017 um 16:41 schrieb Rob Tompkins :
>
>>
>> On Jan 30, 2017, at 9:14 AM, Rob Tompkins wrote:
>>
>> Hello all,
>>
>> This is a [VOTE] for releasing Apache Commons Text 1.0-beta-1 (from RC4).
>>
>> Tag name:
>> commons-text-1.0-beta-1-RC4 (signature can be checked f
> On Feb 2, 2017, at 12:11 PM, Gilles wrote:
>
> On Thu, 2 Feb 2017 10:41:17 -0500, Rob Tompkins wrote:
>>> On Jan 30, 2017, at 9:14 AM, Rob Tompkins wrote:
>>>
>>> Hello all,
>>>
>>> This is a [VOTE] for releasing Apache Commons Text 1.0-beta-1 (from RC4).
>>>
>>> Tag name:
>>> commons-te
On Thu, 2 Feb 2017 10:41:17 -0500, Rob Tompkins wrote:
On Jan 30, 2017, at 9:14 AM, Rob Tompkins
wrote:
Hello all,
This is a [VOTE] for releasing Apache Commons Text 1.0-beta-1 (from
RC4).
Tag name:
commons-text-1.0-beta-1-RC4 (signature can be checked from git
using 'git tag -v')
$ g
> On Jan 30, 2017, at 9:14 AM, Rob Tompkins wrote:
>
> Hello all,
>
> This is a [VOTE] for releasing Apache Commons Text 1.0-beta-1 (from RC4).
>
> Tag name:
> commons-text-1.0-beta-1-RC4 (signature can be checked from git using 'git
> tag -v')
>
> Tag URL:
>
> https://git-wip-us.apache
Hello all,
This is a [VOTE] for releasing Apache Commons Text 1.0-beta-1 (from RC4).
Tag name:
commons-text-1.0-beta-1-RC4 (signature can be checked from git using 'git
tag -v')
Tag URL:
https://git-wip-us.apache.org/repos/asf?p=commons-text.git;a=commit;h=65e4314fbd6c3a8f5c248d07a4ccffc
24 matches
Mail list logo
