Re: [VOTE] Release Commons Release Plugin 1.0 base on RC1

2018-01-18 Thread sebb
FTR, commons parent is not in the same class as the mojos commons-release or commons-build. The mojos are purely optional helpers for Commons developers. It's possible to build without them. However, commons-parent is not optional; the sources won't build without the relevant version. Individual

Re: [VOTE] Release Commons Release Plugin 1.0 base on RC1

2018-01-16 Thread Gary Gregory
For an internal component like this one and commons-parent, I feel that announcing on @dev is plenty. Users don't care and the Apache announce list is not appropriate IMO. Gary On Tue, Jan 16, 2018 at 3:22 PM, Rob Tompkins wrote: > Pardon, I’ve been vague. I meant to ask about the release annou

[RESULT][VOTE] Release Commons Release Plugin 1.0 base on RC1

2018-01-16 Thread Rob Tompkins
The vote passes with the following +1 votes in order of appearance: - Bruno P. Kinoshita, - Stian Soiland-Reyes, and - Rob Tompkins I will perform the requisite promotion activities. Many thanks to all of those that weighed in on this and the ideas for improvements that can be made to the compo

Re: [VOTE] Release Commons Release Plugin 1.0 base on RC1

2018-01-16 Thread Rob Tompkins
Here’s my +1. > On Jan 10, 2018, at 9:50 PM, Rob Tompkins wrote: > > Hello all, > > This is a [VOTE] for releasing Apache commons-release-plugin 1.0 (from RC1). > > Tag name: > commons-release-plugin-1.0-RC1 (signature can be checked from git using > 'git tag -v') > > Tag URL: > > https

Re: [VOTE] Release Commons Release Plugin 1.0 base on RC1

2018-01-16 Thread Rob Tompkins
Pardon, I’ve been vague. I meant to ask about the release announcement. Typically we send those up to annou...@apache.org for our top level components. But, the prescient for commons-parent seems to be to only email the announcement to our dev list. Which do you think I should do? > On Jan 16,

Re: [VOTE] Release Commons Release Plugin 1.0 base on RC1

2018-01-16 Thread Gary Gregory
Right: "Once a vote is successful, post a [RESULT] Release Foo 1.2 email to *dev@commons.apache.org * as a reply to the original posting. This email should contain a summary of the voters/votes that were cast, eg..." from http://commons.apache.org/releases/prepare.html Gary On Tue, Jan 16, 2018 a

Re: [VOTE] Release Commons Release Plugin 1.0 base on RC1

2018-01-16 Thread Rob Tompkins
I’ll do the tally tonight (UTC-5). Should the announce only go to the dev list? > On Jan 16, 2018, at 2:40 PM, Gary Gregory wrote: > > I think you have enough VOTEs from the PMC ATM. Tally? > > Gary > >> On Tue, Jan 16, 2018 at 10:17 AM, Otto Fowler >> wrote: >> Do you have a page with the v

Re: [VOTE] Release Commons Release Plugin 1.0 base on RC1

2018-01-16 Thread Gary Gregory
I think you have enough VOTEs from the PMC ATM. Tally? Gary On Tue, Jan 16, 2018 at 10:17 AM, Otto Fowler wrote: > Do you have a page with the verification steps and requirements? > > > On January 16, 2018 at 11:59:34, Rob Tompkins (chtom...@gmail.com) wrote: > > Curious if anyone else wants to

Re: [VOTE] Release Commons Release Plugin 1.0 base on RC1

2018-01-16 Thread Otto Fowler
Do you have a page with the verification steps and requirements? On January 16, 2018 at 11:59:34, Rob Tompkins (chtom...@gmail.com) wrote: Curious if anyone else wants to weigh in? > On Jan 16, 2018, at 6:55 AM, Stian Soiland-Reyes wrote: > > +1 (Binding) > > (While I might disagree in princip

Re: [VOTE] Release Commons Release Plugin 1.0 base on RC1

2018-01-16 Thread Rob Tompkins
Curious if anyone else wants to weigh in? > On Jan 16, 2018, at 6:55 AM, Stian Soiland-Reyes wrote: > > +1 (Binding) > > (While I might disagree in principle about removing source .tar.gz and > .zip from Maven repo, I say let's get the plugin released and find > more bugs later! :) ) > This *

Re: [VOTE] Release Commons Release Plugin 1.0 base on RC1

2018-01-16 Thread Stian Soiland-Reyes
+1 (Binding) (While I might disagree in principle about removing source .tar.gz and .zip from Maven repo, I say let's get the plugin released and find more bugs later! :) ) Checked: +1 gpg signatures +1 sha1, md5 +1 source zip vs tar.gz +1 binary zip vs tar.gz +1 source vs git (for some reason g

Re: [VOTE] Release Commons Release Plugin 1.0 base on RC1

2018-01-14 Thread Rob Tompkins
> On Jan 14, 2018, at 6:50 PM, sebb wrote: > >> On 13 January 2018 at 15:56, Rob Tompkins wrote: >> >> >>> On Jan 11, 2018, at 7:25 PM, sebb wrote: >>> >>> On 11 January 2018 at 14:42, Rob Tompkins wrote: If you do try to run it locally make sure you add true >>> >>> It would b

Re: [VOTE] Release Commons Release Plugin 1.0 base on RC1

2018-01-14 Thread sebb
On 13 January 2018 at 15:56, Rob Tompkins wrote: > > >> On Jan 11, 2018, at 7:25 PM, sebb wrote: >> >> On 11 January 2018 at 14:42, Rob Tompkins wrote: >>> If you do try to run it locally make sure you add >>> true >> >> It would be useful to be able to define this on the command-line. > > Bug f

Re: [VOTE] Release Commons Release Plugin 1.0 base on RC1

2018-01-13 Thread Rob Tompkins
> On Jan 11, 2018, at 7:25 PM, sebb wrote: > > On 11 January 2018 at 14:42, Rob Tompkins wrote: >> If you do try to run it locally make sure you add >> true > > It would be useful to be able to define this on the command-line. Bug found: https://github.com/apache/commons-release-plugin/blob

Re: [release-plugin] release process (Was: Re: [VOTE] Release Commons Release Plugin 1.0 base on RC1)

2018-01-13 Thread Oliver Heger
Am 13.01.2018 um 15:36 schrieb Gilles: > On Sat, 13 Jan 2018 08:48:19 -0500, Rob Tompkins wrote: >> Given that right now we don’t have sufficient votes to release the >> plugin, do folks want me to cancel this vote in leu of the lazy vote >> process cleaning up the nits that folks have found? I’m

Re: [release-plugin] release process (Was: Re: [VOTE] Release Commons Release Plugin 1.0 base on RC1)

2018-01-13 Thread Gary Gregory
I will find some time to review this weekend. Gary On Jan 13, 2018 6:48 AM, "Rob Tompkins" wrote: > Given that right now we don’t have sufficient votes to release the plugin, > do folks want me to cancel this vote in leu of the lazy vote process > cleaning up the nits that folks have found? I’m

Re: [release-plugin] release process (Was: Re: [VOTE] Release Commons Release Plugin 1.0 base on RC1)

2018-01-13 Thread Gilles
On Sat, 13 Jan 2018 08:48:19 -0500, Rob Tompkins wrote: Given that right now we don’t have sufficient votes to release the plugin, do folks want me to cancel this vote in leu of the lazy vote process cleaning up the nits that folks have found? I’m curious since folks don’t seem to have the appeti

[release-plugin] release process (Was: Re: [VOTE] Release Commons Release Plugin 1.0 base on RC1)

2018-01-13 Thread Rob Tompkins
Given that right now we don’t have sufficient votes to release the plugin, do folks want me to cancel this vote in leu of the lazy vote process cleaning up the nits that folks have found? I’m curious since folks don’t seem to have the appetite for this process. > On Jan 11, 2018, at 10:51 PM, G

Re: [VOTE] Release Commons Release Plugin 1.0 base on RC1

2018-01-11 Thread Gary Gregory
Tangent: It just occurred to me that this could have helped in the process of developing this plugin: https://github.com/ok2c/httpcomponents-release-tools/wiki Gary On Thu, Jan 11, 2018 at 6:54 PM, Rob Tompkins wrote: > I had that quickly set up by adding > > ${dryRun} > > to the plugin configu

Re: [VOTE] Release Commons Release Plugin 1.0 base on RC1

2018-01-11 Thread Rob Tompkins
I had that quickly set up by adding ${dryRun} to the plugin configuration, but I admit that’s a bit of a hack. I was just trying to be speedy in the first version of the plugin for folks’ benefit. > On Jan 11, 2018, at 7:25 PM, sebb wrote: > >> On 11 January 2018 at 14:42, Rob Tompkins wro

Re: [VOTE] Release Commons Release Plugin 1.0 base on RC1

2018-01-11 Thread sebb
On 11 January 2018 at 14:42, Rob Tompkins wrote: > If you do try to run it locally make sure you add > true It would be useful to be able to define this on the command-line. > To the configuration section of the plugin. > >> On Jan 11, 2018, at 3:58 AM, Jörg Schaible >> wrote: >> >> Am Wed, 10

Re: [VOTE] Release Commons Release Plugin 1.0 base on RC1

2018-01-11 Thread Rob Tompkins
If you do try to run it locally make sure you add true To the configuration section of the plugin. > On Jan 11, 2018, at 3:58 AM, Jörg Schaible > wrote: > > Am Wed, 10 Jan 2018 20:35:52 -0700 schrieb Gary Gregory: > >> I wonder if: >> - This should be a LAZY VOTE since this is not an officia

Re: [VOTE] Release Commons Release Plugin 1.0 base on RC1

2018-01-11 Thread Rob Tompkins
If you want to really test it in dry run mode you could run “mvn clean install” on the src artifact and then configure it in a component and run a test release. It should work just the same as if it was coming out of maven central. -Rob > On Jan 11, 2018, at 3:58 AM, Jörg Schaible > wrote: >

Re: [VOTE] Release Commons Release Plugin 1.0 base on RC1

2018-01-11 Thread Bruno P. Kinoshita
6) Few StringBuffers in some Mojos that perhaps could be replaced by StringBuilders? Again, just nit-picks. Release looks good, +1 and kudos!!! Cheers Bruno From: Rob Tompkins To: Commons Developers List Sent: Thursday, 11 January 2018 3:50 PM Subject: [

Re: [VOTE] Release Commons Release Plugin 1.0 base on RC1

2018-01-11 Thread Jörg Schaible
Am Wed, 10 Jan 2018 20:35:52 -0700 schrieb Gary Gregory: > I wonder if: > - This should be a LAZY VOTE since this is not an official component but > rather a tool +1 > - We should release it as 1.0 anyway (unless obvious bugs > are found) to avoid the chicken and egg problem: To really test this

Re: [VOTE] Release Commons Release Plugin 1.0 base on RC1

2018-01-11 Thread Sergio Fernández
What about casting this first release as 0.1? Then we solve the chicken & egg problem: we can verify it the actual components before releasing 1.0 (which semantically speaking has a strong meaning. On Jan 11, 2018 04:35, "Gary Gregory" wrote: I wonder if: - This should be a LAZY VOTE since thi

Re: [VOTE] Release Commons Release Plugin 1.0 base on RC1

2018-01-10 Thread Gary Gregory
I wonder if: - This should be a LAZY VOTE since this is not an official component but rather a tool - We should release it as 1.0 anyway (unless obvious bugs are found) to avoid the chicken and egg problem: To really test this, I want to create an RC for Commons Collection (for example). But that m

Re: [VOTE] Release Commons Release Plugin 1.0 base on RC1

2018-01-10 Thread Gary Gregory
Nit: main site page: "This is a Maven 3.x Plugin which is used by Apache Commons releases." -> "This is a Maven 3.x Plugin which is used by Apache Commons release managers." Gary On Wed

[VOTE] Release Commons Release Plugin 1.0 base on RC1

2018-01-10 Thread Rob Tompkins
Hello all, This is a [VOTE] for releasing Apache commons-release-plugin 1.0 (from RC1). Tag name: commons-release-plugin-1.0-RC1 (signature can be checked from git using 'git tag -v') Tag URL: https://git-wip-us.apache.org/repos/asf?p=commons-release-plugin.git;a=tag;h=6b05b8bee894ad471c