Re: [VOTE] Release Commons-Net 1.5 RC3

2009-07-20 Thread Niall Pemberton
IMO its confusing that the NET_1_5_0_RC3 tag was created from the first incorrectly tagged NET_2_1_RC1 (especially since that original tag has been removed and re-created). Better IMO to re-tag properly a RC4 from trunk http://svn.apache.org/viewvc?view=rev&revision=796050 Niall On Tue, Jul 21,

[VOTE] Release Commons-Net 1.5 RC3

2009-07-20 Thread Rory Winston
Hi folks Been kicking around for a while: Tag: http://svn.apache.org/viewvc/commons/proper/net/tags/NET_1_5_0_RC3/ Binaries/sources etc: http://people.apache.org/~rwinston/commons-net-1.5.0-RC3/ +1 +0 -0 -1 Thanks --Rory - T

Re: [VOTE] Release Commons Net 1.5

2008-03-12 Thread sebb
iginal Message- > > > From: Rory Winston [mailto:[EMAIL PROTECTED] > > > Sent: Samstag, 08. März 2008 21:39 > > To: Jakarta Commons Developers List > > > Subject: Re: [VOTE] Release Commons Net 1.5 > > > > The functional tests seem to be broken r

RE: [VOTE] Release Commons Net 1.5

2008-03-12 Thread Oberhuber, Martin
al Staff, Wind River Target Management Project Lead, DSDP PMC Member http://www.eclipse.org/dsdp/tm > -Original Message- > From: Rory Winston [mailto:[EMAIL PROTECTED] > Sent: Samstag, 08. März 2008 21:39 > To: Jakarta Commons Developers List > Subject: Re: [VOTE] Rel

RE: [NET] fixing short date parsing problems (was: [VOTE] Release Commons Net 1.5)

2008-03-12 Thread Oberhuber, Martin
: Dienstag, 11. März 2008 21:10 > To: Jakarta Commons Developers List > Subject: Re: [NET] fixing short date parsing problems (was: > [VOTE] Release Commons Net 1.5) > > Sebb/Martin > > The lenient future dates flag just allows a window of +1 day in the > short timestamp, wh

Re: [NET] fixing short date parsing problems (was: [VOTE] Release Commons Net 1.5)

2008-03-11 Thread sebb
On 11/03/2008, Rory Winston <[EMAIL PROTECTED]> wrote: > Sebb/Martin Martin and I agree on wanting the parser to return an FTPFile rather than null for the cases where the date (etc ?) does not parse OK. I would like to see this go into the next release of NET 1.5 and 2.0; I think this will avoid

Re: [NET] fixing short date parsing problems (was: [VOTE] Release Commons Net 1.5)

2008-03-11 Thread Rory Winston
Sebb/Martin The lenient future dates flag just allows a window of +1 day in the short timestamp, which if > now(), will not be rolled back by a year. This is to prevent dates slightly in the future being rolled back inappropriately. You keep mentioning the +/- 6 month thing - the problem is t

RE: [NET] fixing short date parsing problems (was: [VOTE] Release Commons Net 1.5)

2008-03-11 Thread Oberhuber, Martin
> Seems to me it would be a lot better if the FTPFile entry was still > generated, but with a null date. I agree. In the past, commons net ftp has always been using strict parsing, with the result that some files might have been missed. We have also seen this on Solaris with certain devices which

Re: [NET] fixing short date parsing problems (was: [VOTE] Release Commons Net 1.5)

2008-03-11 Thread sebb
On 10/03/2008, sebb <[EMAIL PROTECTED]> wrote: > On 10/03/2008, Rory Winston <[EMAIL PROTECTED]> wrote: > > Hi Sebb > > > > A couple of things: > > > > 1. Which tests are you referring to in your first point below? > > > testFeb29IfLeapYear(org.apache.commons.net.ftp.parser.FTPTimestampParse

Re: [NET] fixing short date parsing problems (was: [VOTE] Release Commons Net 1.5)

2008-03-10 Thread sebb
On 10/03/2008, Rory Winston <[EMAIL PROTECTED]> wrote: > Hi Sebb > > A couple of things: > > 1. Which tests are you referring to in your first point below? testFeb29IfLeapYear(org.apache.commons.net.ftp.parser.FTPTimestampParserImplTest) testFeb29LeapYear(org.apache.commons.net.ftp.parser.FTPTim

Re: [NET] fixing short date parsing problems (was: [VOTE] Release Commons Net 1.5)

2008-03-10 Thread Rory Winston
Hi Sebb A couple of things: 1. Which tests are you referring to in your first point below? 2. Does the assumption have anything to do with the lenientFutureDates flag in FTPTimestampParserImpl? Rory sebb wrote: I've committed updates to the FTPTimestampParserImplTest classes in trunk and NE

[NET] fixing short date parsing problems (was: [VOTE] Release Commons Net 1.5)

2008-03-09 Thread sebb
I've committed updates to the FTPTimestampParserImplTest classes in trunk and NET_2_0. The 2 additional tests for Feb 29 fail on Java 1.3/1.4. Both trunk (Java 1.3/1.4) and NET_2_0 (Java 1.5+) now fail on short dates that fall in a different year from current (previous or next). Some of the exis

Re: [VOTE] Release Commons Net 1.5

2008-03-09 Thread Rory Winston
Sure, you can just add them directly yourself if you like. Rory The *nix short date formatting fixes don't currently have any tests, at least when I last checked. I think these need to be added first. I can add some later today if that's OK with you? Or do you want them done as patches via Jira

Re: [VOTE] Release Commons Net 1.5

2008-03-09 Thread sebb
The *nix short date formatting fixes don't currently have any tests, at least when I last checked. I think these need to be added first. I can add some later today if that's OK with you? Or do you want them done as patches via Jira? On 09/03/2008, Rory Winston <[EMAIL PROTECTED]> wrote: > Hi Jam

Re: [VOTE] Release Commons Net 1.5

2008-03-09 Thread Rory Winston
Hi James Yes, I'm going to cut new RCs for 1.5 and 2.0. Thanks Rory James Carman wrote: On 3/8/08, Rory Winston <[EMAIL PROTECTED]> wrote: I've taken into account the suggestions proposed by various people wrt the TFTP server classes and accordingly made some changes. Thanks for the fee

Re: [VOTE] Release Commons Net 1.5

2008-03-09 Thread James Carman
On 3/8/08, Rory Winston <[EMAIL PROTECTED]> wrote: > I've taken into account the suggestions proposed by various people wrt > the TFTP server classes and accordingly made some changes. Thanks for > the feedback. > So, does that mean you're cutting (or have already done so) a new release candidat

Re: [VOTE] Release Commons Net 1.5

2008-03-08 Thread Rory Winston
I've taken into account the suggestions proposed by various people wrt the TFTP server classes and accordingly made some changes. Thanks for the feedback. Rory sebb wrote: On 07/03/2008, Henri Yandell <[EMAIL PROTECTED]> wrote: On Fri, Mar 7, 2008 at 8:04 AM, James Carman <[EMAIL PROTECTE

Re: [VOTE] Release Commons Net 1.5

2008-03-08 Thread Rory Winston
P PMC Member http://www.eclipse.org/dsdp/tm -Original Message- From: Oberhuber, Martin Sent: Montag, 03. März 2008 11:50 To: 'Jakarta Commons Developers List' Subject: RE: [VOTE] Release Commons Net 1.5 Hi Rory, it's great to hear some progress is being made towar

Re: [VOTE] Release Commons Net 1.5

2008-03-07 Thread sebb
On 07/03/2008, Henri Yandell <[EMAIL PROTECTED]> wrote: > On Fri, Mar 7, 2008 at 8:04 AM, James Carman <[EMAIL PROTECTED]> wrote: > > On 3/2/08, Rory Winston <[EMAIL PROTECTED]> wrote: > > > Hi > > > > > > This is a release vote for Commons Net 1.5. This release fixes a few > > > issues

Re: [VOTE] Release Commons Net 1.5

2008-03-07 Thread Henri Yandell
On Fri, Mar 7, 2008 at 8:04 AM, James Carman <[EMAIL PROTECTED]> wrote: > On 3/2/08, Rory Winston <[EMAIL PROTECTED]> wrote: > > Hi > > > > This is a release vote for Commons Net 1.5. This release fixes a few > > issues with TFTP errors, threading hangs, and a leap year date parsing > bug. >

Re: [VOTE] Release Commons Net 1.5

2008-03-07 Thread James Carman
On 3/2/08, Rory Winston <[EMAIL PROTECTED]> wrote: > Hi > > This is a release vote for Commons Net 1.5. This release fixes a few > issues with TFTP errors, threading hangs, and a leap year date parsing bug. > > The RC deployment is here: > http://people.apache.org/~rwinston/commons-net-1.5.0/si

Re: [VOTE] Release Commons Net 1.5

2008-03-03 Thread Jeffrey Brekke
I have compiler errors: /home/jbrekke/sandbox/other/net/src/test/org/apache/commons/net/tftp/TFTPTests.java:[33,8] cannot find symbol symbol : class TFTPServer location: class org.apache.commons.net.tftp.TFTPTests /home/jbrekke/sandbox/other/net/src/test/org/apache/commons/net/tftp/TFTPTests.jav

Re: [VOTE] Release Commons Net 1.5

2008-03-03 Thread sebb
gt; > > From: sebb [mailto:[EMAIL PROTECTED] > > Sent: Montag, 03. März 2008 14:29 > > To: Jakarta Commons Developers List > > > Subject: Re: [VOTE] Release Commons Net 1.5 > > > > > > TFTPServer.java > > > > SocketTimeoutException

Re: [VOTE] Release Commons Net 1.5

2008-03-03 Thread James Carman
DSDP PMC Member > http://www.eclipse.org/dsdp/tm > > > > > -Original Message- > > > From: sebb [mailto:[EMAIL PROTECTED] > > Sent: Montag, 03. März 2008 14:29 > > To: Jakarta Commons Developers List > > > Subject: Re: [VOTE] Release Commons Net 1.5

RE: [VOTE] Release Commons Net 1.5

2008-03-03 Thread Oberhuber, Martin
ember http://www.eclipse.org/dsdp/tm > -Original Message- > From: sebb [mailto:[EMAIL PROTECTED] > Sent: Montag, 03. März 2008 14:29 > To: Jakarta Commons Developers List > Subject: Re: [VOTE] Release Commons Net 1.5 > > > > TFTPServer.java > > >

Re: [VOTE] Release Commons Net 1.5

2008-03-03 Thread sebb
ember > > http://www.eclipse.org/dsdp/tm > > > > > > > > > -----Original Message----- > > > From: Oberhuber, Martin > > > > > > > Sent: Montag, 03. März 2008 12:57 > > > To: 'Jakarta Commons Developers List

Re: [VOTE] Release Commons Net 1.5

2008-03-03 Thread Niall Pemberton
- > > From: Oberhuber, Martin > > > > Sent: Montag, 03. März 2008 12:57 > > To: 'Jakarta Commons Developers List'; 'Rory Winston' > > Subject: RE: [VOTE] Release Commons Net 1.5 > > > > Also, I get unit test failures in > >

RE: [VOTE] Release Commons Net 1.5

2008-03-03 Thread Oberhuber, Martin
http://www.eclipse.org/dsdp/tm > -Original Message- > From: Oberhuber, Martin > Sent: Montag, 03. März 2008 12:57 > To: 'Jakarta Commons Developers List'; 'Rory Winston' > Subject: RE: [VOTE] Release Commons Net 1.

RE: [VOTE] Release Commons Net 1.5

2008-03-03 Thread Oberhuber, Martin
Management Project Lead, DSDP PMC Member http://www.eclipse.org/dsdp/tm > -Original Message- > From: Oberhuber, Martin > Sent: Montag, 03. März 2008 11:50 > To: 'Jakarta Commons Developers List' > Subject: RE: [VOTE] Release Commons Net 1.5 > > Hi Ror

Re: [VOTE] Release Commons Net 1.5

2008-03-03 Thread Niall Pemberton
I've added source file headers to those that were missing and corrected the ones which didn't conform to current policy (i.e. had the Copyright notice): http://svn.apache.org/viewvc?view=rev&revision=633032 Also added the clirr report - and running the report says that 1.5 is binary compatible wi

RE: [VOTE] Release Commons Net 1.5

2008-03-03 Thread Oberhuber, Martin
n [mailto:[EMAIL PROTECTED] > Sent: Sonntag, 02. März 2008 22:40 > To: Jakarta Commons Developers List > Subject: [VOTE] Release Commons Net 1.5 > > Hi > > This is a release vote for Commons Net 1.5. This release fixes a few > issues with TFTP errors, threading hangs, and a

Re: [VOTE] Release Commons Net 1.5

2008-03-03 Thread Niall Pemberton
This distributiion has not been built from whats been tagged as NET_1_5_0 in subversion - the pom.xml and issue-tracking.xml files are different. Also the source distro contains files which are not in the subversion repo (TFTPClient-1.4.1-fix.diff, TFTPClient.java.orig and TFTPClient.java.rej) and

[VOTE] Release Commons Net 1.5

2008-03-02 Thread Rory Winston
Hi This is a release vote for Commons Net 1.5. This release fixes a few issues with TFTP errors, threading hangs, and a leap year date parsing bug. The RC deployment is here: http://people.apache.org/~rwinston/commons-net-1.5.0/site/ Binaries: http://people.apache.org/~rwinston/commons-net-1.5

[VOTE] Release Commons Net 1.5

2008-03-02 Thread Rory Winston
Hi This is a release vote for Commons Net 1.5. This release fixes a few issues with TFTP errors, threading hangs, and a leap year date parsing bug. The RC deployment is here: http://people.apache.org/~rwinston/commons-net-1.5.0/site/ Binaries: http://people.apache.org/~rwinston/commons-net-1