Re: [VOTE] Release Commons NET 3.0` based on RC1

2011-05-13 Thread Phil Steitz
On 5/13/11 6:50 AM, Jörg Schaible wrote: > sebb wrote: > >> On 10 May 2011 15:13, sebb wrote: >>> This is a vote to release Apache Commons NET 3.0 based on RC1. >>> >>> [X] +1 release it >>> [ ] +0 go ahead I don't care >>> [ ] -1 no, do not release it because... >>> >>> tag: http://svn.apache.org

Re: [VOTE] Release Commons NET 3.0` based on RC1

2011-05-13 Thread Jörg Schaible
sebb wrote: > On 10 May 2011 15:13, sebb wrote: >> This is a vote to release Apache Commons NET 3.0 based on RC1. >> >> [X] +1 release it >> [ ] +0 go ahead I don't care >> [ ] -1 no, do not release it because... >> >> tag: http://svn.apache.org/repos/asf/commons/proper/net/tags/NET_3_0_RC1/ >> (

Re: [VOTE] Release Commons NET 3.0` based on RC1

2011-05-13 Thread sebb
On 10 May 2011 15:13, sebb wrote: > This is a vote to release Apache Commons NET 3.0 based on RC1. > > [X] +1 release it > [ ] +0 go ahead I don't care > [ ] -1 no, do not release it because... > > tag: http://svn.apache.org/repos/asf/commons/proper/net/tags/NET_3_0_RC1/ > (r1101459) > > site: htt

Re: [VOTE] Release Commons NET 3.0` based on RC1

2011-05-11 Thread Oliver Heger
Am 11.05.2011 22:26, schrieb sebb: On 11 May 2011 21:07, Oliver Heger wrote: Build works fine with Java 1.5 and 1.6 on Windows 7. Artifacts and site look good. Minor nit: When I build the site on my local machine I get 64 findbugs errors. These are not shown on the staged site. According to my

Re: [VOTE] Release Commons NET 3.0` based on RC1

2011-05-11 Thread sebb
On 11 May 2011 21:07, Oliver Heger wrote: > Build works fine with Java 1.5 and 1.6 on Windows 7. Artifacts and site look > good. > > Minor nit: When I build the site on my local machine I get 64 findbugs > errors. These are not shown on the staged site. According to my local > findbugs report 572

Re: [VOTE] Release Commons NET 3.0` based on RC1

2011-05-11 Thread Oliver Heger
Build works fine with Java 1.5 and 1.6 on Windows 7. Artifacts and site look good. Minor nit: When I build the site on my local machine I get 64 findbugs errors. These are not shown on the staged site. According to my local findbugs report 572 classes have been checked while the report on the

Re: [VOTE] Release Commons NET 3.0` based on RC1

2011-05-11 Thread sebb
On 11 May 2011 16:15, Gary Gregory wrote: > +1. > > If there is another RC, please add a code coverage report. > > Shouldn't code coverage be part of the parent POM? I suggest you file a JIRA so that does not get forgotten. > Gary > > Looks good on: > > Apache Maven 3.0.3 (r1075438; 2011-02-28 1

Re: [VOTE] Release Commons NET 3.0` based on RC1

2011-05-11 Thread Gary Gregory
+1. If there is another RC, please add a code coverage report. Shouldn't code coverage be part of the parent POM? Gary Looks good on: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500) Maven home: C:\Java\apache-maven-3.0.3\bin\.. Java version: 1.6.0_24, vendor: Sun Microsystems Inc. Java

Re: [VOTE] Release Commons NET 3.0` based on RC1

2011-05-11 Thread sebb
On 11 May 2011 10:02, Luc Maisonobe wrote: > Le 10/05/2011 16:13, sebb a écrit : >> >> This is a vote to release Apache Commons NET 3.0 based on RC1. >> >> [ ] +1 release it > > +1 > > I just noticed you didn't put yourself in the developers section of the pom > file. With all the work you have do

Re: [VOTE] Release Commons NET 3.0` based on RC1

2011-05-11 Thread Luc Maisonobe
Le 10/05/2011 16:13, sebb a écrit : This is a vote to release Apache Commons NET 3.0 based on RC1. [ ] +1 release it +1 I just noticed you didn't put yourself in the developers section of the pom file. With all the work you have done, you should get some credit. Luc [ ] +0 go ahead I don

[VOTE] Release Commons NET 3.0` based on RC1

2011-05-10 Thread sebb
This is a vote to release Apache Commons NET 3.0 based on RC1. [ ] +1 release it [ ] +0 go ahead I don't care [ ] -1 no, do not release it because... tag: http://svn.apache.org/repos/asf/commons/proper/net/tags/NET_3_0_RC1/ (r1101459) site: http://people.apache.org/~sebb/NET_3_0_RC1/ The Javado