Re: [VOTE] Release Commons Email 1.5 Based on RC1

2017-07-30 Thread sebb
On 30 July 2017 at 16:30, Matt Sicker wrote: > If the build is anything like Log4j's, it probably has a separate rat > config for the release profile than it does by default. If rat and Clirr are run as part of the the site build they use the report settings whereas 'mvn clirr:check' will use the

Re: [VOTE] Release Commons Email 1.5 Based on RC1

2017-07-30 Thread Matt Sicker
If the build is anything like Log4j's, it probably has a separate rat config for the release profile than it does by default. On 30 July 2017 at 10:27, Gary Gregory wrote: > I always run: > > mvn apache-rat:check > > And > > mvn clirr:check > > Gary > > On Jul 30, 2017 07:12, "Stefan Bodewig" w

Re: [VOTE] Release Commons Email 1.5 Based on RC1

2017-07-30 Thread Gary Gregory
I always run: mvn apache-rat:check And mvn clirr:check Gary On Jul 30, 2017 07:12, "Stefan Bodewig" wrote: > On 2017-07-30, Gary Gregory wrote: > > > Branding: The RELEASE-NOTES.txt file should start with "Apache Commons > > Email Package" instead of "Commons Email Package". > > I was under

Re: [VOTE] Release Commons Email 1.5 Based on RC1

2017-07-30 Thread Stefan Bodewig
On 2017-07-30, Amey Jadiye wrote: > I have fixed this, and yes reason was though those .eml files was added in > exclusion but in reports and not in build. > I have raised PR and tested it on my local. > https://github.com/apache/commons-email/pull/2 LGTM, but please allow us to get the release

Re: [VOTE] Release Commons Email 1.5 Based on RC1

2017-07-30 Thread Amey Jadiye
Hi, I have fixed this, and yes reason was though those .eml files was added in exclusion but in reports and not in build. I have raised PR and tested it on my local. https://github.com/apache/commons-email/pull/2 Regards, Amey On Sun, Jul 30, 2017 at 7:42 PM, Stefan Bodewig wrote: > On 2017-0

Re: [VOTE] Release Commons Email 1.5 Based on RC1

2017-07-30 Thread Stefan Bodewig
On 2017-07-30, Gary Gregory wrote: > Branding: The RELEASE-NOTES.txt file should start with "Apache Commons > Email Package" instead of "Commons Email Package". I was under the impression it had been generated by the commons-build plugin. Anyway, will fix it when I publish the release (no reason

Re: [VOTE] Release Commons Email 1.5 Based on RC1

2017-07-30 Thread Amey Jadiye
Checked RC1, and here is my +1 (non-binding). 1. Build and Tests looks good. 2. Clirr looks good. 3. Rat is not good as mentioned by gary, as they are test resources can be put to ignore list. 4. Findbug looks good. 5. There are 302 Checkstyle issues but they are non-blocker to release. 6. Hashes

Re: [VOTE] Release Commons Email 1.5 Based on RC1

2017-07-29 Thread Gary Gregory
+1 BUT: Branding: The RELEASE-NOTES.txt file should start with "Apache Commons Email Package" instead of "Commons Email Package". I would do away with the "Package" suffix, we just don't use that, if anything we say "Component" since the Apache Commons Projects is made up of Components. Building

Re: [VOTE] Release Commons Email 1.5 Based on RC1

2017-07-29 Thread Oliver Heger
Build works fine with Java 1.6 and 1.8. Artifacts and site look good. +1 Oliver Am 29.07.2017 um 16:24 schrieb Stefan Bodewig: > We have fixed quite a few bugs and added some significant enhancements > since Email 1.4 was released, so I would like to release Email 1.5. > > Email 1.5 RC1 is avai

[VOTE] Release Commons Email 1.5 Based on RC1

2017-07-29 Thread Stefan Bodewig
We have fixed quite a few bugs and added some significant enhancements since Email 1.4 was released, so I would like to release Email 1.5. Email 1.5 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/email/ (svn revision 20667) The tag is here: http://svn