Re: [VOTE] Release Commons Chain 1.2 based on RC2

2008-05-25 Thread Phil Steitz
That would be -1, on the bits in the RC. I will change to +1 if we can get the site build working on Unix or bundle the docs with the binary release. It looks like the necessary fix has been applied to fix the site build in trunk, so all that is needed is to roll a final RC. Phil On Sat, May 24

Re: [VOTE] Release Commons Chain 1.2 based on RC2

2008-05-24 Thread Paul Benedict
Phil, was there a vote attached to your suggestion? On Sat, May 24, 2008 at 10:45 PM, Phil Steitz <[EMAIL PROTECTED]> wrote: > On Thu, May 22, 2008 at 7:10 PM, Niall Pemberton > <[EMAIL PROTECTED]> wrote: > > On Thu, May 22, 2008 at 9:35 PM, Luc Maisonobe <[EMAIL PROTECTED]> > wrote: > >> A few c

Re: [VOTE] Release Commons Chain 1.2 based on RC2

2008-05-24 Thread Phil Steitz
On Thu, May 22, 2008 at 7:10 PM, Niall Pemberton <[EMAIL PROTECTED]> wrote: > On Thu, May 22, 2008 at 9:35 PM, Luc Maisonobe <[EMAIL PROTECTED]> wrote: >> A few comments on this release. >> >> Typo in the project description in the pom.xml file: replace >> "implmentation" with "implementation". >>

Re: [VOTE] Release Commons Chain 1.2 based on RC2

2008-05-24 Thread sebb
On 24/05/2008, Niall Pemberton <[EMAIL PROTECTED]> wrote: > On Sat, May 24, 2008 at 2:13 AM, sebb <[EMAIL PROTECTED]> wrote: > > On 24/05/2008, Niall Pemberton <[EMAIL PROTECTED]> wrote: > >> On Fri, May 23, 2008 at 11:56 PM, sebb <[EMAIL PROTECTED]> wrote: > >> > On 23/05/2008, Niall Pemberton

Re: [VOTE] Release Commons Chain 1.2 based on RC2

2008-05-23 Thread Niall Pemberton
On Sat, May 24, 2008 at 2:13 AM, sebb <[EMAIL PROTECTED]> wrote: > On 24/05/2008, Niall Pemberton <[EMAIL PROTECTED]> wrote: >> On Fri, May 23, 2008 at 11:56 PM, sebb <[EMAIL PROTECTED]> wrote: >> > On 23/05/2008, Niall Pemberton <[EMAIL PROTECTED]> wrote: >> >> On Fri, May 23, 2008 at 7:17 PM, s

Re: [VOTE] Release Commons Chain 1.2 based on RC2

2008-05-23 Thread Niall Pemberton
btw +1 from me Niall On Thu, May 22, 2008 at 3:47 AM, Niall Pemberton <[EMAIL PROTECTED]> wrote: > The main changes since RC1 are that the ant build now works on JDK 1.3 > and the Logging dependency has been upgraded to the latest 1.1.1 > > The artifacts are here: > http://people.apache.org/~nial

Re: [VOTE] Release Commons Chain 1.2 based on RC2

2008-05-23 Thread sebb
On 24/05/2008, Niall Pemberton <[EMAIL PROTECTED]> wrote: > On Fri, May 23, 2008 at 11:56 PM, sebb <[EMAIL PROTECTED]> wrote: > > On 23/05/2008, Niall Pemberton <[EMAIL PROTECTED]> wrote: > >> On Fri, May 23, 2008 at 7:17 PM, sebb <[EMAIL PROTECTED]> wrote: > >> > On 23/05/2008, Niall Pemberton

Re: [VOTE] Release Commons Chain 1.2 based on RC2

2008-05-23 Thread Niall Pemberton
On Fri, May 23, 2008 at 11:56 PM, sebb <[EMAIL PROTECTED]> wrote: > On 23/05/2008, Niall Pemberton <[EMAIL PROTECTED]> wrote: >> On Fri, May 23, 2008 at 7:17 PM, sebb <[EMAIL PROTECTED]> wrote: >> > On 23/05/2008, Niall Pemberton <[EMAIL PROTECTED]> wrote: >> >> On Fri, May 23, 2008 at 4:51 PM, s

Re: [VOTE] Release Commons Chain 1.2 based on RC2

2008-05-23 Thread sebb
On 23/05/2008, Niall Pemberton <[EMAIL PROTECTED]> wrote: > On Fri, May 23, 2008 at 7:17 PM, sebb <[EMAIL PROTECTED]> wrote: > > On 23/05/2008, Niall Pemberton <[EMAIL PROTECTED]> wrote: > >> On Fri, May 23, 2008 at 4:51 PM, sebb <[EMAIL PROTECTED]> wrote: > >> > On 23/05/2008, Niall Pemberton

Re: [VOTE] Release Commons Chain 1.2 based on RC2

2008-05-23 Thread Niall Pemberton
On Fri, May 23, 2008 at 7:17 PM, sebb <[EMAIL PROTECTED]> wrote: > On 23/05/2008, Niall Pemberton <[EMAIL PROTECTED]> wrote: >> On Fri, May 23, 2008 at 4:51 PM, sebb <[EMAIL PROTECTED]> wrote: >> > On 23/05/2008, Niall Pemberton <[EMAIL PROTECTED]> wrote: >> >> On Fri, May 23, 2008 at 3:31 PM, Lu

Re: [VOTE] Release Commons Chain 1.2 based on RC2

2008-05-23 Thread sebb
On 23/05/2008, Niall Pemberton <[EMAIL PROTECTED]> wrote: > On Fri, May 23, 2008 at 4:51 PM, sebb <[EMAIL PROTECTED]> wrote: > > On 23/05/2008, Niall Pemberton <[EMAIL PROTECTED]> wrote: > >> On Fri, May 23, 2008 at 3:31 PM, Luc Maisonobe <[EMAIL PROTECTED]> wrote: > >> > Niall Pemberton a écri

Re: [VOTE] Release Commons Chain 1.2 based on RC2

2008-05-23 Thread Niall Pemberton
On Fri, May 23, 2008 at 4:51 PM, sebb <[EMAIL PROTECTED]> wrote: > On 23/05/2008, Niall Pemberton <[EMAIL PROTECTED]> wrote: >> On Fri, May 23, 2008 at 3:31 PM, Luc Maisonobe <[EMAIL PROTECTED]> wrote: >> > Niall Pemberton a écrit : >> >> On Thu, May 22, 2008 at 9:35 PM, Luc Maisonobe <[EMAIL PRO

Re: [VOTE] Release Commons Chain 1.2 based on RC2

2008-05-23 Thread Luc Maisonobe
Niall Pemberton a écrit : > On Fri, May 23, 2008 at 3:31 PM, Luc Maisonobe <[EMAIL PROTECTED]> wrote: >> Niall Pemberton a écrit : >>> On Thu, May 22, 2008 at 9:35 PM, Luc Maisonobe <[EMAIL PROTECTED]> wrote: A few comments on this release. Typo in the project description in the pom.

Re: [VOTE] Release Commons Chain 1.2 based on RC2

2008-05-23 Thread sebb
On 23/05/2008, Niall Pemberton <[EMAIL PROTECTED]> wrote: > On Fri, May 23, 2008 at 3:31 PM, Luc Maisonobe <[EMAIL PROTECTED]> wrote: > > Niall Pemberton a écrit : > >> On Thu, May 22, 2008 at 9:35 PM, Luc Maisonobe <[EMAIL PROTECTED]> wrote: > >>> A few comments on this release. > >>> > >>> T

Re: [VOTE] Release Commons Chain 1.2 based on RC2

2008-05-23 Thread Niall Pemberton
On Fri, May 23, 2008 at 3:31 PM, Luc Maisonobe <[EMAIL PROTECTED]> wrote: > Niall Pemberton a écrit : >> On Thu, May 22, 2008 at 9:35 PM, Luc Maisonobe <[EMAIL PROTECTED]> wrote: >>> A few comments on this release. >>> >>> Typo in the project description in the pom.xml file: replace >>> "implmentat

Re: [VOTE] Release Commons Chain 1.2 based on RC2

2008-05-23 Thread Luc Maisonobe
Niall Pemberton a écrit : > On Thu, May 22, 2008 at 9:35 PM, Luc Maisonobe <[EMAIL PROTECTED]> wrote: >> A few comments on this release. >> >> Typo in the project description in the pom.xml file: replace >> "implmentation" with "implementation". >> >> Extracting files from the commons-chain-1.2-src

Re: [VOTE] Release Commons Chain 1.2 based on RC2

2008-05-23 Thread Emmanuel Bourg
Niall Pemberton a écrit : We don't have a CommandListener - but for ChainListener there is a working example webapp, which I added a while ago to be able to test the changes for CHAIN-35 (ticket for example webapp is CHAIN-36) The other class was ChainServlet, not CommandListener, sorry. Yo

Re: [VOTE] Release Commons Chain 1.2 based on RC2

2008-05-22 Thread Paul Benedict
+1 On Thu, May 22, 2008 at 9:21 PM, Niall Pemberton <[EMAIL PROTECTED]> wrote: > On Thu, May 22, 2008 at 10:43 PM, Emmanuel Bourg <[EMAIL PROTECTED]> > wrote: > > I'm a bit concerned by the low test coverage (64% lines and 55% branches > > according to Cobertura). Some classes like CommandListene

Re: [VOTE] Release Commons Chain 1.2 based on RC2

2008-05-22 Thread Niall Pemberton
On Thu, May 22, 2008 at 10:43 PM, Emmanuel Bourg <[EMAIL PROTECTED]> wrote: > I'm a bit concerned by the low test coverage (64% lines and 55% branches > according to Cobertura). Some classes like CommandListener and ChainListener > aren't tested at all. The faces package isn't tested but its classe

Re: [VOTE] Release Commons Chain 1.2 based on RC2

2008-05-22 Thread Niall Pemberton
On Thu, May 22, 2008 at 9:35 PM, Luc Maisonobe <[EMAIL PROTECTED]> wrote: > A few comments on this release. > > Typo in the project description in the pom.xml file: replace > "implmentation" with "implementation". > > Extracting files from the commons-chain-1.2-src.tar.gz archive in a > Linux box l

Re: [VOTE] Release Commons Chain 1.2 based on RC2

2008-05-22 Thread Emmanuel Bourg
I'm a bit concerned by the low test coverage (64% lines and 55% branches according to Cobertura). Some classes like CommandListener and ChainListener aren't tested at all. The faces package isn't tested but its classes seem more trivial. Emmanuel Bourg

Re: [VOTE] Release Commons Chain 1.2 based on RC2

2008-05-22 Thread Luc Maisonobe
A few comments on this release. Typo in the project description in the pom.xml file: replace "implmentation" with "implementation". Extracting files from the commons-chain-1.2-src.tar.gz archive in a Linux box leads to an all lower case file name for "license-header.txt", which leads to an error

Re: [VOTE] Release Commons Chain 1.2 based on RC2

2008-05-22 Thread Oliver Heger
+1 Oliver Niall Pemberton wrote: > The main changes since RC1 are that the ant build now works on JDK 1.3 > and the Logging dependency has been upgraded to the latest 1.1.1 > > The artifacts are here: > http://people.apache.org/~niallp/chain_1_2_RC2/ > > SVN Tag: > http://svn.apache.org/viewvc/

Re: [VOTE] Release Commons Chain 1.2 based on RC2

2008-05-22 Thread sebb
On 22/05/2008, Rahul Akolkar <[EMAIL PROTECTED]> wrote: > On 5/21/08, Niall Pemberton <[EMAIL PROTECTED]> wrote: > > > > > [X] +1 I support this release > > > [ ] +0 I am OK with this release > > [ ] -0 OK, but > > [ ] -1 I do not support this release > > > > > > Sigs, sum

Re: [VOTE] Release Commons Chain 1.2 based on RC2

2008-05-21 Thread Rahul Akolkar
On 5/21/08, Niall Pemberton <[EMAIL PROTECTED]> wrote: > > [X] +1 I support this release > [ ] +0 I am OK with this release > [ ] -0 OK, but > [ ] -1 I do not support this release > Sigs, sums, manifests I checked are good. Tried all builds on JDK 1.6. -Rahul -

[VOTE] Release Commons Chain 1.2 based on RC2

2008-05-21 Thread Niall Pemberton
The main changes since RC1 are that the ant build now works on JDK 1.3 and the Logging dependency has been upgraded to the latest 1.1.1 The artifacts are here: http://people.apache.org/~niallp/chain_1_2_RC2/ SVN Tag: http://svn.apache.org/viewvc/commons/proper/chain/tags/CHAIN_1_2_RC2/ Site: htt