Re: [VOTE] Release Apache Commons Weaver 1.0 based on RC1

2014-02-20 Thread Matt Benson
On Feb 20, 2014 10:11 PM, "Gary Gregory" wrote: > > I would also like to see reports for FindBugs and PMD. Will do. > Also: use > commons-parent 33 to pick up the new skin. > Has been deployed and will of course be part of the next RC site. Matt > Gary > > > On Thu, Feb 20, 2014 at 12:33 PM, M

Re: [VOTE] Release Apache Commons Weaver 1.0 based on RC1

2014-02-20 Thread Matt Benson
On Feb 20, 2014 10:09 PM, "Gary Gregory" wrote: > > On Thu, Feb 20, 2014 at 12:33 PM, Mark Struberg wrote: > > > +1 > > > > >The poms don't include any groupId definitions. > > > > Not needed and sometimes even a source of problems. If you do not need to > > write something than adding it only ra

Re: [VOTE] Release Apache Commons Weaver 1.0 based on RC1

2014-02-20 Thread Gary Gregory
I would also like to see reports for FindBugs and PMD. Also: use commons-parent 33 to pick up the new skin. Gary On Thu, Feb 20, 2014 at 12:33 PM, Mark Struberg wrote: > +1 > > >The poms don't include any groupId definitions. > > Not needed and sometimes even a source of problems. If you do no

Re: [VOTE] Release Apache Commons Weaver 1.0 based on RC1

2014-02-20 Thread Gary Gregory
On Thu, Feb 20, 2014 at 12:33 PM, Mark Struberg wrote: > +1 > > >The poms don't include any groupId definitions. > > Not needed and sometimes even a source of problems. If you do not need to > write something than adding it only raises the chance it gets wrong. > > > > > - The jar artifacts conta

Re: [VOTE] Release Apache Commons Weaver 1.0 based on RC1

2014-02-20 Thread Mark Struberg
+1 >The poms don't include any groupId definitions. Not needed and sometimes even a source of problems. If you do not need to write something than adding it only raises the chance it gets wrong. > - The jar artifacts contain LICENSE and NOTICE without the .txt extension. That's perfectly fine

Re: [VOTE] Release Apache Commons Weaver 1.0 based on RC1

2014-02-19 Thread Matt Benson
On Wed, Feb 19, 2014 at 4:50 AM, sebb wrote: > On 19 February 2014 05:52, Matt Benson wrote: > > On Tue, Feb 18, 2014 at 8:59 PM, sebb wrote: > >> > >> On 19 February 2014 02:45, Matt Benson wrote: > >> > On Tue, Feb 18, 2014 at 8:25 PM, sebb wrote: > >> >> > >> >> On 19 February 2014 02:10,

Re: [VOTE] Release Apache Commons Weaver 1.0 based on RC1

2014-02-19 Thread sebb
On 19 February 2014 05:52, Matt Benson wrote: > On Tue, Feb 18, 2014 at 8:59 PM, sebb wrote: >> >> On 19 February 2014 02:45, Matt Benson wrote: >> > On Tue, Feb 18, 2014 at 8:25 PM, sebb wrote: >> >> >> >> On 19 February 2014 02:10, Matt Benson wrote: >> >> > On Tue, Feb 18, 2014 at 7:28 PM,

Re: [VOTE] Release Apache Commons Weaver 1.0 based on RC1

2014-02-18 Thread Matt Benson
On Tue, Feb 18, 2014 at 8:59 PM, sebb wrote: > On 19 February 2014 02:45, Matt Benson wrote: > > On Tue, Feb 18, 2014 at 8:25 PM, sebb wrote: > >> > >> On 19 February 2014 02:10, Matt Benson wrote: > >> > On Tue, Feb 18, 2014 at 7:28 PM, sebb wrote: > >> >> > >> >> On 19 February 2014 00:29,

Re: [VOTE] Release Apache Commons Weaver 1.0 based on RC1

2014-02-18 Thread sebb
On 19 February 2014 02:45, Matt Benson wrote: > On Tue, Feb 18, 2014 at 8:25 PM, sebb wrote: >> >> On 19 February 2014 02:10, Matt Benson wrote: >> > On Tue, Feb 18, 2014 at 7:28 PM, sebb wrote: >> >> >> >> On 19 February 2014 00:29, Matt Benson wrote: >> >> > On Thu, Feb 13, 2014 at 6:42 PM,

Re: [VOTE] Release Apache Commons Weaver 1.0 based on RC1

2014-02-18 Thread Matt Benson
On Tue, Feb 18, 2014 at 8:25 PM, sebb wrote: > On 19 February 2014 02:10, Matt Benson wrote: > > On Tue, Feb 18, 2014 at 7:28 PM, sebb wrote: > >> > >> On 19 February 2014 00:29, Matt Benson wrote: > >> > On Thu, Feb 13, 2014 at 6:42 PM, sebb wrote: > >> >> > >> >> On 14 February 2014 00:35,

Re: [VOTE] Release Apache Commons Weaver 1.0 based on RC1

2014-02-18 Thread sebb
On 19 February 2014 02:10, Matt Benson wrote: > On Tue, Feb 18, 2014 at 7:28 PM, sebb wrote: >> >> On 19 February 2014 00:29, Matt Benson wrote: >> > On Thu, Feb 13, 2014 at 6:42 PM, sebb wrote: >> >> >> >> On 14 February 2014 00:35, Matt Benson wrote: >> >> > Seb, can you verify whether you c

Re: [VOTE] Release Apache Commons Weaver 1.0 based on RC1

2014-02-18 Thread Matt Benson
On Tue, Feb 18, 2014 at 7:28 PM, sebb wrote: > On 19 February 2014 00:29, Matt Benson wrote: > > On Thu, Feb 13, 2014 at 6:42 PM, sebb wrote: > >> > >> On 14 February 2014 00:35, Matt Benson wrote: > >> > Seb, can you verify whether you can do `mvn install` from a fresh > >> > checkout? > >> >

Re: [VOTE] Release Apache Commons Weaver 1.0 based on RC1

2014-02-18 Thread sebb
On 19 February 2014 00:29, Matt Benson wrote: > On Thu, Feb 13, 2014 at 6:42 PM, sebb wrote: >> >> On 14 February 2014 00:35, Matt Benson wrote: >> > Seb, can you verify whether you can do `mvn install` from a fresh >> > checkout? >> > This is AFAIK typically required with multimodule Maven proj

Re: [VOTE] Release Apache Commons Weaver 1.0 based on RC1

2014-02-18 Thread Matt Benson
On Thu, Feb 13, 2014 at 6:42 PM, sebb wrote: > On 14 February 2014 00:35, Matt Benson wrote: > > Seb, can you verify whether you can do `mvn install` from a fresh > checkout? > > This is AFAIK typically required with multimodule Maven projects: as one > > module is built, it is installed so that

Re: [VOTE] Release Apache Commons Weaver 1.0 based on RC1

2014-02-13 Thread Bernd Eckenfels
Am Fri, 14 Feb 2014 00:42:48 + schrieb sebb : > I have checked the RAT multi-module build [1] and that is able to run > clean and compile quite happily. I guess the problem with the Weaver parent POM is the dependency of the checkstyle plugin to the waver buildtools (just guessing). Generally

Re: [VOTE] Release Apache Commons Weaver 1.0 based on RC1

2014-02-13 Thread sebb
On 14 February 2014 00:35, Matt Benson wrote: > Seb, can you verify whether you can do `mvn install` from a fresh checkout? > This is AFAIK typically required with multimodule Maven projects: as one > module is built, it is installed so that the next module can depend on it. I have checked the RA

Re: [VOTE] Release Apache Commons Weaver 1.0 based on RC1

2014-02-13 Thread Matt Benson
Seb, can you verify whether you can do `mvn install` from a fresh checkout? This is AFAIK typically required with multimodule Maven projects: as one module is built, it is installed so that the next module can depend on it. Thanks, Matt On Wed, Feb 12, 2014 at 5:46 PM, sebb wrote: > BTW, I'm g

Re: [VOTE] Release Apache Commons Weaver 1.0 based on RC1

2014-02-12 Thread sebb
BTW, I'm getting some odd errors on trunk. For example, just tried "mvn clean" and it fails with = [ERROR] BUILD FAILURE [INFO] [INFO] A required plugin was not found: Plugin could not be found -

VOTE cancelled WAS [VOTE] Release Apache Commons Weaver 1.0 based on RC1

2014-02-12 Thread Matt Benson
In addition to the problems (other than the website, which, after all, can be improved independently of releases) identified by Oliver, I have discovered a problem that had crept into the test security policy used by the example and ant/test modules to show that the privilizer is doing its job. I a

Re: [VOTE] Release Apache Commons Weaver 1.0 based on RC1

2014-02-12 Thread sebb
On 12 February 2014 23:22, Matt Benson wrote: > The AL header is in > https://svn.apache.org/repos/asf/commons/proper/commons-parent/trunk/src/changes/release-notes.vm, > from which the release notes were generated. The header lines in the vm file are comments that are not supposed to be copied t

Re: [VOTE] Release Apache Commons Weaver 1.0 based on RC1

2014-02-12 Thread Matt Benson
The AL header is in https://svn.apache.org/repos/asf/commons/proper/commons-parent/trunk/src/changes/release-notes.vm, from which the release notes were generated. Interestingly, m2eclipse defaults to the behavior that redundant groupId/version are warning-worthy. Browsing http://svn.apache.org/rep

Re: [VOTE] Release Apache Commons Weaver 1.0 based on RC1

2014-02-12 Thread sebb
On 12 February 2014 02:20, Matt Benson wrote: > I would like to make the inaugural release of the [weaver] component. > > Apache Commons Weaver 1.0 RC1 is available for review at: > https://dist.apache.org/repos/dist/dev/commons/weaver/ (r4368). > > Maven artifacts are at: > https://repository

Re: [VOTE] Release Apache Commons Weaver 1.0 based on RC1

2014-02-12 Thread Oliver Heger
Build works fine with JDK 1.7 on Windows 8.1. Artifacts and site look good. I noticed some problems: - The names of the distributions files contain a -dist suffix, and they also deflate in a directory named -dist. This is not typical for other commons components. - The binary distribution does not

Re: [VOTE] Release Apache Commons Weaver 1.0 based on RC1

2014-02-11 Thread Romain Manni-Bucau
+1 Le mercredi 12 février 2014, Matt Benson a écrit : > I would like to make the inaugural release of the [weaver] component. > > Apache Commons Weaver 1.0 RC1 is available for review at: > https://dist.apache.org/repos/dist/dev/commons/weaver/ (r4368). > > Maven artifacts are at: > https://rep

[VOTE] Release Apache Commons Weaver 1.0 based on RC1

2014-02-11 Thread Matt Benson
I would like to make the inaugural release of the [weaver] component. Apache Commons Weaver 1.0 RC1 is available for review at: https://dist.apache.org/repos/dist/dev/commons/weaver/ (r4368). Maven artifacts are at: https://repository.apache.org/content/repositories/orgapachecommons-1007/. T