Re: [VALIDATOR] Working on the TLD list (Was: Re: [CANCEL][VOTE] Release Apache Commons Validator 1.4.1 based on RC2)

2015-01-04 Thread Benedikt Ritter
2015-01-03 20:26 GMT+01:00 sebb : > I've just noticed VALIDATOR-297, which points out that the punycode > versions of the TLDs are not regarded as valid. > > I just added the Unicode versions, but perhaps I should have added the > punycode ones as well or instead? > > DomainVal. does not currently

Re: [VALIDATOR] Working on the TLD list (Was: Re: [CANCEL][VOTE] Release Apache Commons Validator 1.4.1 based on RC2)

2015-01-04 Thread Benedikt Ritter
2015-01-03 19:32 GMT+01:00 sebb : > On 3 January 2015 at 12:34, Benedikt Ritter wrote: > > Hello Sebb, > > > > 2015-01-03 4:35 GMT+01:00 sebb : > > > >> I've made quite a bit of progress. > >> > >> However the IANA text file merges all the TLDs into one file - there > >> is no indication of wheth

Re: [VALIDATOR] Working on the TLD list (Was: Re: [CANCEL][VOTE] Release Apache Commons Validator 1.4.1 based on RC2)

2015-01-03 Thread sebb
I've just noticed VALIDATOR-297, which points out that the punycode versions of the TLDs are not regarded as valid. I just added the Unicode versions, but perhaps I should have added the punycode ones as well or instead? DomainVal. does not currently support Unicode path segments (VALIDATOR-235).

Re: [VALIDATOR] Working on the TLD list (Was: Re: [CANCEL][VOTE] Release Apache Commons Validator 1.4.1 based on RC2)

2015-01-03 Thread sebb
On 3 January 2015 at 12:34, Benedikt Ritter wrote: > Hello Sebb, > > 2015-01-03 4:35 GMT+01:00 sebb : > >> I've made quite a bit of progress. >> >> However the IANA text file merges all the TLDs into one file - there >> is no indication of whether the TLD is a country code or not. >> This does not

[VALIDATOR] Working on the TLD list (Was: Re: [CANCEL][VOTE] Release Apache Commons Validator 1.4.1 based on RC2)

2015-01-03 Thread Benedikt Ritter
Hello Sebb, 2015-01-03 4:35 GMT+01:00 sebb : > I've made quite a bit of progress. > > However the IANA text file merges all the TLDs into one file - there > is no indication of whether the TLD is a country code or not. > This does not matter for ASCII codes, because they are easy to recognise. >

Re: [CANCEL][VOTE] Release Apache Commons Validator 1.4.1 based on RC2

2015-01-02 Thread sebb
I've made quite a bit of progress. However the IANA text file merges all the TLDs into one file - there is no indication of whether the TLD is a country code or not. This does not matter for ASCII codes, because they are easy to recognise. Unfortunately it looks as though the only way to distingui

[CANCEL][VOTE] Release Apache Commons Validator 1.4.1 based on RC2

2015-01-02 Thread Benedikt Ritter
Hi, this vote in canceled to fix the problems discovered by sebb. I will waint until the XN-- entries are added before I roll out a new RC. Thanks! Benedikt 2015-01-01 19:02 GMT+01:00 Benedikt Ritter : > Hi all, > > we have fixed the issues which where found in RC1 so I'd like to call a > new v

Re: [VOTE] Release Apache Commons Validator 1.4.1 based on RC2

2015-01-02 Thread sebb
-1 Definitely need to respin the release. I've just discovered that InetAddressValidator.isValidInet4Address calls String.isEmpty() which is Java 1.6+ Need to do more checks on Java 1.4 compatibility; there may be other such issues. Note: I am looking at adding XN-- entries to the TLD list sho

Re: [VOTE] Release Apache Commons Validator 1.4.1 based on RC2

2015-01-02 Thread Gary Gregory
IMO we should fix this now for 1.4.1, isn't the fix already in trunk? We can then update to Java 5 for a 1.5 release. Gary On Fri, Jan 2, 2015 at 3:44 AM, Benedikt Ritter wrote: > Hm, not sure how serious this is. Let's see what others think. My feeling > is that we can fix that in 1.4.2 or 1.5

Re: [VOTE] Release Apache Commons Validator 1.4.1 based on RC2

2015-01-02 Thread Benedikt Ritter
Hm, not sure how serious this is. Let's see what others think. My feeling is that we can fix that in 1.4.2 or 1.5 Benedikt 2015-01-02 3:06 GMT+01:00 sebb : > Sorry, the mistake is mine entirely. > The code to download the file was wrong - it was not checking the > length of the buffer when writi

Re: [VOTE] Release Apache Commons Validator 1.4.1 based on RC2

2015-01-01 Thread sebb
Sorry, the mistake is mine entirely. The code to download the file was wrong - it was not checking the length of the buffer when writing the output. The 9C entry is obviously wrong, as is the code in DomainValidatorTest. On 2 January 2015 at 00:06, sebb wrote: > Just noticed that the IANA TLD li

Re: [VOTE] Release Apache Commons Validator 1.4.1 based on RC2

2015-01-01 Thread sebb
Just noticed that the IANA TLD list has changed. This should not matter, except that it has dropped "9C" and replaced it by -3DS443G XN--3E0B707E XN--45BRJ9C Looks like the "9C" entry was a mistake. Unfortunately that is now included in the internal database. I don't know how serious an issue

[VOTE] Release Apache Commons Validator 1.4.1 based on RC2

2015-01-01 Thread Benedikt Ritter
Hi all, we have fixed the issues which where found in RC1 so I'd like to call a new vote to release Apache Commons Validator based on RC2. Changes from RC1: - [VALIDATOR-307] - isValid checks if the given address is only IPV4 address and not IPV6 - [VALIDATOR-347] - toLowerCase() method is Locale