Re: [VOTE] Release Apache Commons Validator 1.4.0 Based on RC

2012-02-01 Thread Jörg Schaible
Simone Tripodi wrote: > Hi all again mates :) > > after the failing RC1, I open the VOTE for Apache Commons validator > 1.4.0 based on RC2. Follow details: > > Tag: > > https://svn.apache.org/repos/asf/commons/proper/validator/tags/VALIDATOR_1_4_0_RC2/ > > Release notes: > > http://people.ap

Re: [VOTE] Release Apache Commons Validator 1.4.0 Based on RC

2012-02-01 Thread Luc Maisonobe
Le 01/02/2012 13:44, Nick Burch a écrit : > On Wed, 1 Feb 2012, Simone Tripodi wrote: >> thanks for reviewing! I am personally worried to fix the findbugs >> errors and break the backward compatibility, I'll ask Nick's help! > > I'm not sure how serious those warnings are, and I'm pretty sure that

Re: [VOTE] Release Apache Commons Validator 1.4.0 Based on RC

2012-02-01 Thread Nick Burch
On Wed, 1 Feb 2012, Simone Tripodi wrote: thanks for reviewing! I am personally worried to fix the findbugs errors and break the backward compatibility, I'll ask Nick's help! I'm not sure how serious those warnings are, and I'm pretty sure that those problems were present in 1.3, so I think th

Re: [VOTE] Release Apache Commons Validator 1.4.0 Based on RC

2012-02-01 Thread Simone Tripodi
Salut Luc, thanks for reviewing! I am personally worried to fix the findbugs errors and break the backward compatibility, I'll ask Nick's help! Anyway, no issues from my side to cut out an improved RC!! A trés bientôt! -Simo http://people.apache.org/~simonetripodi/ http://simonetripodi.livejour

Re: [VOTE] Release Apache Commons Validator 1.4.0 Based on RC

2012-02-01 Thread Luc Maisonobe
Le 30/01/2012 19:18, Gary Gregory a écrit : > -0: > > The text in RELEASE-NOTES.txt contradicts itself: > > First we say: > " > IMPORTANT NOTES > > > BREAKING CHANGES: > > * NONE. > " > > Then at the end we say: > > " > OTHER NOTES > > > Users should be aware o

Re: [VOTE] Release Apache Commons Validator 1.4.0 Based on RC

2012-01-30 Thread Gary Gregory
-0: The text in RELEASE-NOTES.txt contradicts itself: First we say: " IMPORTANT NOTES BREAKING CHANGES: * NONE. " Then at the end we say: " OTHER NOTES Users should be aware of the following potential issues with migration: * The protected method validator.Em

Re: [VOTE] Release Apache Commons Validator 1.4.0 Based on RC

2012-01-30 Thread Simone Tripodi
that is my +1. @Nick: I've been using my GPG key for many releases, so I agree that should not be blocking - otherwise we should invalidate older releases :P Thanks anyway for the hint! Next ApacheCon should be in Germany IUUC - that would be the right chance for me to get the required signature!

Re: [VOTE] Release Apache Commons Validator 1.4.0 Based on RC

2012-01-30 Thread Nick Burch
On Sun, 29 Jan 2012, Simone Tripodi wrote: after the failing RC1, I open the VOTE for Apache Commons validator 1.4.0 based on RC2. Follow details: Looks fine to me, I'm +1 My only comment is that it doesn't look like your GPG key has been signed by anyone. I don't think that's a blocker, but

Re: [VOTE] Release Apache Commons Validator 1.4.0 Based on RC

2012-01-30 Thread Nick Burch
On Sun, 29 Jan 2012, Oliver Heger wrote: Looks good now, my concerns have been addressed. The only minor nit I found is that the ant build is not able to execute the tests. It fails with test.main: [echo] Running main tests ... [java] Class not found "org.apache.commons.validator.Validat

Re: [VOTE] Release Apache Commons Validator 1.4.0 Based on RC

2012-01-29 Thread Oliver Heger
+1 Looks good now, my concerns have been addressed. The only minor nit I found is that the ant build is not able to execute the tests. It fails with test.main: [echo] Running main tests ... [java] Class not found "org.apache.commons.validator.ValidatorTestSuite" But this is not blo

[VOTE] Release Apache Commons Validator 1.4.0 Based on RC

2012-01-29 Thread Simone Tripodi
Hi all again mates :) after the failing RC1, I open the VOTE for Apache Commons validator 1.4.0 based on RC2. Follow details: Tag:     https://svn.apache.org/repos/asf/commons/proper/validator/tags/VALIDATOR_1_4_0_RC2/ Release notes:    http://people.apache.org/builds/commons/validator/1.4.0/R