[CANCEL][VOTE] Release Apache Commons Text 1.5 based on RC1

2018-09-29 Thread Rob Tompkins
I am cancelling this vote to pull in some spot bugs errors. -Rob > On Sep 28, 2018, at 2:37 PM, Rob Tompkins wrote: > > We have fixed quite a few bugs and added some significant enhancements since > Apache Commons Text 1.4 was released, so I would like to release Apache > Commons Text 1.5. >

Re: [VOTE] Release Apache Commons Text 1.5 based on RC1

2018-09-29 Thread Gary Gregory
On Sat, Sep 29, 2018 at 6:57 PM Rob Tompkins wrote: > > > > On Sep 29, 2018, at 8:42 PM, Gary Gregory > wrote: > > > >> On Sat, Sep 29, 2018 at 6:24 AM Rob Tompkins > wrote: > >> > >> > >> > >>> On Sep 28, 2018, at 9:36 PM, Gary Gregory > >> wrote: > >>> > >>> Hi, > >>> > >>> It looks like I d

Re: [VOTE] Release Apache Commons Text 1.5 based on RC1

2018-09-29 Thread Rob Tompkins
> On Sep 29, 2018, at 8:42 PM, Gary Gregory wrote: > >> On Sat, Sep 29, 2018 at 6:24 AM Rob Tompkins wrote: >> >> >> >>> On Sep 28, 2018, at 9:36 PM, Gary Gregory >> wrote: >>> >>> Hi, >>> >>> It looks like I did not spot what Spotbugs found :-( >>> >>> >> https://dist.apache.org/repo

Re: [VOTE] Release Apache Commons Text 1.5 based on RC1

2018-09-29 Thread Gary Gregory
On Sat, Sep 29, 2018 at 6:24 AM Rob Tompkins wrote: > > > > On Sep 28, 2018, at 9:36 PM, Gary Gregory > wrote: > > > > Hi, > > > > It looks like I did not spot what Spotbugs found :-( > > > > > https://dist.apache.org/repos/dist/dev/commons/text/1.5-RC1/site/spotbugs.html > > > > > > The only re

Re: [VOTE] Release Apache Commons Text 1.5 based on RC1

2018-09-29 Thread Rob Tompkins
> On Sep 28, 2018, at 9:36 PM, Gary Gregory wrote: > > Hi, > > It looks like I did not spot what Spotbugs found :-( > > https://dist.apache.org/repos/dist/dev/commons/text/1.5-RC1/site/spotbugs.html > > > The only real worrisome one IMO is: > "org.apache.commons.text.lookup.PropertiesStrin

Re: [VOTE] Release Apache Commons Text 1.5 based on RC1

2018-09-29 Thread Pascal Schumacher
+1 Am 29.09.2018 um 03:36 schrieb Gary Gregory: Hi, It looks like I did not spot what Spotbugs found :-( https://dist.apache.org/repos/dist/dev/commons/text/1.5-RC1/site/spotbugs.html The only real worrisome one IMO is: "org.apache.commons.text.lookup.PropertiesStringLookup.lookup(String) ma

Re: [VOTE] Release Apache Commons Text 1.5 based on RC1

2018-09-28 Thread Gary Gregory
Hi, It looks like I did not spot what Spotbugs found :-( https://dist.apache.org/repos/dist/dev/commons/text/1.5-RC1/site/spotbugs.html The only real worrisome one IMO is: "org.apache.commons.text.lookup.PropertiesStringLookup.lookup(String) may fail to close stream" If we fix one, we might as

Hashes in VOTES (was: [VOTE] Release Apache Commons Text 1.5 based on RC1)

2018-09-28 Thread sebb
On Fri, 28 Sep 2018 at 19:37, Rob Tompkins wrote: The standard VOTE email (example below) has become rather long. In particular I don't think *all* the hashes should to be quoted in the mail. The point of having the hashes in the VOTE mail is to be able to tie the published artifacts back to the

[VOTE] Release Apache Commons Text 1.5 based on RC1

2018-09-28 Thread Rob Tompkins
We have fixed quite a few bugs and added some significant enhancements since Apache Commons Text 1.4 was released, so I would like to release Apache Commons Text 1.5. Apache Commons Text 1.5 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/text/1.5-RC1 (svn re