Re: [VOTE] Release Apache Commons Pool 2.6.2 based on RC1

2019-04-10 Thread Bruno P. Kinoshita
[x] +1 Release these artifacts Building passing with `mvn clean install`, then `mvn site` (failed when put together, as site couldn't find the SNAPSHOT jar I think. Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T20:58:13+13:00) Maven home: /opt/apache-maven-3.5.2 Java

Re: [VOTE] Release Apache Commons Pool 2.6.2 based on RC1

2019-04-10 Thread Gary Gregory
Pretty please for more reviews? Gary On Tue, Apr 9, 2019 at 9:36 AM Gary Gregory wrote: > May I get more reviews please? > > Thank you, > Gary > > On Mon, Apr 8, 2019 at 10:15 AM Gary Gregory > wrote: > >> Looking for VOTEs... >> >> Gary >> >> On Sat, Apr 6, 2019 at 12:24 PM Gary Gregory >> w

Re: [VOTE] Release Apache Commons Pool 2.6.2 based on RC1

2019-04-09 Thread Gary Gregory
May I get more reviews please? Thank you, Gary On Mon, Apr 8, 2019 at 10:15 AM Gary Gregory wrote: > Looking for VOTEs... > > Gary > > On Sat, Apr 6, 2019 at 12:24 PM Gary Gregory > wrote: > >> Hi Sebb, >> >> Thank you for your review. Some comments below. >> >> On Sat, Apr 6, 2019 at 5:00 AM

Re: [VOTE] Release Apache Commons Pool 2.6.2 based on RC1

2019-04-08 Thread Gary Gregory
Thank Rob. Here is my +1. Gary On Mon, Apr 8, 2019, 13:30 Rob Tompkins wrote: > +1 > > Build with java 8 and java 11 ok ‘mvn clean package site’ > > all reports look ok (some static analysis nits). > > jacoco doesn’t exist in the reports on the site (nit) > > signatures all check out. > > -Rob

Re: [VOTE] Release Apache Commons Pool 2.6.2 based on RC1

2019-04-08 Thread Rob Tompkins
+1 Build with java 8 and java 11 ok ‘mvn clean package site’ all reports look ok (some static analysis nits). jacoco doesn’t exist in the reports on the site (nit) signatures all check out. -Rob > On Apr 5, 2019, at 10:15 PM, Gary Gregory wrote: > > We have fixed a few bugs since Apache Com

Re: [VOTE] Release Apache Commons Pool 2.6.2 based on RC1

2019-04-08 Thread Rob Tompkins
Looking. > On Apr 8, 2019, at 10:15 AM, Gary Gregory wrote: > > Looking for VOTEs... > > Gary > > On Sat, Apr 6, 2019 at 12:24 PM Gary Gregory wrote: > >> Hi Sebb, >> >> Thank you for your review. Some comments below. >> >> On Sat, Apr 6, 2019 at 5:00 AM sebb wrote: >> >>> On Sat, 6 Apr

Re: [VOTE] Release Apache Commons Pool 2.6.2 based on RC1

2019-04-08 Thread Gary Gregory
Looking for VOTEs... Gary On Sat, Apr 6, 2019 at 12:24 PM Gary Gregory wrote: > Hi Sebb, > > Thank you for your review. Some comments below. > > On Sat, Apr 6, 2019 at 5:00 AM sebb wrote: > >> On Sat, 6 Apr 2019 at 03:15, Gary Gregory wrote: >> > >> > We have fixed a few bugs since Apache Com

Re: [release-plugin] sha’s (Was: Re: [VOTE] Release Apache Commons Pool 2.6.2 based on RC1)

2019-04-07 Thread sebb
On Sun, 7 Apr 2019 at 11:25, Rob Tompkins wrote: > > > > > On Apr 7, 2019, at 5:52 AM, sebb wrote: > > > >> On Sat, 6 Apr 2019 at 17:59, Gary Gregory wrote: > >> > >>> On Sat, Apr 6, 2019 at 12:48 PM Rob Tompkins wrote: > >>> > >>> > >>> > On Apr 6, 2019, at 12:24 PM, Gary Gregory wrote:

Re: [release-plugin] sha’s (Was: Re: [VOTE] Release Apache Commons Pool 2.6.2 based on RC1)

2019-04-07 Thread Rob Tompkins
> On Apr 7, 2019, at 5:52 AM, sebb wrote: > >> On Sat, 6 Apr 2019 at 17:59, Gary Gregory wrote: >> >>> On Sat, Apr 6, 2019 at 12:48 PM Rob Tompkins wrote: >>> >>> >>> On Apr 6, 2019, at 12:24 PM, Gary Gregory wrote: Hi Sebb, Thank you for your review. Some com

Re: [release-plugin] sha’s (Was: Re: [VOTE] Release Apache Commons Pool 2.6.2 based on RC1)

2019-04-07 Thread sebb
On Sat, 6 Apr 2019 at 17:59, Gary Gregory wrote: > > On Sat, Apr 6, 2019 at 12:48 PM Rob Tompkins wrote: >> >> >> >> > On Apr 6, 2019, at 12:24 PM, Gary Gregory wrote: >> > >> > Hi Sebb, >> > >> > Thank you for your review. Some comments below. >> > >> >> On Sat, Apr 6, 2019 at 5:00 AM sebb wro

Re: [release-plugin] sha’s (Was: Re: [VOTE] Release Apache Commons Pool 2.6.2 based on RC1)

2019-04-06 Thread Gary Gregory
On Sat, Apr 6, 2019 at 12:48 PM Rob Tompkins wrote: > > > > On Apr 6, 2019, at 12:24 PM, Gary Gregory > wrote: > > > > Hi Sebb, > > > > Thank you for your review. Some comments below. > > > >> On Sat, Apr 6, 2019 at 5:00 AM sebb wrote: > >> > >>> On Sat, 6 Apr 2019 at 03:15, Gary Gregory wrote

[release-plugin] sha’s (Was: Re: [VOTE] Release Apache Commons Pool 2.6.2 based on RC1)

2019-04-06 Thread Rob Tompkins
> On Apr 6, 2019, at 12:24 PM, Gary Gregory wrote: > > Hi Sebb, > > Thank you for your review. Some comments below. > >> On Sat, Apr 6, 2019 at 5:00 AM sebb wrote: >> >>> On Sat, 6 Apr 2019 at 03:15, Gary Gregory wrote: >>> >>> We have fixed a few bugs since Apache Commons Pool 2.6.1 was

Re: [VOTE] Release Apache Commons Pool 2.6.2 based on RC1

2019-04-06 Thread Gary Gregory
Hi Sebb, Thank you for your review. Some comments below. On Sat, Apr 6, 2019 at 5:00 AM sebb wrote: > On Sat, 6 Apr 2019 at 03:15, Gary Gregory wrote: > > > > We have fixed a few bugs since Apache Commons Pool 2.6.1 was released, > so I > > would like to release Apache Commons Pool 2.6.2. > >

Re: [VOTE] Release Apache Commons Pool 2.6.2 based on RC1

2019-04-06 Thread sebb
On Sat, 6 Apr 2019 at 03:15, Gary Gregory wrote: > > We have fixed a few bugs since Apache Commons Pool 2.6.1 was released, so I > would like to release Apache Commons Pool 2.6.2. > > Apache Commons Pool 2.6.2 RC1 is available for review here: > https://dist.apache.org/repos/dist/dev/commons/p

[VOTE] Release Apache Commons Pool 2.6.2 based on RC1

2019-04-05 Thread Gary Gregory
We have fixed a few bugs since Apache Commons Pool 2.6.1 was released, so I would like to release Apache Commons Pool 2.6.2. Apache Commons Pool 2.6.2 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/pool/2.6.2-RC1 (svn revision 33480) The Git tag commons-pool-