Re: [VOTE] Release Apache Commons Pool 2.2 RC2 as 2.2

2014-02-23 Thread Gary Gregory
On Sun, Feb 23, 2014 at 2:04 PM, Mark Thomas wrote: > On 23/02/2014 15:15, sebb wrote: > > On 23 February 2014 14:24, Mark Thomas wrote: > >> On 23/02/2014 00:10, Jörg Schaible wrote: > >> > >>> However, the manifest contains the following line: > >>> > >>> Implementation-Build: UNKNOWN_BRANCH@r

Re: [VOTE] Release Apache Commons Pool 2.2 RC2 as 2.2

2014-02-23 Thread Mark Thomas
On 23/02/2014 15:15, sebb wrote: > On 23 February 2014 14:24, Mark Thomas wrote: >> On 23/02/2014 00:10, Jörg Schaible wrote: >> >>> However, the manifest contains the following line: >>> >>> Implementation-Build: UNKNOWN_BRANCH@r??; 2014-02-21 14:40:13+ >>> >>> Maybe we should stop adding

Re: [VOTE] Release Apache Commons Pool 2.2 RC2 as 2.2

2014-02-23 Thread sebb
On 23 February 2014 14:24, Mark Thomas wrote: > On 23/02/2014 00:10, Jörg Schaible wrote: > >> However, the manifest contains the following line: >> >> Implementation-Build: UNKNOWN_BRANCH@r??; 2014-02-21 14:40:13+ >> >> Maybe we should stop adding it in future, is does not make sense. Th

Re: [VOTE] Release Apache Commons Pool 2.2 RC2 as 2.2

2014-02-23 Thread Mark Thomas
On 23/02/2014 00:10, Jörg Schaible wrote: > However, the manifest contains the following line: > > Implementation-Build: UNKNOWN_BRANCH@r??; 2014-02-21 14:40:13+ > > Maybe we should stop adding it in future, is does not make sense. +1. Any idea how to stop it? Mark --

Re: [VOTE] Release Apache Commons Pool 2.2 RC2 as 2.2

2014-02-22 Thread Stefan Bodewig
On 2014-02-21, Mark Thomas wrote: > The Pool 2.2 RC2 is available for review here: > https://dist.apache.org/repos/dist/dev/commons/pool/ (r4457) > Maven artifacts are here: > https://repository.apache.org/content/repositories/orgapachecommons-1009 > Details of changes since 2.1 are in the r

Re: [VOTE] Release Apache Commons Pool 2.2 RC2 as 2.2

2014-02-22 Thread Jörg Schaible
Hi, +1 builds from source with my compiler zoo. However, the manifest contains the following line: Implementation-Build: UNKNOWN_BRANCH@r??; 2014-02-21 14:40:13+ Maybe we should stop adding it in future, is does not make sense. - Jörg Mark Thomas wrote: > 2.2 fixes a few bugs and a

Re: [VOTE] Release Apache Commons Pool 2.2 RC2 as 2.2

2014-02-22 Thread Oliver Heger
Build with Maven and ant is successful on Windows 8.1 with Java 1.7. Artifacts and site look good. +1 One minor point: I noticed that the binary distribution does not contain the sources and the tests jars. IIRC, they were contained in RC1. Is this by intension? Oliver Am 21.02.2014 17:26, schr

Re: [VOTE] Release Apache Commons Pool 2.2 RC2 as 2.2

2014-02-21 Thread Phil Steitz
+1 Phil On 2/21/14, 8:26 AM, Mark Thomas wrote: > 2.2 fixes a few bugs and adds a new testOnCreate() feature that is > required by DBCP 2. > > RC2 fixes/improves the following compared to RC1 > - More clarity in release notes and index page on clients not using > MBean interfaces > - Refactor mi

Re: [VOTE] Release Apache Commons Pool 2.2 RC2 as 2.2

2014-02-21 Thread Gary Gregory
+1. Downloaded src zip, sig ok, hash ok. Builds ok. Reports ok. Apache Maven 3.1.1 (0728685237757ffbf44136acec0402957f723d9a; 2013-09-17 11:22:22-0400) Maven home: C:\Java\apache-maven-3.1.1\bin\.. Java version: 1.7.0_51, vendor: Oracle Corporation Java home: C:\Program Files\Java\jdk1.7.0_51\jre

Re: [VOTE] Release Apache Commons Pool 2.2 RC2 as 2.2

2014-02-21 Thread Mark Thomas
On 21/02/2014 16:26, Mark Thomas wrote: Unsurprisingly... > [X] +1 Release these artifacts > [ ] +0 OK, but... > [ ] -0 OK, but really should fix... > [ ] -1 I oppose this release because... Mark - To unsubscribe, e-ma

Re: [VOTE] Release Apache Commons Pool 2.2 RC2 as 2.2

2014-02-21 Thread Mark Thomas
On 21/02/2014 17:17, Gary Gregory wrote: > Wait a sec, now that pool2 requires Java 6, why are we still shipping our > own LinkedBlockingDeque instead of using the JRE? Because we require access to the internals that aren't available if we use the one from the JRE. Mark > > Gary > > > On Fri,

Re: [VOTE] Release Apache Commons Pool 2.2 RC2 as 2.2

2014-02-21 Thread Gary Gregory
Wait a sec, now that pool2 requires Java 6, why are we still shipping our own LinkedBlockingDeque instead of using the JRE? Gary On Fri, Feb 21, 2014 at 11:26 AM, Mark Thomas wrote: > 2.2 fixes a few bugs and adds a new testOnCreate() feature that is > required by DBCP 2. > > RC2 fixes/improve

[VOTE] Release Apache Commons Pool 2.2 RC2 as 2.2

2014-02-21 Thread Mark Thomas
2.2 fixes a few bugs and adds a new testOnCreate() feature that is required by DBCP 2. RC2 fixes/improves the following compared to RC1 - More clarity in release notes and index page on clients not using MBean interfaces - Refactor migration notes so they don't need changing on every release - U