Re: [VOTE] Release Apache Commons Pool 2.2 RC1 as 2.2

2014-02-21 Thread Mark Thomas
On 18/02/2014 19:28, sebb wrote: > On 18 February 2014 18:51, Mark Thomas wrote: >> On 18/02/2014 18:24, sebb wrote: >>> On 17 February 2014 20:42, Mark Thomas wrote: 2.2 fixes a few bugs and adds a new testOnCreate() feature that is required by DBCP 2. The Pool 2.2 RC1 i

Re: [VOTE] Release Apache Commons Pool 2.2 RC1 as 2.2

2014-02-19 Thread Gary Gregory
On Tue, Feb 18, 2014 at 2:28 PM, sebb wrote: > On 18 February 2014 18:51, Mark Thomas wrote: > > On 18/02/2014 18:24, sebb wrote: > >> On 17 February 2014 20:42, Mark Thomas wrote: > >>> 2.2 fixes a few bugs and adds a new testOnCreate() feature that is > >>> required by DBCP 2. > >>> > >>> > >

Re: [VOTE] Release Apache Commons Pool 2.2 RC1 as 2.2

2014-02-19 Thread Phil Steitz
+1 Sorry for delay in review / vote. Since we do not distribute the SHA-1 hashes, this is not a blocker / issue; but these files have alpha characters upper case, which does not agree with what openssl generates. I am curious how you generated the SHA-1 hashes. Normally, I think mvn generates

Re: [VOTE] Release Apache Commons Pool 2.2 RC1 as 2.2

2014-02-18 Thread Oliver Heger
Both Maven and ant builds run fine under Windows 8.1 with Java 1.7. Sites and artifacts look good. I agree with sebb that the errors in the clirr report should be mentioned in the release notes. Otherwise, I found no problems. Oliver Am 17.02.2014 21:42, schrieb Mark Thomas: > 2.2 fixes a few bu

Re: [VOTE] Release Apache Commons Pool 2.2 RC1 as 2.2

2014-02-18 Thread Phil Steitz
On 2/18/14, 10:51 AM, Mark Thomas wrote: > On 18/02/2014 18:24, sebb wrote: >> On 17 February 2014 20:42, Mark Thomas wrote: >>> 2.2 fixes a few bugs and adds a new testOnCreate() feature that is >>> required by DBCP 2. >>> >>> >>> The Pool 2.2 RC1 is available for review here: >>> https://dist.

Re: [VOTE] Release Apache Commons Pool 2.2 RC1 as 2.2

2014-02-18 Thread sebb
On 18 February 2014 18:51, Mark Thomas wrote: > On 18/02/2014 18:24, sebb wrote: >> On 17 February 2014 20:42, Mark Thomas wrote: >>> 2.2 fixes a few bugs and adds a new testOnCreate() feature that is >>> required by DBCP 2. >>> >>> >>> The Pool 2.2 RC1 is available for review here: >>> https:/

Re: [VOTE] Release Apache Commons Pool 2.2 RC1 as 2.2

2014-02-18 Thread Mark Thomas
On 18/02/2014 18:24, sebb wrote: > On 17 February 2014 20:42, Mark Thomas wrote: >> 2.2 fixes a few bugs and adds a new testOnCreate() feature that is >> required by DBCP 2. >> >> >> The Pool 2.2 RC1 is available for review here: >> https://dist.apache.org/repos/dist/dev/commons/pool/ (r4424) >

Re: [VOTE] Release Apache Commons Pool 2.2 RC1 as 2.2

2014-02-18 Thread sebb
On 17 February 2014 20:42, Mark Thomas wrote: > 2.2 fixes a few bugs and adds a new testOnCreate() feature that is > required by DBCP 2. > > > The Pool 2.2 RC1 is available for review here: > https://dist.apache.org/repos/dist/dev/commons/pool/ (r4424) Sigs and hashes OK. Source archive agrees

Re: [VOTE] Release Apache Commons Pool 2.2 RC1 as 2.2

2014-02-18 Thread Benedikt Ritter
Hi Mark, I won't have the time before wednesday evening (CET) before I can review a RC. Benedikt 2014-02-18 18:37 GMT+01:00 Mark Thomas : > On 18/02/2014 17:27, Gary Gregory wrote: > > On Tue, Feb 18, 2014 at 11:43 AM, Mark Thomas wrote: > > > >> On 18/02/2014 16:33, Gary Gregory wrote: > >>>

Re: [VOTE] Release Apache Commons Pool 2.2 RC1 as 2.2

2014-02-18 Thread Mark Thomas
On 18/02/2014 17:27, Gary Gregory wrote: > On Tue, Feb 18, 2014 at 11:43 AM, Mark Thomas wrote: > >> On 18/02/2014 16:33, Gary Gregory wrote: >>> On Tue, Feb 18, 2014 at 4:09 AM, Mark Thomas wrote: >>> On 18/02/2014 05:01, Gary Gregory wrote: > Since you'll reroll the RC to fix the rele

Re: [VOTE] Release Apache Commons Pool 2.2 RC1 as 2.2

2014-02-18 Thread Gary Gregory
On Tue, Feb 18, 2014 at 11:43 AM, Mark Thomas wrote: > On 18/02/2014 16:33, Gary Gregory wrote: > > On Tue, Feb 18, 2014 at 4:09 AM, Mark Thomas wrote: > > > >> On 18/02/2014 05:01, Gary Gregory wrote: > >>> Since you'll reroll the RC to fix the release notes for the version, > you > >>> might h

Re: [VOTE] Release Apache Commons Pool 2.2 RC1 as 2.2

2014-02-18 Thread Mark Thomas
On 18/02/2014 16:35, Gary Gregory wrote: > On Tue, Feb 18, 2014 at 4:19 AM, Mark Thomas wrote: > >> On 18/02/2014 05:26, Gary Gregory wrote: >>> Problem with the site: on the main page under "Migrating from Pool 2.0", >>> the current version described is 2.1, not 2.2. >>> >>> I would rename this

Re: [VOTE] Release Apache Commons Pool 2.2 RC1 as 2.2

2014-02-18 Thread Mark Thomas
On 18/02/2014 16:33, Gary Gregory wrote: > On Tue, Feb 18, 2014 at 4:09 AM, Mark Thomas wrote: > >> On 18/02/2014 05:01, Gary Gregory wrote: >>> Since you'll reroll the RC to fix the release notes for the version, you >>> might has well update to commons-parent 33 to pick up the new skin. >> >> W

Re: [VOTE] Release Apache Commons Pool 2.2 RC1 as 2.2

2014-02-18 Thread Gary Gregory
On Tue, Feb 18, 2014 at 4:19 AM, Mark Thomas wrote: > On 18/02/2014 05:26, Gary Gregory wrote: > > Problem with the site: on the main page under "Migrating from Pool 2.0", > > the current version described is 2.1, not 2.2. > > > > I would rename this section "Migrating to Pool 2.1 from 2.0" and a

Re: [VOTE] Release Apache Commons Pool 2.2 RC1 as 2.2

2014-02-18 Thread Gary Gregory
On Tue, Feb 18, 2014 at 4:09 AM, Mark Thomas wrote: > On 18/02/2014 05:01, Gary Gregory wrote: > > Since you'll reroll the RC to fix the release notes for the version, you > > might has well update to commons-parent 33 to pick up the new skin. > > Why do I need to reroll the RC to fix the release

Re: [VOTE] Release Apache Commons Pool 2.2 RC1 as 2.2

2014-02-18 Thread Mark Thomas
On 18/02/2014 05:26, Gary Gregory wrote: > Problem with the site: on the main page under "Migrating from Pool 2.0", > the current version described is 2.1, not 2.2. > > I would rename this section "Migrating to Pool 2.1 from 2.0" and add a new > section "Migrating to Pool 2.2 from 2.1". The "Migra

Re: [VOTE] Release Apache Commons Pool 2.2 RC1 as 2.2

2014-02-18 Thread Mark Thomas
On 18/02/2014 05:01, Gary Gregory wrote: > Since you'll reroll the RC to fix the release notes for the version, you > might has well update to commons-parent 33 to pick up the new skin. Why do I need to reroll the RC to fix the release notes? The only issue you identified was I hadn't replaced the

Re: [VOTE] Release Apache Commons Pool 2.2 RC1 as 2.2

2014-02-17 Thread Gary Gregory
Problem with the site: on the main page under "Migrating from Pool 2.0", the current version described is 2.1, not 2.2. I would rename this section "Migrating to Pool 2.1 from 2.0" and add a new section "Migrating to Pool 2.2 from 2.1". The "Migrating from Pool 1.x" section should then be renamed

Re: [VOTE] Release Apache Commons Pool 2.2 RC1 as 2.2

2014-02-17 Thread Gary Gregory
Since you'll reroll the RC to fix the release notes for the version, you might has well update to commons-parent 33 to pick up the new skin. Gary On Mon, Feb 17, 2014 at 3:42 PM, Mark Thomas wrote: > 2.2 fixes a few bugs and adds a new testOnCreate() feature that is > required by DBCP 2. > > >

Re: [VOTE] Release Apache Commons Pool 2.2 RC1 as 2.2

2014-02-17 Thread Mark Thomas
On 17/02/2014 20:48, Gary Gregory wrote: > In https://dist.apache.org/repos/dist/dev/commons/pool/RELEASE-NOTES.txt: > > - The release notes still say "2.1" and Left overs from the 2.1 release. Now fixed. (r4426). > - some entries appear to be missing a JIRA number. Not all changes have an asso

Re: [VOTE] Release Apache Commons Pool 2.2 RC1 as 2.2

2014-02-17 Thread Gary Gregory
In https://dist.apache.org/repos/dist/dev/commons/pool/RELEASE-NOTES.txt: - The release notes still say "2.1" and - some entries appear to be missing a JIRA number. Gary On Mon, Feb 17, 2014 at 3:42 PM, Mark Thomas wrote: > 2.2 fixes a few bugs and adds a new testOnCreate() feature that is >

[VOTE] Release Apache Commons Pool 2.2 RC1 as 2.2

2014-02-17 Thread Mark Thomas
2.2 fixes a few bugs and adds a new testOnCreate() feature that is required by DBCP 2. The Pool 2.2 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/pool/ (r4424) Maven artifacts are here: https://repository.apache.org/content/repositories/orgapachecommons-100