Re: [VOTE] Release Apache Commons Net 3.7 based on RC2

2020-08-05 Thread sebb
Here's my +1 On Sun, 2 Aug 2020 at 15:15, Gary Gregory wrote: > > +1 > > Building from the git tag. > > Yikes: Is JaCoCo correct in reporting such low numbers: 32% code coverage > and 26% branch coverage :-( > > My confidence is low that this RC does not introduce any regressions. > > But the bu

Re: [VOTE] Release Apache Commons Net 3.7 based on RC2

2020-08-02 Thread Gary Gregory
+1 Building from the git tag. Yikes: Is JaCoCo correct in reporting such low numbers: 32% code coverage and 26% branch coverage :-( My confidence is low that this RC does not introduce any regressions. But the building is OK with: mvn clean install site -P jacoco -P japicmp -V On these OpenJD

Re: [VOTE] Release Apache Commons Net 3.7 based on RC2

2020-08-02 Thread Gary Gregory
Why is this an RC2 when there's never been an RC1? Gary On Sat, Aug 1, 2020 at 3:26 PM sebb wrote: > We have fixed quite a few bugs and added some significant enhancements > since Apache Commons Net 3.6 was released, so I would like to release > Apache Commons Net 3.7. > > Apache Commons Net 3

Re: [VOTE] Release Apache Commons Net 3.7 based on RC2

2020-08-01 Thread Bruno P. Kinoshita
  [x] +1 Release these artifacts Building OK from tag, with Java 8, Ubuntu LTS, Maven 3.5, and using target mvn clean test install site. Site reports look OK. Checked signature, and contents of samples from dist/maven repo. Everything looking OK. Thanks! Bruno On Sunday, 2 August 2020, 7:

[VOTE] Release Apache Commons Net 3.7 based on RC2

2020-08-01 Thread sebb
We have fixed quite a few bugs and added some significant enhancements since Apache Commons Net 3.6 was released, so I would like to release Apache Commons Net 3.7. Apache Commons Net 3.7 RC2 is available for review here: https://dist.apache.org/repos/dist/dev/commons/net/3.7-RC2 (svn revision