Re: Reproducibility of Commons artifacts was: [VOTE] Release Apache Commons Logging 1.3.0 based on RC1

2024-01-05 Thread Piotr P. Karwasz
Hi Hervé, On Fri, 5 Jan 2024 at 08:14, Herve Boutemy wrote: > Piotr found the issue about the second run of bundle plugin and about > moditect 1.1.0 sensitivity to TZ: I don't know how hard it was to learn this, > nor how. > Do you have any idea on how to ease such discovery? The first time we

Re: Reproducibility of Commons artifacts was: [VOTE] Release Apache Commons Logging 1.3.0 based on RC1

2024-01-04 Thread Herve Boutemy
Hi team, I'm happy to have people like you trying to rebuild and compare: your feedback on your experience is very valuable. Here are a few remarks on this thread: - if you want to rebuild and *compare against a remote repository* (be it a SNAPSHOT or a release), you absolutely need to *avoid

Re: Reproducibility of Commons artifacts was: [VOTE] Release Apache Commons Logging 1.3.0 based on RC1

2023-12-29 Thread Gary Gregory
TY Piotr! Putting your pieces together for a local Commons Compress, this works for me: export TZ=UTC mvn clean install mvn clean package artifact:compare \ -Dreference.repo=apache.snapshots \ -DskipTests \ -Dcommons.spdx.version=0.7.1 -Dspdx.skip Gary On Fri, Dec 29, 2023 at 12:44 

Re: Reproducibility of Commons artifacts was: [VOTE] Release Apache Commons Logging 1.3.0 based on RC1

2023-12-29 Thread Piotr P. Karwasz
Hi Gary, On Fri, 29 Dec 2023 at 15:11, Gary Gregory wrote: > I run, copied from the > https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/apache/commons/compress/commons-compress-1.25.0.buildspec: > > mvn -Prelease clean package package -DskipTests -Dmaven.javadoc.ski

Re: Reproducibility of Commons artifacts was: [VOTE] Release Apache Commons Logging 1.3.0 based on RC1

2023-12-29 Thread Gary Gregory
I run, copied from the https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/apache/commons/compress/commons-compress-1.25.0.buildspec: mvn -Prelease clean package package -DskipTests -Dmaven.javadoc.skip -Dgpg.skip -Dcyclonedx.skip -Dcommons.release.dryRun -Dcommons.rel

Re: Reproducibility of Commons artifacts was: [VOTE] Release Apache Commons Logging 1.3.0 based on RC1

2023-12-29 Thread Piotr P. Karwasz
Hi Gary, On Fri, 29 Dec 2023 at 13:37, Gary Gregory wrote: > I do appreciate the fact that I can ask "Am I reproducible" but the > output is... cryptic. Yes, unfortunately if the check fails, finding the reason of the failure is hard. > For example: > ... > ├── META-INF/MANIFEST.MF > │ @@ -65,1

Re: Reproducibility of Commons artifacts was: [VOTE] Release Apache Commons Logging 1.3.0 based on RC1

2023-12-29 Thread Gary Gregory
Hi Piotr and all, Thank you for the refresher :-) I do appreciate the fact that I can ask "Am I reproducible" but the output is... cryptic. For example: git clone https://gitbox.apache.org/repos/asf/commons-compress.git cd commons-compress mvn clean install -DskipTests mvn package artifact:comp

Re: Reproducibility of Commons artifacts was: [VOTE] Release Apache Commons Logging 1.3.0 based on RC1

2023-12-28 Thread Piotr P. Karwasz
Hi Gary, On Thu, 28 Dec 2023 at 16:03, Gary Gregory wrote: > What value for $NEXUS_REPO would one use to verify repro _after_ a > release? I want to experiment with Apache Commons components... The `reference.repo` system variable is used by the `referenceRepo` parameter of `artifact:compare`:

Re: Reproducibility of Commons artifacts was: [VOTE] Release Apache Commons Logging 1.3.0 based on RC1

2023-12-28 Thread Gary Gregory
Hi Piotr, What value for $NEXUS_REPO would one use to verify repro _after_ a release? I want to experiment with Apache Commons components... Gary On Sat, Dec 16, 2023 at 6:56 PM Piotr P. Karwasz wrote: > > Hi all, > > On Mon, 27 Nov 2023 at 00:15, Piotr P. Karwasz > wrote: > > 2. For some st

Reproducibility of Commons artifacts was: [VOTE] Release Apache Commons Logging 1.3.0 based on RC1

2023-12-16 Thread Piotr P. Karwasz
Hi all, On Mon, 27 Nov 2023 at 00:15, Piotr P. Karwasz wrote: > 2. For some strange reason I had to set `TZ=America/New_York` to make > the main JAR reproducible. Either the Moditect or the Maven JAR plugin > are responsible for that. The recent Commons artifacts are hard to reproduce, since on

[RESULT][VOTE] Release Apache Commons Logging 1.3.0 based on RC1

2023-11-30 Thread Gary Gregory
This RC vote passes with the following +1 votes: - Piotr P. Karwasz non-binding - Rob Tompkins binding - Bruno P. Kinoshita binding - Gary Gregory binding Gary On Thu, Nov 30, 2023 at 6:24 AM Gary Gregory wrote: > > My +1 > > Gary > > > On Wed, Nov 29, 2023, 12:37 PM Bruno P. Kinoshita wrote:

Re: [VOTE] Release Apache Commons Logging 1.3.0 based on RC1

2023-11-30 Thread Gary Gregory
My +1 Gary On Wed, Nov 29, 2023, 12:37 PM Bruno P. Kinoshita wrote: > +1 > > Tested on > > Apache Maven 3.8.5 (3599d3414f046de2324203b78ddcf9b5e4388aa0) > Maven home: /opt/apache-maven-3.8.5 > Java version: 17.0.9, vendor: Private Build, runtime: > /usr/lib/jvm/java-17-openjdk-amd64 > Default

Re: [VOTE] Release Apache Commons Logging 1.3.0 based on RC1

2023-11-29 Thread Bruno P. Kinoshita
+1 Tested on Apache Maven 3.8.5 (3599d3414f046de2324203b78ddcf9b5e4388aa0) Maven home: /opt/apache-maven-3.8.5 Java version: 17.0.9, vendor: Private Build, runtime: /usr/lib/jvm/java-17-openjdk-amd64 Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: "5.15.0-89-generic",

Re: [VOTE] Release Apache Commons Logging 1.3.0 based on RC1

2023-11-26 Thread Rob Tompkins
+1 signatures; reports; site; release-notes; builds java: 8, 11, 17, and 21 all good. Thanks Gary!! Happy thanksgiving Cheers, -Rob > On Nov 26, 2023, at 4:46 PM, Gary Gregory wrote: > > We have fixed a few bugs and added some enhancements since Apache > Commons Logging 1.2 was released

Re: [VOTE] Release Apache Commons Logging 1.3.0 based on RC1

2023-11-26 Thread Gilles Sadowski
Le lun. 27 nov. 2023 à 00:15, Piotr P. Karwasz a écrit : > [...] > +1 (non binding): everything works correctly with the following remarks: > > 1. the SPDX artifact is not reproducible, > 2. For some strange reason I had to set `TZ=America/New_York` to make > the main JAR reproducible. Either th

Re: [VOTE] Release Apache Commons Logging 1.3.0 based on RC1

2023-11-26 Thread Piotr P. Karwasz
Hi Gary, > Please review the release candidate and vote. > This vote will close no sooner than 72 hours from now. > > [ ] +1 Release these artifacts > [ ] +0 OK, but... > [ ] -0 OK, but really should fix... > [ ] -1 I oppose this release because... I performed the following tests: * I te

[VOTE] Release Apache Commons Logging 1.3.0 based on RC1

2023-11-26 Thread Gary Gregory
We have fixed a few bugs and added some enhancements since Apache Commons Logging 1.2 was released, so I would like to release Apache Commons Logging 1.3.0. Apache Commons Logging 1.3.0 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/logging/1.3.0-RC1 (svn revi