[RESULT][VOTE] Release Apache Commons Lang 3.5 based on RC2

2016-10-16 Thread Benedikt Ritter
Hello, this vote passes with: Bruno P. Kinoshita: +1 (non-binding) Rob Tompkins: +1 (non-binding) Matt Benson: +1 Gary Gregory: +1 Oliver Heger: +1 Benedikt Ritter: +1 I'll proceed with the release procedure. Thanks to all who reviewed this and the last RC. Benedikt Benedikt Ritter schrieb a

Re: [VOTE] Release Apache Commons Lang 3.5 based on RC2

2016-10-16 Thread Benedikt Ritter
My +1 for this release. Benedikt Ritter schrieb am Do., 13. Okt. 2016 um 22:20 Uhr: > Hi, > > finally I found the time to prepare Apache Commons Lang 3.5 RC2 :-) > We could not release RC1, because I messed up the release archives. They > contained some snapshot artifacts. This has been fixed in

Re: [VOTE] Release Apache Commons Lang 3.5 based on RC2

2016-10-16 Thread Rob Tompkins
> On Oct 15, 2016, at 10:26 PM, Gary Gregory wrote: > > +1 > +1 > based on src zip, ASC, MD5, SHA1 OK. > > RAT check OK mod a TODO to adjust the build to ignore release notes. > > Clirr check OK mod internal breaks documented in the release notes. > > Reports OK. > > Builds OK with: > >

Re: [VOTE] Release Apache Commons Lang 3.5 based on RC2

2016-10-15 Thread Gary Gregory
+1 based on src zip, ASC, MD5, SHA1 OK. RAT check OK mod a TODO to adjust the build to ignore release notes. Clirr check OK mod internal breaks documented in the release notes. Reports OK. Builds OK with: mvn clean site OK Using: Apache Maven 3.0.5 (r01de14724cdef164cd33c7c8c2fe155faf9602da

Re: [VOTE] Release Apache Commons Lang 3.5 based on RC2

2016-10-15 Thread Gary Gregory
Since the release notes file in the root of the src zip does not have a header either, then these are OK. To do and not a blocker: adjust the build to ignore all release notes and .htaccess files for a RAT check. Gary On Sat, Oct 15, 2016 at 11:58 AM, Gary Gregory wrote: > From src zip: RAT ch

Re: [VOTE] Release Apache Commons Lang 3.5 based on RC2

2016-10-15 Thread Gary Gregory
The file: src/site/resources/.htaccess has no business being in the src zip/tar. Not a blocker. Gary On Sat, Oct 15, 2016 at 11:58 AM, Gary Gregory wrote: > From src zip: RAT check fails: > > * > > Files with unapproved licenses: > > src/s

Re: [VOTE] Release Apache Commons Lang 3.5 based on RC2

2016-10-15 Thread Oliver Heger
Build works fine for me with Java 1.6 and 1.8 on Windows 10. Site build works with Java 1.8. Artifacts and site look good. +1 Oliver Am 13.10.2016 um 22:20 schrieb Benedikt Ritter: > Hi, > > finally I found the time to prepare Apache Commons Lang 3.5 RC2 :-) > We could not release RC1, because

Re: [VOTE] Release Apache Commons Lang 3.5 based on RC2

2016-10-15 Thread Gary Gregory
White the release notes do make mention of what I see on the clirr:check command line: [INFO] --- clirr-maven-plugin:2.8:check (default-cli) @ commons-lang3 --- [INFO] artifact org.apache.commons:commons-lang3: checking for updates from central [INFO] Comparing to version: 3.4 [ERROR] 7012: org.ap

Re: [VOTE] Release Apache Commons Lang 3.5 based on RC2

2016-10-15 Thread Gary Gregory
>From src zip: RAT check fails: * Files with unapproved licenses: src/site/resources/.htaccess src/site/resources/release-notes/RELEASE-NOTES-1.0.1.txt src/site/resources/release-notes/RELEASE-NOTES-1.0.txt src/site/resources/release-no

Re: [VOTE] Release Apache Commons Lang 3.5 based on RC2

2016-10-14 Thread Matt Benson
On Oct 13, 2016 3:20 PM, "Benedikt Ritter" wrote: > > Hi, > > finally I found the time to prepare Apache Commons Lang 3.5 RC2 :-) > We could not release RC1, because I messed up the release archives. They > contained some snapshot artifacts. This has been fixed in RC2. Furthermore > LANG-1275 has

Re: [VOTE] Release Apache Commons Lang 3.5 based on RC2

2016-10-14 Thread Rob Tompkins
ng ignored > in SerializationUtils#deserialize, but not a blocker IMO. > > The changes report is showing the release date as 2014-10-13, but I assume > it is fixed during the release process? > > Keys OK. All good, kudos all! > > Bruno > >_______________

Re: [VOTE] Release Apache Commons Lang 3.5 based on RC2

2016-10-14 Thread Bruno P. Kinoshita
se process? Keys OK. All good, kudos all! Bruno > > From: Benedikt Ritter >To: Commons Developers List >Sent: Friday, 14 October 2016 9:20 AM >Subject: [VOTE] Release Apache Commons Lang 3.5 based on RC2 > > >Hi, > >finally I fou

[VOTE] Release Apache Commons Lang 3.5 based on RC2

2016-10-13 Thread Benedikt Ritter
Hi, finally I found the time to prepare Apache Commons Lang 3.5 RC2 :-) We could not release RC1, because I messed up the release archives. They contained some snapshot artifacts. This has been fixed in RC2. Furthermore LANG-1275 has been incorporated. Lang 3.5 RC2 is available for review here: