[CANCEL][VOTE] Release Apache Commons Lang 3.4 based on RC1

2015-03-30 Thread Benedikt Ritter
Hi, it looks like I've broken OS detection in SystemUtils in r1669750 [1]. After these changes, the following will fail: assertTrue(SystemUtils.isOSMatch("Windows Me", "4.90", "Windows", "4.9")); Since there seems to be another regression in the time package, I'd like to fix this and address Oli

Re: [VOTE] Release Apache Commons Lang 3.4 based on RC1

2015-03-30 Thread Jörg Schaible
Benedikt Ritter wrote: > Hi all, > > We have fixed quite a few bugs and added some significant enhancements > since Commons Lang 3.3.2 was released, so I would like to release Commons > Lang 3.4. > > Commons Lang 3.4 RC1 is available for review here: > https://dist.apache.org/repos/dist/dev/co

Re: [VOTE] Release Apache Commons Lang 3.4 based on RC1

2015-03-29 Thread Oliver Heger
Hi, Maven build was successful on Windows 8.1 with Java 1.6 and 1.7. Artifacts and site look good. Nits/questions: - The surefire report says that 97 tests are skipped. This seems to be a large number. - Clirr has a warning about a changed constant. Does this have to be mentioned in release notes

Re: [VOTE] Release Apache Commons Lang 3.4 based on RC1

2015-03-29 Thread Benedikt Ritter
couldn't paste the complete log without my browser crashing. > > Cheers,Bruno > > > From: Bruno P. Kinoshita > To: Commons Developers List > Sent: Sunday, March 29, 2015 2:50 PM > Subject: Re: [VOTE] Release Apache Commons Lang 3.4 based on RC1 > > Hi, >

Re: [VOTE] Release Apache Commons Lang 3.4 based on RC1

2015-03-29 Thread Bruno P. Kinoshita
March 29, 2015 2:50 PM Subject: Re: [VOTE] Release Apache Commons Lang 3.4 based on RC1 Hi, +0 non binding, Build works fine with Java 7 and Maven 3.2 Apache Maven 3.2.5 (12a6b3acb947671f09b81f49094c53f426d8cea1; 2014-12-14T15:29:23-02:00) Maven home: /opt/apache-maven-3.2.5 Java version:

Re: [VOTE] Release Apache Commons Lang 3.4 based on RC1

2015-03-29 Thread Bruno P. Kinoshita
m: Benedikt Ritter To: Commons Developers List Sent: Saturday, March 28, 2015 1:31 PM Subject: [VOTE] Release Apache Commons Lang 3.4 based on RC1 Hi all, We have fixed quite a few bugs and added some significant enhancements since Commons Lang 3.3.2 was released, so I would like to rele

Re: [VOTE] Release Apache Commons Lang 3.4 based on RC1

2015-03-29 Thread Sergio Fernández
+1 (non-binding) So far I checked: signatures and digests, NOTICE and LICENSE files, clean build (debian linux 64 bits, java 1.8.0_25). On 28/03/15 18:16, Benedikt Ritter wrote: 2015-03-28 17:52 GMT+01:00 Gary Gregory : On Sat, Mar 28, 2015 at 9:31 AM, Benedikt Ritter wrote: Hi all, We

Re: [VOTE] Release Apache Commons Lang 3.4 based on RC1

2015-03-28 Thread Gary Gregory
+1 MD5, SHA1, ASC Ok. Site builds Ok with: Apache Maven 3.2.5 (12a6b3acb947671f09b81f49094c53f426d8cea1; 2014-12-14T09:29:23-08:00) Maven home: C:\Java\apache-maven-3.2.5 Java version: 1.7.0_75, vendor: Oracle Corporation Java home: C:\Program Files\Java\jdk1.7.0_75\jre Default locale: en_US, pl

Re: [VOTE] Release Apache Commons Lang 3.4 based on RC1

2015-03-28 Thread Jörg Schaible
Gary Gregory wrote: [snip] > Apache Maven 3.3.1 (cab6659f9874fa96462afef40fcf6bc033d58c1c; > 2015-03-13T13:10:27-07:00) > Maven home: C:\Java\apache-maven-3.3.1 > Java version: 1.7.0_75, vendor: Oracle Corporation > Java home: C:\Program Files\Java\jdk1.7.0_75\jre > Default locale: en_US, platfo

Re: [VOTE] Release Apache Commons Lang 3.4 based on RC1

2015-03-28 Thread Gary Gregory
oh, and that means that no Jira changes report and no Checkstyle report is generated. So that's not so good because I cannot create the same site the RM did. Gary On Sat, Mar 28, 2015 at 10:16 AM, Benedikt Ritter wrote: > 2015-03-28 17:52 GMT+01:00 Gary Gregory : > > > On Sat, Mar 28, 2015 at

Re: [VOTE] Release Apache Commons Lang 3.4 based on RC1

2015-03-28 Thread Gary Gregory
With the src zip, I run 'mvn clean site' and it works but I get two stack dumps due to slf4j being out of sync: [INFO] Falling back to RSS for issue download: This JIRA server does not support version 2 of the REST API, which maven-changes-plugin requires. [WARN] An issue has occurred with maven-c

Re: [VOTE] Release Apache Commons Lang 3.4 based on RC1

2015-03-28 Thread Benedikt Ritter
2015-03-28 17:52 GMT+01:00 Gary Gregory : > On Sat, Mar 28, 2015 at 9:31 AM, Benedikt Ritter > wrote: > > > Hi all, > > > > We have fixed quite a few bugs and added some significant enhancements > > since Commons Lang 3.3.2 was released, so I would like to release Commons > > Lang 3.4. > > > > Co

Re: [VOTE] Release Apache Commons Lang 3.4 based on RC1

2015-03-28 Thread Gary Gregory
On Sat, Mar 28, 2015 at 9:31 AM, Benedikt Ritter wrote: > Hi all, > > We have fixed quite a few bugs and added some significant enhancements > since Commons Lang 3.3.2 was released, so I would like to release Commons > Lang 3.4. > > Commons Lang 3.4 RC1 is available for review here: > https://d

[VOTE] Release Apache Commons Lang 3.4 based on RC1

2015-03-28 Thread Benedikt Ritter
Hi all, We have fixed quite a few bugs and added some significant enhancements since Commons Lang 3.3.2 was released, so I would like to release Commons Lang 3.4. Commons Lang 3.4 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/lang/ (svn revision 8466) Maven a