Re: [VOTE] Release Apache Commons DbUtils 1.8 based on RC2

p://bernd.eckenfels.net <http://bernd.eckenfels.net/> > > > > Von: Carl Hall mailto:thecarlh...@apache.org>> > > Gesendet: Dienstag, März 10, 2020 11:41 PM > > An: Commons List > > Betreff: Re: [VOTE] Release Apache Commons D

Re: [VOTE] Release Apache Commons DbUtils 1.8 based on RC2

fels.net <http://bernd.eckenfels.net/> > > Von: Carl Hall mailto:thecarlh...@apache.org>> > Gesendet: Dienstag, März 10, 2020 11:41 PM > An: Commons List > Betreff: Re: [VOTE] Release Apache Commons DbUtils 1.8 based on RC2 > > Thanks, Be

Re: [VOTE] Release Apache Commons DbUtils 1.8 based on RC2

ommons/KEYS%3EYS> Thanks. The details in the file were correct, and I updated my keys there. > Gruss > Bernd > -- > http://bernd.eckenfels.net <http://bernd.eckenfels.net/> > > Von: Carl Hall mailto:thecarlh...@apache.org>> > Gese

Re: [VOTE] Release Apache Commons DbUtils 1.8 based on RC2

stag, März 10, 2020 11:41 PM An: Commons List Betreff: Re: [VOTE] Release Apache Commons DbUtils 1.8 based on RC2 Thanks, Bernd! I've copied your response below and will reply inline to a couple of things. After 2 months, we're really close to making this release. :) Binding: 2 (Br

Re: [VOTE] Release Apache Commons DbUtils 1.8 based on RC2

Thanks, Bernd! I've copied your response below and will reply inline to a couple of things. After 2 months, we're really close to making this release. :) Binding: 2 (Bruno, Bernd) Non-binding: 2 (Bill, Amey) > On Mar 10, 2020, at 7:13 AM, Bernd Eckenfels wrote: > > Hello, > > I tested window

[VOTE] Release Apache Commons DbUtils 1.8 based on RC2

Hello, I tested windows (java8) build, checksum, source content and signature. This is a +1 Bindung but there are some nits *Carls Key in KEYS seems to be expired * The src.zip misses some dot files (Travis.yml) * The mentioned git tag was wrong, it is dbutil_1_8_Rc2 * I haven

Re: [VOTE] Release Apache Commons DbUtils 1.8 based on RC2

Bi-weekly vote status: +1’s Binding: 1 (Bruno) Non-binding: 2 (Bill, Amey) It’d be super great if we could get another couple of PMC members to review in hopes of reaching our 3 +1s to pass. Thanks in advance for helping us land this release! > On Jan 31, 2020, at 7:19 AM, Amey Jadiye wrote:

Re: [VOTE] Release Apache Commons DbUtils 1.8 based on RC2

Looks good with tests, rat, clirr, spotbug and javadoc. I can see 4 errors with checkstyle but they seem to be minor. checked with java 8 and 11. hashes and sig are fine. +1 (non-binding) Regards, Amey On Thu, Jan 9, 2020 at 12:20 PM Carl Hall wrote: > We have fixed quite a few bugs and adde

Re: [VOTE] Release Apache Commons DbUtils 1.8 based on RC2

I'll try to review at the weekend at the latest. Gary On Mon, Jan 27, 2020 at 12:39 AM Carl Hall wrote: > For the 2 weeks this vote has been open, we have 1 binding and 1 > non-binding vote so far. > > May I humbly ask for a few more folks to help with this release review? > Thanks in advance!

Re: [VOTE] Release Apache Commons DbUtils 1.8 based on RC2

For the 2 weeks this vote has been open, we have 1 binding and 1 non-binding vote so far. May I humbly ask for a few more folks to help with this release review? Thanks in advance! > On Jan 22, 2020, at 5:19 PM, William Speirs wrote: > > Sorry, meant to say: +1 > > On Wed, Jan 22, 2020 at 7

Re: [VOTE] Release Apache Commons DbUtils 1.8 based on RC2

Sorry, meant to say: +1 On Wed, Jan 22, 2020 at 7:34 PM Carl Hall wrote: > Thanks, Bill. Looking for 2 more positive votes to proceed. :) I'd like > to hear from Gary given his concerns on this thread. > > > > On Jan 22, 2020, at 6:00 AM, William Speirs wrote: > > > > Works for me... Carl, let

Re: [VOTE] Release Apache Commons DbUtils 1.8 based on RC2

Thanks, Bill. Looking for 2 more positive votes to proceed. :) I'd like to hear from Gary given his concerns on this thread. > On Jan 22, 2020, at 6:00 AM, William Speirs wrote: > > Works for me... Carl, let me know how I can help. > > On Wed, Jan 22, 2020 at 12:37 AM Carl Hall wrote: > >>

Re: [VOTE] Release Apache Commons DbUtils 1.8 based on RC2

Works for me... Carl, let me know how I can help. On Wed, Jan 22, 2020 at 12:37 AM Carl Hall wrote: > I’m in favor of releasing 1.8 because it’s ready and has had the most > attention in recent months/years. > After such, we put eyes on the 2.0 branch to ensure it is ready to be the > successive

Re: [VOTE] Release Apache Commons DbUtils 1.8 based on RC2

I’m in favor of releasing 1.8 because it’s ready and has had the most attention in recent months/years. After such, we put eyes on the 2.0 branch to ensure it is ready to be the successive version. Once we’re happy with that, create a 1.x brach from master, bring 2.0 to master, and see if we can

Re: [VOTE] Release Apache Commons DbUtils 1.8 based on RC2

What is there to "clean up"? Sorry, just not following exactly what you mean. Thanks! Bill- On Fri, Jan 10, 2020 at 4:42 PM Gary Gregory wrote: > I think we should clean all of this up _now_ and then release 1.8. > > What do others think? > > Gary > > On Fri, Jan 10, 2020 at 12:44 PM Carl Hall

Re: [VOTE] Release Apache Commons DbUtils 1.8 based on RC2

I think we should clean all of this up _now_ and then release 1.8. What do others think? Gary On Fri, Jan 10, 2020 at 12:44 PM Carl Hall wrote: > +1 to moving master to 1.8-SNAPSHOT and dealing with what's to come with > 2.0 at some future time in a 2.0 branch. > > I can change master:pom.xml

Re: [VOTE] Release Apache Commons DbUtils 1.8 based on RC2

+1 to moving master to 1.8-SNAPSHOT and dealing with what's to come with 2.0 at some future time in a 2.0 branch. I can change master:pom.xml to be 1.8-SNAPSHOT then when the RC is out, merge release into master (1.8) and proceed to 1.9-SNAPSHOT. Advice? The branch name is a review miss on my

Re: [VOTE] Release Apache Commons DbUtils 1.8 based on RC2

My vote would be to make master 1.8-SNAPSHOT as I doubt 2.x will see the light-of-day for a LONG time... it's been 3+ years already. Continue with what Carl is trying to do, so we at least get _something_ out the door. Also, I _think_ I had to create 2_0 as the branch name, because svn (at the tim

Re: [VOTE] Release Apache Commons DbUtils 1.8 based on RC2

On Fri, Jan 10, 2020 at 9:16 AM William Speirs wrote: > For what it's worth, I'm unable to find that branch in git: > > $ git clone https://gitbox.apache.org/repos/asf/commons-dbutils.git > --branch > commons-dbutils-1.8-RC2 common

Re: [VOTE] Release Apache Commons DbUtils 1.8 based on RC2

For what it's worth, I'm unable to find that branch in git: $ git clone https://gitbox.apache.org/repos/asf/commons-dbutils.git --branch commons-dbutils-1.8-RC2 commons-dbutils-1.8-RC2 Cloning into 'commons-dbutils-1.8-RC2'... fatal: Remote branch commons-dbutils-1.8-RC2 not found in upstream orig

Re: [VOTE] Release Apache Commons DbUtils 1.8 based on RC2

  [x] +1 Release these artifacts Build passing with JDK 13 on Ubuntu LTS, from git tag (mvn clean test install site). Reports look OK. There are two SpotBugs bugs about default encoding that can be fixed later I suppose. Generating reports locally skipped PMD. For some reason, even though

Re: [VOTE] Release Apache Commons DbUtils 1.8 based on RC2

I tested this with the following builds: Java version: 1.8.0_144, vendor: Oracle Corporation, runtime: /Library/Java/JavaVirtualMachines/jdk1.8.0_144.jdk/Contents/Home/jre Java version: 11.0.2, vendor: Oracle Corporation, runtime: /Library/Java/JavaVirtualMachines/openjdk-11.0.2.jdk/Contents/Hom

[VOTE] Release Apache Commons DbUtils 1.8 based on RC2

We have fixed quite a few bugs and added some significant enhancements since Apache Commons DbUtils 1.7 was released, so I would like to release Apache Commons DbUtils 1.8. RC2 handles closing connections only when owned, and addresses generated javadoc, NOTICE year update, and release notes de