This vote passes with the following result:
- Gary Gregory: +1 (binding)
- Oliver Heger: +1 (binding)
- Rob Tompkins: +1 (binding)
- Amey Jadiye: +1 (non-binding)
Thank you to all who helped make this release and for reviewing the RCs!
I’ll work on publishing everything soon.
On Tue, Jul 18, 20
On Tue, Jul 18, 2017 at 1:13 PM, Oliver Heger
wrote:
> Build works fine with Java 1.6 and 1.8 on Windows 10. Artifacts and site
> look good.
>
> There is a bunch of checkstyle errors, especially in
> BaseResultSetHandler.java; but I assume they have been in there before,
> so not a blocker.
>
Ye
Build works fine with Java 1.6 and 1.8 on Windows 10. Artifacts and site
look good.
There is a bunch of checkstyle errors, especially in
BaseResultSetHandler.java; but I assume they have been in there before,
so not a blocker.
+1, good work!
Oliver
Am 17.07.2017 um 00:41 schrieb Carl Hall:
> Hi
On Tue, Jul 18, 2017 at 11:12 AM, Amey Jadiye wrote:
> Checked RC2, and here is my +1 (non-binding).
>
> 1. Build and Tests are passing clean
> 2. Clirr and Rat looks good.
> 3. Findbug show two DM_DEFAULT_ENCODING warning but non-blocker to release.
> 3. There are few of bugs in Checkstyle repor
Checked RC2, and here is my +1 (non-binding).
1. Build and Tests are passing clean
2. Clirr and Rat looks good.
3. Findbug show two DM_DEFAULT_ENCODING warning but non-blocker to release.
3. There are few of bugs in Checkstyle report but they are non-blocker to
release.
4. Hashes given in files lo
+1
Checked ASC/SHA1 for all artifacts. All ok.
RAT and CLIRR check OK
New issues found:
- Reported in previous email, typographic error on SHA1 on jar file (namely
commons-dbutils-1.7.jar). But, all is correct in nexus, so no worries to me.
-Rob
> On Jul 16, 2017, at 6:41 PM, Carl Hall wro
Note:
The SHA1 listed in the email below for "commons-dbutils-1.7.jar” does not match
the SHA1 "a2d6e515aa87e5d38f6b3003e70b13c1b1f19ca0” of the artifact in the
Apache Nexus instance. However, the commons-dbutils-1.7.jar.sha1 does contain
the correct SHA1, so it seems to be a typographic error o
Let's not get side-tracked here, this is a [VOTE] thread ;-)
Gary
On Mon, Jul 17, 2017 at 8:46 AM, Matt Sicker wrote:
> I've migrated Mockito code before, and the migration is pretty simple
> depending on how complex your usage is. It could be as simple as changing
> an import or two.
>
> On 17
I've migrated Mockito code before, and the migration is pretty simple
depending on how complex your usage is. It could be as simple as changing
an import or two.
On 17 July 2017 at 10:11, Carl Hall wrote:
> Thanks for pointing those out, sebb. I'll be sure to get all of those
> committed to mas
Thanks for pointing those out, sebb. I'll be sure to get all of those
committed to master. Hopefully the Mockito jump isn't too much work. :)
On Mon, Jul 17, 2017 at 1:48 AM, sebb wrote:
> Note: it's worth running the following:
>
> mvn versions:display-dependency-updates -U
> and
> mvn versi
Thanks! Looks like PMD moved the Java rulesets to rulesets/java/*. I'll
update that in master and make sure it's ready for the next release. fwiw,
fixing that did not raise any new issues or warnings.
On Sun, Jul 16, 2017 at 7:08 PM, Gary Gregory
wrote:
> I noticed it during
>
> mvn clean ver
Note: it's worth running the following:
mvn versions:display-dependency-updates -U
and
mvn versions:display-plugin-updates -U
to check for possible version updates
These give:
[INFO] The following dependencies in Dependencies have newer versions:
[INFO] junit:junit ...
I noticed it during
mvn clean verify site
Gary
On Jul 16, 2017 18:34, "Carl Hall" wrote:
> Great feedback! Thanks so much.
>
> Would you please let me know how you're running PMD? I've tried `mvn
> pmd:pmd`. I'm not seeing issues locally and would like to make sure the
> build is bulletproo
Great feedback! Thanks so much.
Would you please let me know how you're running PMD? I've tried `mvn
pmd:pmd`. I'm not seeing issues locally and would like to make sure the
build is bulletproof.
On Sun, Jul 16, 2017 at 6:08 PM, Gary Gregory
wrote:
> +1
>
> From src zip: ASC, MD5, and SHA1 O
+1
>From src zip: ASC, MD5, and SHA1 OK.
RAT and CLIRR check OK.
Reports look OK.
Issues to address but not blockers:
- PMD blows up during the build and there is no resulting PMD report.
- The POM uses an old version of commons-parent.
Gary
On Sun, Jul 16, 2017 at 3:41 PM, Carl Hall wrote:
Hi,
It's been almost 3 years to the day since we've had a DbUtils release.
We've fixed several important bugs and added some new features, so I would
like to release DbUtils 1.7.
Furthermore, we have fixed these issues for RC2, which were discovered in
RC1:
- resource leaks as found by FindBugs
-
16 matches
Mail list logo
