Re: [VOTE] Release Apache Commons DBCP 2.7.0 based on RC1

2019-08-06 Thread Gary Gregory
My +1 Gary On Wed, Jul 31, 2019 at 9:42 AM Gary Gregory wrote: > We have fixed quite a few bugs and added some significant enhancements > since Apache Commons DBCP 2.6.0 was released, so I would like to release > Apache Commons DBCP 2.7.0. > > Apache Commons DBCP 2.7.0 RC1 is available for revi

Re: [VOTE] Release Apache Commons DBCP 2.7.0 based on RC1

2019-08-06 Thread Bruno P. Kinoshita
  [x] +1 Release these artifacts Build passing with `mvn clean test install site` on Ubuntu LTS with: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-18T06:33:14+12:00) Maven home: /opt/apache-maven-3.5.4 Java version: 1.8.0_222, vendor: Private Build, runtime: /usr/lib/j

Re: [VOTE] Release Apache Commons DBCP 2.7.0 based on RC1

2019-08-06 Thread Gary Gregory
On Mon, Aug 5, 2019 at 8:01 AM Gary Gregory wrote: > > > On Sat, Aug 3, 2019 at 7:34 PM Gary Gregory > wrote: > >> On Sat, Aug 3, 2019 at 8:38 AM Rob Tompkins wrote: >> >>> +1 all looks good to me. Nit. the site build for java11 didn’t work, but >>> all the tests passed. >>> >> >> Thank you Rob

Re: [VOTE] Release Apache Commons DBCP 2.7.0 based on RC1

2019-08-05 Thread Gary Gregory
On Sat, Aug 3, 2019 at 7:34 PM Gary Gregory wrote: > On Sat, Aug 3, 2019 at 8:38 AM Rob Tompkins wrote: > >> +1 all looks good to me. Nit. the site build for java11 didn’t work, but >> all the tests passed. >> > > Thank you Rob. > May we have more reviews please? > Ping to PMC members. Gary

Re: [VOTE] Release Apache Commons DBCP 2.7.0 based on RC1

2019-08-03 Thread Gary Gregory
On Sat, Aug 3, 2019 at 8:38 AM Rob Tompkins wrote: > +1 all looks good to me. Nit. the site build for java11 didn’t work, but > all the tests passed. > Thank you Rob. May we have more reviews please? Gary > > > On Jul 31, 2019, at 9:42 AM, Gary Gregory > wrote: > > > > We have fixed quite a

Re: [VOTE] Release Apache Commons DBCP 2.7.0 based on RC1

2019-08-03 Thread Rob Tompkins
+1 all looks good to me. Nit. the site build for java11 didn’t work, but all the tests passed. > On Jul 31, 2019, at 9:42 AM, Gary Gregory wrote: > > We have fixed quite a few bugs and added some significant enhancements > since Apache Commons DBCP 2.6.0 was released, so I would like to release

[VOTE] Release Apache Commons DBCP 2.7.0 based on RC1

2019-07-31 Thread Gary Gregory
We have fixed quite a few bugs and added some significant enhancements since Apache Commons DBCP 2.6.0 was released, so I would like to release Apache Commons DBCP 2.7.0. Apache Commons DBCP 2.7.0 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/dbcp/2.7.0-RC1 (