Re: [VOTE] Release Apache Commons Collections 4.2 based on RC1

Build works fine with Java 1.8 on Windows 10. Artifacts and site look good. +1 Only one minor nit: On the site under Project Reports there is an empty japicmp report. Oliver Am 08.07.2018 um 16:04 schrieb Gary Gregory: > We have fixed quite a few bugs and added some significant enhancements > s

Re: [collections] 4.2 rat issue (Was: [VOTE] Release Apache Commons Collections 4.2 based on RC1)

> On Jul 11, 2018, at 9:40 AM, Gary Gregory wrote: > > On Tue, Jul 10, 2018 at 2:26 PM Rob Tompkins wrote: > >> >> >>> On Jul 10, 2018, at 4:20 PM, Rob Tompkins wrote: >>> >>> On Jul 10, 2018, at 4:18 PM, Gary Gregory >> wrote: On Tue, Jul 10, 2018 at 2:08 PM Rob Tompkins >>

Re: [collections] 4.2 rat issue (Was: [VOTE] Release Apache Commons Collections 4.2 based on RC1)

On Tue, Jul 10, 2018 at 2:26 PM Rob Tompkins wrote: > > > > On Jul 10, 2018, at 4:20 PM, Rob Tompkins wrote: > > > > On Jul 10, 2018, at 4:18 PM, Gary Gregory > wrote: > >> > >> On Tue, Jul 10, 2018 at 2:08 PM Rob Tompkins > wrote: > >> > >>> I’ve got two rat violations: > >>> > >>> > https://

Re: [VOTE] Release Apache Commons Collections 4.2 based on RC1

PMCs, May I have at least one more review please? Gary On Sun, Jul 8, 2018 at 8:04 AM Gary Gregory wrote: > We have fixed quite a few bugs and added some significant enhancements > since Apache Commons Collections 4.1 was released, so I would like to > release Apache Commons Collections 4.2. >

Re: [VOTE] Release Apache Commons Collections 4.2 based on RC1

+1 - validated all signatures, - ran “mvn clean test site verify” on maven 3.5.4, with java1.7.0_80, java1.8.0_172, java9.0.4, and java10.0.1 - Nits. We could clean up some of the pmd issues. That weird RAT report. -Rob > On Jul 10, 2018, at 11:48 AM, Gary Gregory wrote: > > My +1. We need

Re: [VOTE] Release Apache Commons Collections 4.2 based on RC1

On Tue, Jul 10, 2018 at 2:20 PM Rob Tompkins wrote: > On Jul 10, 2018, at 4:18 PM, Gary Gregory wrote: > > > > On Tue, Jul 10, 2018 at 2:08 PM Rob Tompkins wrote: > > > >> I’ve got two rat violations: > >> > >> > https://dist.apache.org/repos/dist/dev/commons/collections/4.2-RC1/site/rat-report

[collections] 4.2 rat issue (Was: [VOTE] Release Apache Commons Collections 4.2 based on RC1)

> On Jul 10, 2018, at 4:20 PM, Rob Tompkins wrote: > > On Jul 10, 2018, at 4:18 PM, Gary Gregory wrote: >> >> On Tue, Jul 10, 2018 at 2:08 PM Rob Tompkins wrote: >> >>> I’ve got two rat violations: >>> >>> https://dist.apache.org/repos/dist/dev/commons/collections/4.2-RC1/site/rat-report.

Re: [VOTE] Release Apache Commons Collections 4.2 based on RC1

On Jul 10, 2018, at 4:18 PM, Gary Gregory wrote: > > On Tue, Jul 10, 2018 at 2:08 PM Rob Tompkins wrote: > >> I’ve got two rat violations: >> >> https://dist.apache.org/repos/dist/dev/commons/collections/4.2-RC1/site/rat-report.html >> < >> https://dist.apache.org/repos/dist/dev/commons/collec

Re: [VOTE] Release Apache Commons Collections 4.2 based on RC1

On Tue, Jul 10, 2018 at 2:08 PM Rob Tompkins wrote: > I’ve got two rat violations: > > https://dist.apache.org/repos/dist/dev/commons/collections/4.2-RC1/site/rat-report.html > < > https://dist.apache.org/repos/dist/dev/commons/collections/4.2-RC1/site/rat-report.html > > > but, they look like fi

Re: [VOTE] Release Apache Commons Collections 4.2 based on RC1

I’ve got two rat violations: https://dist.apache.org/repos/dist/dev/commons/collections/4.2-RC1/site/rat-report.html but, they look like files that need to be excluded. Should this invalidate the release?

Re: [VOTE] Release Apache Commons Collections 4.2 based on RC1

> On Jul 10, 2018, at 11:48 AM, Gary Gregory wrote: > > My +1. We need more VOTEs please ;-) Going to roll rng, 1.1, and do this today. > > Gary > > On Sun, Jul 8, 2018 at 8:04 AM Gary Gregory wrote: > >> We have fixed quite a few bugs and added some significant enhancements >> since Apa

Re: [VOTE] Release Apache Commons Collections 4.2 based on RC1

My +1. We need more VOTEs please ;-) Gary On Sun, Jul 8, 2018 at 8:04 AM Gary Gregory wrote: > We have fixed quite a few bugs and added some significant enhancements > since Apache Commons Collections 4.1 was released, so I would like to > release Apache Commons Collections 4.2. > > Apache Comm

[VOTE] Release Apache Commons Collections 4.2 based on RC1

We have fixed quite a few bugs and added some significant enhancements since Apache Commons Collections 4.1 was released, so I would like to release Apache Commons Collections 4.2. Apache Commons Collections 4.2 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/c