[RESULT][VOTE] Release Apache Commons BCEL based on RC1

2017-12-08 Thread Gary Gregory
This VOTE passes with the following +1 binding votes from three (3) PMC members: Gary Gregory, Oliver Heger, Bruno P. Kinoshita >From one (1) committer: Sergio Fernández, >From one (1) contributors: Mark Roberts I will proceed with the release. Gary On Thu, Nov 30, 2017 at 9:17 PM, Gary Grego

Re: [VOTE] Release Apache Commons BCEL based on RC1

2017-12-07 Thread Bruno P. Kinoshita
ven repository, all good. Thanks! Bruno From: Gary Gregory To: Commons Developers List Sent: Friday, 8 December 2017 9:36 AM Subject: Re: [VOTE] Release Apache Commons BCEL based on RC1 I am looking for more reviews from PMC members please. Gary On Dec 7, 2017 13:33, "Oliver

Re: [VOTE] Release Apache Commons BCEL based on RC1

2017-12-07 Thread Sergio Fernández
+1 (non-binding) On Thu, Dec 7, 2017 at 12:34 PM, Gary Gregory wrote: > I am looking for more reviews from PMC members please. > > Gary > > On Dec 7, 2017 13:33, "Oliver Heger" wrote: > > > > > > > Am 06.12.2017 um 22:26 schrieb Gary Gregory: > > > Oliver, how do you feel about installing Java

Re: [VOTE] Release Apache Commons BCEL based on RC1

2017-12-07 Thread Gary Gregory
I am looking for more reviews from PMC members please. Gary On Dec 7, 2017 13:33, "Oliver Heger" wrote: > > > Am 06.12.2017 um 22:26 schrieb Gary Gregory: > > Oliver, how do you feel about installing Java 9 and trying again? > > > > Gary > > > > On Tue, Dec 5, 2017 at 1:48 PM, Gary Gregory > w

Re: [VOTE] Release Apache Commons BCEL based on RC1

2017-12-07 Thread Oliver Heger
Am 06.12.2017 um 22:26 schrieb Gary Gregory: > Oliver, how do you feel about installing Java 9 and trying again? > > Gary > > On Tue, Dec 5, 2017 at 1:48 PM, Gary Gregory wrote: > >> The test calls the registryGetKeys Windows API and that throws an >> exception because Java 9 is not installed

Re: [VOTE] Release Apache Commons BCEL based on RC1

2017-12-06 Thread Gary Gregory
Oliver, how do you feel about installing Java 9 and trying again? Gary On Tue, Dec 5, 2017 at 1:48 PM, Gary Gregory wrote: > The test calls the registryGetKeys Windows API and that throws an > exception because Java 9 is not installed on that machine. This is a bug in > the test only. Fixed in

Re: [VOTE] Release Apache Commons BCEL based on RC1

2017-12-05 Thread Gary Gregory
The test calls the registryGetKeys Windows API and that throws an exception because Java 9 is not installed on that machine. This is a bug in the test only. Fixed in trunk. Not a showstopper IMO. Gary On Sun, Dec 3, 2017 at 1:44 PM, Oliver Heger wrote: > Here is the stack trace: > > ---

RE: [VOTE] Release Apache Commons BCEL based on RC1

2017-12-05 Thread Mark Roberts
This works, thanks for including the BCEL-295 fix. So my vote is now +1. Mark -Original Message- From: Gary Gregory [mailto:garydgreg...@gmail.com] Sent: Saturday, December 02, 2017 1:04 PM To: Commons Developers List Subject: Re: [VOTE] Release Apache Commons BCEL based on RC1 Well

Re: [VOTE] Release Apache Commons BCEL based on RC1

2017-12-03 Thread Oliver Heger
Here is the stack trace: --- Test set: org.apache.bcel.generic.JDKGenericDumpTestCase --- Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time e

Re: [VOTE] Release Apache Commons BCEL based on RC1

2017-12-03 Thread Gary Gregory
Do you have a full stack trace? It smells like the code that looks for JDK and JRE locations is failing. Gary On Dec 3, 2017 08:33, "Oliver Heger" wrote: > Hi, > > when building on Windows 10 with both Java 1.7 and 1.8 I get the test > failure below. Does anybody else see this? > > Oliver > > R

Re: [VOTE] Release Apache Commons BCEL based on RC1

2017-12-03 Thread Oliver Heger
Hi, when building on Windows 10 with both Java 1.7 and 1.8 I get the test failure below. Does anybody else see this? Oliver Results : Tests in error: JDKGenericDumpTestCase.data:82->findJavaHomes:87->findJavaHomesOnWindows:97->addAllJavaHomesOnWindows:65 ▒ Win32 Tests run: 107, Failures: 0, E

RE: [VOTE] Release Apache Commons BCEL based on RC1

2017-12-02 Thread Mark Roberts
I will give it a try - but might take a couple of days -Original Message- From: Gary Gregory [mailto:garydgreg...@gmail.com] Sent: Saturday, December 02, 2017 1:04 PM To: Commons Developers List Subject: Re: [VOTE] Release Apache Commons BCEL based on RC1 Well, you you try this RC and

Re: [VOTE] Release Apache Commons BCEL based on RC1

2017-12-02 Thread Gary Gregory
ersion of BCEL, we were hoping that the next version would fix that. > > -Original Message- > From: Gary Gregory [mailto:garydgreg...@gmail.com] > Sent: Saturday, December 02, 2017 12:14 PM > To: Commons Developers List > Subject: Re: [VOTE] Release Apache Commons BCEL based

RE: [VOTE] Release Apache Commons BCEL based on RC1

2017-12-02 Thread Mark Roberts
] Sent: Saturday, December 02, 2017 12:14 PM To: Commons Developers List Subject: Re: [VOTE] Release Apache Commons BCEL based on RC1 Mark, Unless BCEL-295 <https://issues.apache.org/jira/browse/BCEL-295> is a regression, I see no technical reason for a -1. What am I missing? Gary On Sat,

Re: [VOTE] Release Apache Commons BCEL based on RC1

2017-12-02 Thread Gary Gregory
ssues.apache.org/jira/browse/BCEL-295 >>> >>> Mark >>> >>> >>> -Original Message- >>> From: Gary Gregory [mailto:ggreg...@apache.org] >>> Sent: Thursday, November 30, 2017 8:18 PM >>> To: Commons Developers List >>&

Re: [VOTE] Release Apache Commons BCEL based on RC1

2017-12-02 Thread Gary Gregory
t; https://issues.apache.org/jira/browse/BCEL-295 >> >> Mark >> >> >> -Original Message- >> From: Gary Gregory [mailto:ggreg...@apache.org] >> Sent: Thursday, November 30, 2017 8:18 PM >> To: Commons Developers List >> Subject: [VOTE] Relea

Re: [VOTE] Release Apache Commons BCEL based on RC1

2017-12-02 Thread Gary Gregory
e version of bcel. > > https://issues.apache.org/jira/browse/BCEL-295 > > Mark > > > -Original Message- > From: Gary Gregory [mailto:ggreg...@apache.org] > Sent: Thursday, November 30, 2017 8:18 PM > To: Commons Developers List > Subject: [VOTE] Release Apache

RE: [VOTE] Release Apache Commons BCEL based on RC1

2017-12-02 Thread Mark Roberts
Subject: [VOTE] Release Apache Commons BCEL based on RC1 We fixed a few bugs and added some enhancements since we released Apache Commons BCEL 6.1, so I would like to release Commons BCEL 6.2. Commons BCEL 6.2 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/bcel

Re: [VOTE] Release Apache Commons BCEL based on RC1

2017-12-02 Thread Gary Gregory
+1 from me and a request to the PMC to have a look ;-) Thank you! Gary On Thu, Nov 30, 2017 at 9:17 PM, Gary Gregory wrote: > We fixed a few bugs and added some enhancements since we released Apache > Commons BCEL 6.1, so I would like to release Commons BCEL 6.2. > > Commons BCEL 6.2 RC1 is ava

[VOTE] Release Apache Commons BCEL based on RC1

2017-11-30 Thread Gary Gregory
We fixed a few bugs and added some enhancements since we released Apache Commons BCEL 6.1, so I would like to release Commons BCEL 6.2. Commons BCEL 6.2 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/bcel at svn revision: 23349 The tag is here: http://svn