Re: [VOTE] Release Apache Commons BCEL 6.5.0 based on RC1

My +1 Gary On Fri, Jun 5, 2020 at 6:02 PM Gary Gregory wrote: > We have fixed a few bugs and added some enhancements since Apache Commons > BCEL 6.4.1 was released, so I would like to release Apache Commons BCEL > 6.5.0. > > Apache Commons BCEL 6.5.0 RC1 is available for review here: > http

Re: [VOTE] Release Apache Commons BCEL 6.5.0 based on RC1

Here is how you can build on Java 11: mvn site -Dcommons.spotbugs.version=4.0.0 Gary On Mon, Jun 8, 2020 at 11:00 AM Rob Tompkins wrote: > Yep spotbugs did it. > > And agree with the bafflement of maven plugins (even one’s I’ve written > baffle me :-p ) > > -Rob > > > On Jun 8, 2020, at 10:55

Re: [VOTE] Release Apache Commons BCEL 6.5.0 based on RC1

> On Jun 8, 2020, at 10:58 AM, Gary Gregory wrote: > > On Mon, Jun 8, 2020 at 10:44 AM Rob Tompkins > wrote: > >> Gotcha…just ran for posterity “ mvn -Dclirr.skip=true -Djapicmp.skip=true >> clean test install site” and got the following (don’t have a good answer >>

Re: [VOTE] Release Apache Commons BCEL 6.5.0 based on RC1

Yep spotbugs did it. And agree with the bafflement of maven plugins (even one’s I’ve written baffle me :-p ) -Rob > On Jun 8, 2020, at 10:55 AM, Gary Gregory wrote: > > On Mon, Jun 8, 2020 at 10:38 AM Gary Gregory > wrote: > >> Thanks for the review. >> >> Ye

Re: [VOTE] Release Apache Commons BCEL 6.5.0 based on RC1

On Mon, Jun 8, 2020 at 10:44 AM Rob Tompkins wrote: > Gotcha…just ran for posterity “ mvn -Dclirr.skip=true -Djapicmp.skip=true > clean test install site” and got the following (don’t have a good answer > here, but as "mvn test” works I’m not concerned): > > [INFO] <<< clirr-maven-plugin:2.8:clir

Re: [VOTE] Release Apache Commons BCEL 6.5.0 based on RC1

On Mon, Jun 8, 2020 at 10:38 AM Gary Gregory wrote: > Thanks for the review. > > Yeah, the code coverage has never been great for this component. > > Clirr should not even be run, you should use japicmp, to this effect the > POM sets: > > false > true > > When I run the build on Java 11 w

Re: [VOTE] Release Apache Commons BCEL 6.5.0 based on RC1

Gotcha…just ran for posterity “ mvn -Dclirr.skip=true -Djapicmp.skip=true clean test install site” and got the following (don’t have a good answer here, but as "mvn test” works I’m not concerned): [INFO] <<< clirr-maven-plugin:2.8:clirr < compile @ bcel <<< [INFO] [INFO] 'compile' forked phase

Re: [VOTE] Release Apache Commons BCEL 6.5.0 based on RC1

Thanks for the review. Yeah, the code coverage has never been great for this component. Clirr should not even be run, you should use japicmp, to this effect the POM sets: false true When I run the build on Java 11 with: "mvn clean install site -V": Apache Maven 3.6.3 (cecedd343002696d0a

Re: [VOTE] Release Apache Commons BCEL 6.5.0 based on RC1

Everything looks good to me. Only nits: couldn’t get mvn install or mvn site to work with java 11 (clirr failure), and code coverage is lower than I prefer (but that’s ok for a release). +1 Cheers, -Rob > On Jun 5, 2020, at 6:02 PM, Gary Gregory wrote: > > We have fixed a few bugs and added

Re: [VOTE] Release Apache Commons BCEL 6.5.0 based on RC1

Thanks Amey. I am aware of the Javadoc warnings, I just did not want to take the time to address them. Please feel free though ;-) Gary On Sun, Jun 7, 2020, 11:21 Amey Jadiye wrote: > +1 Release these artifacts > > Everything looks good to me. Build passing on java 8 and 11. Tests, Rat, > Japi

Re: [VOTE] Release Apache Commons BCEL 6.5.0 based on RC1

+1 Release these artifacts Everything looks good to me. Build passing on java 8 and 11. Tests, Rat, Japicmp, checkstyle passing fine. 1. Apologies, I might have missed discussions but I don't understand reason behind @Ignore on JiraBcel291TestCase and skipping it from test suite. [INFO] Running

Re: [VOTE] Release Apache Commons BCEL 6.5.0 based on RC1

  [x] +1 Release these artifacts Build passing fine on Java 8, Ubuntu LTS. Site generated successfully too, reports look OK. Thanks Bruno On Sunday, 7 June 2020, 12:34:19 am NZST, Gary Gregory wrote: We have fixed a few bugs and added some enhancements since Apache Commons BCEL 6.4.

RE: [VOTE] Release Apache Commons BCEL 6.5.0 based on RC1

I ran all my tests with Java 8 and Java 11 - looks good. +1 Mark -Original Message- From: Gary Gregory [mailto:ggreg...@apache.org] Sent: Friday, June 5, 2020 3:03 PM To: Commons Developers List Subject: [VOTE] Release Apache Commons BCEL 6.5.0 based on RC1 We have fixed a few bugs and

Re: [VOTE] Release Apache Commons BCEL 6.5.0 based on RC1

>it seems you are talking about moving some dependency management from this component to the parent POM. Yes, I'm talking about this part in bcel's pom.xml, org.apache.felix maven-bundle-plugin biz.aQute.bnd biz.aQute.bndlib

Re: [VOTE] Release Apache Commons BCEL 6.5.0 based on RC1

I am not sure what this has to do with the release, it seems you are talking about moving some dependency management from this component to the parent POM. This should not hold up the release unless I am missing something. Gary On Sat, Jun 6, 2020, 08:37 Xeno Amess wrote: > +0 > > @garydgregory

Re: [VOTE] Release Apache Commons BCEL 6.5.0 based on RC1

+0 @garydgregory 1. should we change commons-parent directly, thus we do not need to change every repo's pom.xml? 2. I see you add that plugin in in this repo's pom.xml. Is it really needed? can we simply add/change ${commons.felix.version} and ${

[VOTE] Release Apache Commons BCEL 6.5.0 based on RC1

We have fixed a few bugs and added some enhancements since Apache Commons BCEL 6.4.1 was released, so I would like to release Apache Commons BCEL 6.5.0. Apache Commons BCEL 6.5.0 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/bcel/6.5.0-RC1 (svn revision 39954